From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E82313F2113 for ; Wed, 19 Aug 2026 08:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128786; cv=none; b=bSjKZVH5RwcUwLiCIj4tt6U9AO1pDcRKg+0d9vRyQpS25LORDNRTisDq+rotuWc1TRMvmi8LR5p6OMlnAbzaAUE3oFMdHxU5a/yKS2I2gmSzoiDM1E2s9ei7iJT1nWbCzMCwGUfbPipgbbFlNAmVh0qlJvWbfpegxnTB+YKctTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128786; c=relaxed/simple; bh=k6veVcbdMYtnCTYSPsQo4dfEkHOtd7/pm7jM7tctsp0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HjKHLHX6X3ih/B7blxyyezs23UKovObnUosbgeYgGt5qRKAb2dhiUKIBCMgQkjgtdYZ6/uIHt4GZN0tCXtrTpDkFRiHMTNgL0qPLK55ijCQYPI7pxjjvtwR4nTVYG+MIt7+2yKMzZ5c7446I2GafdIYyzsJQfwrgHxVg60OzZSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XN1gKiqs; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XN1gKiqs" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-482938466a7so591488f8f.1 for ; Wed, 19 Aug 2026 01:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787128783; x=1787733583; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fje4etQPnJMZ273NClwRY+zJPLBaH6wZ2nXYH67K/58=; b=XN1gKiqs/hZYRuFRCExagYPnYlw1mMGavmN7bzrEuVS66TLGv5DGxs7G195g8n5EG7 hIg0Lwacvwk0yQweJgPeGDFA4jd9r7Sbit5ICjArRLTJNm89njwV+56Wc8DgjHWCDVRK apquni9P+asicZJnpmGkyYuPRpglbGs6UnyBzeUoH0vW5zdJURL1mKa1gwE2FmIscI7I Qv1fg1jHbzXdlxSE3VIOas+q6K6Yuaku6xxWn3iNdLCiUSA6eUauZKldLku+5Z9UDESq AMrEv9OCZCPsdyUWXObdoIRrKnu3++LnQZyzFQzPva+xY1Hd7imXzJ19rhYUHYSRp6X7 55GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787128783; x=1787733583; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fje4etQPnJMZ273NClwRY+zJPLBaH6wZ2nXYH67K/58=; b=LUJzRGxymVivwcleeqQmZS3Z+fSaKcK9Dexu3My9URIB1V1zVm+CucBaL8cRuhmGvg nogHxYqVhdcscYup/MgmmmdW+kxWUdCLy6Grfey6oJNX5o1xDlV4KDOJ1l7ZWz1umyEX 2T6QRpIf6gr/9tN0vtxfZTMp5JECILV+YmRPhfO0u53ZMb6Ht8zrQpBkqxKWOGVs+AjN EU+xQ2VGB+Km5qBxWtvNny2shusLefQO7fntMY5WcfL95M/kiMU5mAohddiOIsK4MjPM q7ej8R3hvI0zDtgyhp5aXHhZhiXVm5cAHrsOpCgnrdupJ2IRBjQzZm+85M0+oyhRW2sb 7e0w== X-Gm-Message-State: AOJu0YyqQua+pZlM61xBVmcgH5S5bn/W8ScapBKZ/OyU9BzPCbYt6lY7 vGVHZb5GZG8nn/blVE1nHVkGDqUfdOAQL5tdzMwKOM0IFakSgZnMx6Xi X-Gm-Gg: AR+sD13/3P6Ci7DHYZ3lBSnTdLpE7goXrJqo+xk/GbBw9DnwXvp6zTQaNPUcjpQvsfG siYA/Z3sBm1cmf9ymB8I+dsYMITvZK0E/QLmNb5OIIFQzAl5WiihRtY0vWNpaATOL3OJu+xOqDf TuqB4WudK2EyvBXwvrB2cL5rT7ajQ8IfsEw7Fz/JgdurO+yeD5+YrwgiXhhJJ5/LuEgoQAszee9 AkLdzANS0ZTfhvvWneI4KY6M0lhCPdeE6kYzvN6PR9lv0IGph7ImYTFiTS1xUT6E+NYyS99t5mK 3wC4QD24zn6nvi4sgfzLQ4oeUqFCA5+5l/0Qbj4LY3HUGb1hETneJgFKFi3Bl7GFlo3FPyW6Agm CXG/8ZwwfhXvn4VZnsdhBbbdt/lG6/ZMNCVkGjUPHMGOz3WZOgQ1CGa8b5YKYaPH2ADaytKIKRE UtUbc4TEfgqNJJy4D3AN6B2waeFl9Byl53IVd1cXudOV1BYE66KhgF/GLifkw3drFP7Vxw X-Received: by 2002:a05:6000:70d:b0:482:552f:ef68 with SMTP id ffacd0b85a97d-482b1ff5862mr4803846f8f.19.1787128782984; Wed, 19 Aug 2026 01:39:42 -0700 (PDT) Received: from SurHub.localdomain ([196.188.112.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14d059bsm3813928f8f.36.2026.08.19.01.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 01:39:42 -0700 (PDT) From: Abdifatah Suruur To: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, alex.williamson@redhat.com Subject: [PATCH] vfio/platform: prevent read-only region mappings from becoming writable Date: Wed, 19 Aug 2026 11:39:39 +0300 Message-ID: <20260819083940.1374-1-suruurism@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vfio_platform_mmap() rejects writable mappings of regions without the WRITE flag, but leaves VM_MAYWRITE set. Userspace can map such a region read-only and then upgrade the mapping to writable with mprotect(), writing to MMIO regions the platform marks read-only. Clear VM_MAYWRITE for regions without the WRITE flag, as i915 does for its read-only objects and as fixed in drm/vc4 (CVE-2026-68445) and drm/panthor (CVE-2024-53071) and ptp: vmclock (commit a5edadbae57e2298a56cf7a4e774a027905a331f). Fixes: de49fc0d99e6a ("vfio/platform: initial skeleton of VFIO support for platform devices") Cc: stable@vger.kernel.org Signed-off-by: Abdifatah Suruur --- --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c @@ -594,7 +594,11 @@ if (!(vdev->regions[index].flags & VFIO_REGION_INFO_FLAG_WRITE) && (vma->vm_flags & VM_WRITE)) return -EINVAL; + /* Prevent read-only region mappings from being upgraded with mprotect() */ + if (!(vdev->regions[index].flags & VFIO_REGION_INFO_FLAG_WRITE)) + vm_flags_clear(vma, VM_MAYWRITE); + vma->vm_private_data = vdev; if (vdev->regions[index].type & VFIO_PLATFORM_REGION_TYPE_MMIO) return vfio_platform_mmap_mmio(vdev->regions[index], vma);