From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2B9E425899 for ; Wed, 19 Aug 2026 08:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128796; cv=none; b=BqoMNa0WLIvFw5QbpiU6fhj+Z9IDMkXYIPpj1TAfy0/XIJlqdLjGoczJWe8cA55wHuLnRscI698wTje+IsGtX6E//JyasMfcPK37PILZdqtKa2FlhxTyneKgGdNIuKX/cCYu/yjNSkyllh6m729aLM3hIAPhAIuVmTH69hoiW4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128796; c=relaxed/simple; bh=UmLSjR5vN/pqFUICwJ0uRR2Xb4U0t7SCQgme0ppWNls=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OEki++MddMOj+ODX+zABoUYOPZBHaUfP75Xy8zxVdOh85liRfex0BHwzIlQjTb5Z90WgVGWK0hwNKflOd+acz1MCR4nMAoqXZuk36Bwp4KSWOzH4hW37NmChf65LxDBmjga5MeHJT21oKxrHKVoSzGVBh8H6TfhUEDvlSxD0OF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bsfdPaXU; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bsfdPaXU" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4998590d392so6875915e9.0 for ; Wed, 19 Aug 2026 01:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787128793; x=1787733593; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FCAXhmh1ysx49XvDb1i6Lpx6/sN5RWuZrnkbED6pwZs=; b=bsfdPaXUPduE1z/kLVo9063QiRwJZktDWqbdicJjLj07glJaeEVCLeqxZbAu4vselg wMV2c+1/BAXGmUqW/m9IhHHqxvafGqzWzud2GtZ8CP0W0VtquRwyivTwzS9J5Oa/kZ6o M11rcrYJ41ax/ktXbL+fJvhZ+9NnI8SwCuRo4Aus0+ighmmbYs34PiXboPVicol1M147 /Ig3SPQCADNb14YwFcEZQZ0kXFAPK0MYY17N75Te/D05P4aoJP6kiBqGB92C4rVnbSHP Jpdx6ycxR4jGZAguYJbEilrbORmY2wfraam5KChRzPESmVF9/7LVgyBgiTs3ighJ5d0V DQvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787128793; x=1787733593; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FCAXhmh1ysx49XvDb1i6Lpx6/sN5RWuZrnkbED6pwZs=; b=iynQWadlV/N+6qlUV04ctD8EmE7B3HDmppnPIUtb/w5lBWEG6XB2BWcpSCHmA9Rxzi tGuntLXzdzMG29nnZLd1OjWLtXMdNBFvTWd3Edw7sf/nG99vb/b1J5Kof0NMrpqxfbBG FtPRhgK11Iz6BGGQASfjRd5ChuYiUmDLCARF8egtUgBd7Vcy7yl5Z1tfU5cWEquCLRaH AHZHxQ8aN+d0Tdnmy+dIDzeeT0NP9zbEfBL+jpO8SOWBK0eCk2obygREDEl1gEnxiCgf J5pcnE1/fBi409EdDbe2nEqyaN9Yr4sZuYagK93Fs45r9ITX12T3L2+HoBMUcJ4tP/V+ LZcg== X-Gm-Message-State: AOJu0YzCGK/G7NJ0NZZNUqgJb59TGUfy/37aFO9wOpoSJWKpK04hzrNI /tBhJfvwfCQX8udDFy+oYMoeq7zJHdACq1g7Ux3om4s+Yk7u3EADb7Q4 X-Gm-Gg: AR+sD11XfBP7bDcUQXSxpGXOAd3UPQSQcyBoxVEiw+GFCnBjWySg9RPZMnoJToMDOwl XU0iuv9iAFKQ2ebE7YEPt45Q/GNgQ4MeFGF7dBUACmhjjSET9sMT0fJtlSDvULAB/v39R5AfP2j TzTYc9QS0QgLv8vStTo3IM6Db/dabMjacLZndyIhnydbe+A802kLsuzHeWb14X2ONAwCUoHOM+2 R3Z2CH3Ajx6ymcxD2lrtNrAMrJa7KQ0SAqo3qJg+L9qT9GzZU/JEtQsVQmU25cxnWuZZf/k0XjG 8raiCVXkP4VLKgakhfGVncpvuDGPZmLtsgYnEUFg1WU0qWXkW+gFpeF3OnUDR434mMXdfBybDiG blZgpI2sOpgJCA9/w3zYpDHMa+4B9+ADVmLdksFSj2rf2+aNkfrfJ1XdAkdbmdK3HtLi25olp9p IF3PfAYaJu8miSjOqff4QD/92GwOWkajJzQv22d/hOTJG/LmXOMn1tNdOvrrBF23ddsJgI X-Received: by 2002:a05:600c:8b32:b0:496:c06b:9fb4 with SMTP id 5b1f17b1804b1-499aa200efcmr52486565e9.14.1787128792869; Wed, 19 Aug 2026 01:39:52 -0700 (PDT) Received: from SurHub.localdomain ([196.188.112.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499a9aa1594sm42869985e9.0.2026.08.19.01.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 01:39:52 -0700 (PDT) From: Abdifatah Suruur To: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, alex.williamson@redhat.com Subject: [PATCH] vfio/fsl-mc: prevent read-only region mappings from becoming writable Date: Wed, 19 Aug 2026 11:39:49 +0300 Message-ID: <20260819083949.1408-1-suruurism@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vfio_fsl_mc_mmap() rejects writable mappings of regions without the WRITE flag, but leaves VM_MAYWRITE set. Userspace can map such a region read-only and then upgrade the mapping to writable with mprotect(), writing to MMIO regions (e.g. response portals) the device marks read-only. Clear VM_MAYWRITE for regions without the WRITE flag, as i915 does for its read-only objects and as fixed in drm/vc4 (CVE-2026-68445) and drm/panthor (CVE-2024-53071) and ptp: vmclock (commit a5edadbae57e2298a56cf7a4e774a027905a331f). Fixes: fb1ff4c194157 ("vfio/fsl-mc: Add VFIO framework skeleton for fsl-mc devices") Cc: stable@vger.kernel.org Signed-off-by: Abdifatah Suruur --- --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c @@ -406,7 +406,11 @@ if (!(vdev->regions[index].flags & VFIO_REGION_INFO_FLAG_WRITE) && (vma->vm_flags & VM_WRITE)) return -EINVAL; + /* Prevent read-only region mappings from being upgraded with mprotect() */ + if (!(vdev->regions[index].flags & VFIO_REGION_INFO_FLAG_WRITE)) + vm_flags_clear(vma, VM_MAYWRITE); + vma->vm_private_data = mc_dev; return vfio_fsl_mc_mmap_mmio(vdev->regions[index], vma); }