From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC4F3B531D for ; Wed, 19 Aug 2026 08:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128853; cv=none; b=AdNr4egZpUvfYbh9srKXShqL3ACvafD+RGDnw1ipZbC9W26MahjRlGd+eDUy1TVWmWrOV7IyrzArDlxAg3GBNnq6EGyn4pcSezyxQlDWZ0GY1ADhuWidrsSGzRta6XcElnDEw1sDwRLRhuJR7CHlr/Zd4YEBBMRp9u/55BGbPmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128853; c=relaxed/simple; bh=GMowu2iynCcNzROcJEdJQ5/+u+MAHjsvsBWL0ZZIAjg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eElH8Gj/+k1NU2TgUkQaMNpaEYKDydjMGLcazlNuh4BxRkLqH45Ad/opA7xj6kySbaZkPFgutWuvJU5iFn5f62H2ybisiqZlphS3AzwOMzvS/bMlw1/ASkX9cTq9KJiQ8hw+na0aKk+p75SbD2+ZR30M/qmYjpPxe+zcVBnsTos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oagAlJOM; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oagAlJOM" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47f7027ca11so415904f8f.3 for ; Wed, 19 Aug 2026 01:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787128851; x=1787733651; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yB6JEi4fc2rxeFHvTUIWmqP9ewveXbrmeQ7lWaASPb0=; b=oagAlJOM2trt43X6V7NPpTyjnsgSAb04QXsxgMEcNUjmxl+0GdNO+WHxf/DKUw2Ga+ INVlv9GYs//1C6Dg0c9V7PlznPTRhx0c4jqKYNZ7h3YUs4rsyf9GNPz3eIfAGDJqJKkP UOxpy+BAAsmMSo/vB6ZcOHTMXBjZeNaj5r6hu2BW9e/8/z5B1+s3g0Ox7wC3NP/0neYR 9lKjVYkUraFA7TLgUh6hWJdh7NLnZvEJEj0s1/pJglKCgpqpnySnNyZAqUiuDk4Zber5 igm/frWLHG475Wp9+E35DcuhTrw/J/DmRlu1KiKhFwgyRplyszq3KjXL+87O1IOi3DZX FnCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787128851; x=1787733651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yB6JEi4fc2rxeFHvTUIWmqP9ewveXbrmeQ7lWaASPb0=; b=np06hj2NoEDcn7kqAkSDSjDBnu6lguy7rwIgUq68wqipcTitgNcE1DXX2NLv/U/9Lc y+XhqahRrTFhJyabw20gapxQ+p+3h+x0Na02pRoSj93G4LN2X6I+29amX3tZ1wAruL1L lkQHwy1lr9deaoDlD0luJs3lrI67CdUvkbOw6iPhf3ZiPpGA4ILGCh/OC/+N61vK8sQy VpBFnV3GWdT0G+XtbjEjI1tBPunFgCMs7uD6hULzYqAn+dH7fJDSFDNYdym6UuxPIQtw Y+bctplAXGDydkkQH5Ye862Om7jaHrh3ZSU9hy8Xl92/RfeqTyLUC/RFR2ABudUKLah0 bX3w== X-Forwarded-Encrypted: i=1; AHgh+RrYwBQGnCNmpcIXi0yO5fY0ReSkHxmm4UDHTyLG67r0q/VIbrSHL8nINrVu4PvzAlDThY6T9eL/H7bCjcU=@vger.kernel.org X-Gm-Message-State: AOJu0YzynbDUdDkRm6zdr/ue3x4DRzgN+zzlbYoAUnOvDotWcKGOxRrK 4q8TH+4njMvMfDGlKAkww0Wl1f73ZhlVpu3xLTUR6Yv732km3/breIQZ X-Gm-Gg: AR+sD11ikM7Y/EZMmzHzmY29XLk9onK5cuyuq4rWPhNMcU6ajQHLo/qsIM99+QQ33+L ksD5etMy5fJDl0upz5pWe/eVSWejkoZ41fbf+OJZEUNtT8dL9hqcrg/gaBW5t42av3Z7UlA2IkI WKvDTROhz+3AJp8Mgdc3lMYBHGy1hEMePLLgEhmJMnI52EHEv7VhbCCXit90FGRqErUI9+fkf0y RKs7MHxXMRyrozQwcK4t05nxt/kP7xVPbnRiC9UeVUZiHeRaYQsOS4ngFkZU5Zu8SQZvs2Crqkh S5p1Ko4NSnx2w5FIonMMLz8YHxu4anriTWy18obN+6QfPMOOJAwi7Y13V9t7Uux3o8KDSJ6yCZF bQYAJ2QMuHdiWUVIIf5sUAHbd7BbOn2kP7DUTckf0tFwEGYbQvC0lt4/hjGFQrmp0WAnS3OYPZ3 uknL7kU26LPE+CD9sqTZLWtJ/0qq9Gj1Y9BVtwdE/EWoVhYcukO8hBppKPlXfen5pN58AbBKL3X fqLfMTbZo3yJKkD0q/8nXbCnw== X-Received: by 2002:a5d:59a7:0:b0:481:44e5:160c with SMTP id ffacd0b85a97d-482b1e8632emr5012255f8f.2.1787128849753; Wed, 19 Aug 2026 01:40:49 -0700 (PDT) Received: from fedora.1337.ma ([197.230.240.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14c45d1sm3637685f8f.30.2026.08.19.01.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 01:40:49 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: andriy.shevchenko@intel.com Cc: 0rayn.dev@gmail.com, Michael.Hennerich@analog.com, andy@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, dlechner@baylibre.com, jic23@kernel.org, krzk+dt@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux@analog.com, nuno.sa@analog.com, robh@kernel.org, skhan@linuxfoundation.org Subject: Re: [PATCH v4 5/6] iio: dac: ad5504: strictly separate ACPI and DT probe paths Date: Wed, 19 Aug 2026 04:40:45 -0400 Message-ID: <20260819084045.16300-1-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > #define AD5504_VA_ACPI_DEFAULT_mV (60 * MILLI) > What does VA stand for? VA stands for Analog supply Voltage as far as I know, following Analog Devices datasheet convention. Will rename to AD5504_VREF_ACPI_DEFAULT_mV to make it self-explanatory in v5. > It's better to use has_acpi_companion() or is_acpi_device_node(). > I prefer to see the latter as that one unifies the style of checking > across the drivers and subsystems. Will switch to is_acpi_device_node(dev_fwnode(dev)) in v5 and add accordingly. > This should be (MICRO / MILLI) instead of MILLI. Will fix in v5. Best Regards, Taha Ed-Dafili