From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 439594252D5 for ; Wed, 19 Aug 2026 08:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128938; cv=none; b=U4jjP/HlqXNmatiyHLFr64Ncn26IL+RgfWO2hbeVU/Kdtfw76xLoCE4wcNuOOhx/Oq5Ut42yg5K4wXYlJYaGOVegYBWigxJHiR3BtzG3JAADi70eqm/jSLbgGuYYWSyTKyv8ZMpzB9p4XmPC5XjNX+oRwLve2sR9mMK+o7xT984= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128938; c=relaxed/simple; bh=UmLSjR5vN/pqFUICwJ0uRR2Xb4U0t7SCQgme0ppWNls=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=r7VJInamDzfP0iEY+zsIaWFA7p/NIyaWdgV5yLiGeSV/Tr5MmhgUXBwj7Sz9b3xlcoDKEkTLch6gK4q6O91EBq8oBbh5wKHatf0enp59msXSOvZrkrpeaUB6dlE759M8RcsNpSLK8G/DpR7XjE/64HMVREzL8cNUDfjgFbNY47E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fpWA3ep7; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fpWA3ep7" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4998e0916faso5857565e9.2 for ; Wed, 19 Aug 2026 01:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787128933; x=1787733733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=FCAXhmh1ysx49XvDb1i6Lpx6/sN5RWuZrnkbED6pwZs=; b=fpWA3ep7KVINvy55WUWloy9VljM9oUrDxqO5VvnHaywLrgsxQqderEsZR/mWJTJZuo Phj2Rd02KHOmnceLRxajUjNutns5JFP1w3BHxUNpuUlZIoDn85kar0GjXBMkp9BNVxPE qLoewrmXeKxVVJz3P7ncWgd9EiMnc3xinvkq8jkb49zugV/X6o21bKXlCNilSMHe0Xvo /Xxa7TWA+rErQ54zbiGAjnFnb36B1+hU+DKpIkihDNoPiG62XNIpawKplNFvBQkZV8QQ SdLFLR5/MzK6U1LU7wWUSkC+T5bj2IhiZ6JbU2GBvUPU57sirXe94YEg0Buh1u3Fwbpn zoyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787128933; x=1787733733; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FCAXhmh1ysx49XvDb1i6Lpx6/sN5RWuZrnkbED6pwZs=; b=DnSbAncjIOgEr075/n2x1PfwAryaaHCQmnZBmSNFpaTSZhVGG12LekDkyJp7OgSEEH iSTgxsV7OKsCL/bEekEnK4gyXF41MgW8u33eNT1+w3PaM0qstfWKo/SkBJ604HNiQbip bUu4wf62cb6OdYj8gzclilUIT0+FLmnvYQUidCbgMiq1ygdXvyfAIC12ar0SF/inB8Wq 3zlKPjuSyz9lI0+WREsYgQLY8BFybtqUBoC5IUHVyYWGuuYS7s8iCXO5SDp5SmQzLeKU 6Puaj/pHR3ORQE3XuP1/6DG3l7wJbmt3GNXsoyex9k64gmH8+pTsC1ZK3PMR6h7fagY+ 4U8g== X-Gm-Message-State: AOJu0Yzv+6ebk3fDp5/8xRjYdJSk35v6O60gMwEkMrVJBTrCMBTuK1j9 mTfHdwi5OG9+zp1rM+zxzZMwVQctpNixtjuGPwUszGCqEOGHiMBOfW/Q X-Gm-Gg: AR+sD12mUCYUOpYtB+LHLBckfj94v4kvreRpE47Gr4knPTlSZj+jfOqd2Hq1stY96cM crLb1yIrLlAS35bcUv9knup16U8oWyjt0l68ZCKWpePqpNTAUA7PiXANNn6Il/5kK1YrDX/3XJh +oYYY5Qvrg1hSRuO18RzWjA3bOc1mar+X5rdIdhbmwJvf/wgjDNPa67h2us3bDu+S9z6/WpWUmW SVUw+ZlbGtuMm0TwKu34ihTrKPJHS+RebpwcvHx1GH5STuoOIictRv9gke2nqBCRqEmIC/B56uU 8CbEthcRnNTWczhVmdydNf9Qt9OxiJdq5lTPmsAMr0zlI4XDV082Dcv24hlTyrp3QJqNC9ltj8I yDobyL3p3ptYzGCrDEQW3I0HbhYgfEUJYC4hKxge+icJ/2PZW8zdUeUZEwD1jtrWkgM6aT+3VZd bGeynFsLy53DbdnzN3wc7I5oV6N/k1p7iTszlsFiOys7Olws+zkUry/Mo2O6s+nLvM16/zQsAD7 FRkgcU= X-Received: by 2002:a05:600c:37c6:b0:499:87f3:a2a3 with SMTP id 5b1f17b1804b1-499aa1c7bafmr53853455e9.15.1787128932584; Wed, 19 Aug 2026 01:42:12 -0700 (PDT) Received: from SurHub.localdomain ([196.188.112.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa1947c6sm41093775e9.15.2026.08.19.01.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 01:42:12 -0700 (PDT) From: Abdifatah Suruur To: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, alex.williamson@redhat.com Subject: [PATCH] vfio/fsl-mc: prevent read-only region mappings from becoming writable Date: Wed, 19 Aug 2026 11:42:09 +0300 Message-ID: <20260819084209.1543-1-suruurism@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vfio_fsl_mc_mmap() rejects writable mappings of regions without the WRITE flag, but leaves VM_MAYWRITE set. Userspace can map such a region read-only and then upgrade the mapping to writable with mprotect(), writing to MMIO regions (e.g. response portals) the device marks read-only. Clear VM_MAYWRITE for regions without the WRITE flag, as i915 does for its read-only objects and as fixed in drm/vc4 (CVE-2026-68445) and drm/panthor (CVE-2024-53071) and ptp: vmclock (commit a5edadbae57e2298a56cf7a4e774a027905a331f). Fixes: fb1ff4c194157 ("vfio/fsl-mc: Add VFIO framework skeleton for fsl-mc devices") Cc: stable@vger.kernel.org Signed-off-by: Abdifatah Suruur --- --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c @@ -406,7 +406,11 @@ if (!(vdev->regions[index].flags & VFIO_REGION_INFO_FLAG_WRITE) && (vma->vm_flags & VM_WRITE)) return -EINVAL; + /* Prevent read-only region mappings from being upgraded with mprotect() */ + if (!(vdev->regions[index].flags & VFIO_REGION_INFO_FLAG_WRITE)) + vm_flags_clear(vma, VM_MAYWRITE); + vma->vm_private_data = mc_dev; return vfio_fsl_mc_mmap_mmio(vdev->regions[index], vma); }