From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4CB442BC5D for ; Wed, 19 Aug 2026 08:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128942; cv=none; b=A0invSJXtsr58uV8zZtUCJxOYCZSTvFayPkZuo45xCGwPE7gWTWeIVkk3bbMHu/hgeFFBaFFBTybYHnfKvBQsIUurzXSD+lF24WCJr96E06DvEqeIS+ff3jqJufVv9f+Fa5RqeiAD0Oe8DlUhSuqptZE64/B3yusrlkDiL/pRnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787128942; c=relaxed/simple; bh=HDUGLWiuk/eVKtE186LgSFkZm9RmgGSssHuF/3dExcI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O7U4uGOFdLnL5c73ygVY7Xhs+5er3FiUJcxipaI3UwS9YTjsF+eTmad5brTlqObEMHJepKZMPavLJ9jUEB8umARe/0m7WxjZA6r0wshTwICiwlG0KfqZMcN++FYajOJ93Ib6/Z8kmvK9EKw71jII6QyggqqU3gh0MrP5C9yKfSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NntbZKjt; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NntbZKjt" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso4855545e9.1 for ; Wed, 19 Aug 2026 01:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787128938; x=1787733738; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=nHLYTAe2NeEYLvkSf0CCqbrwJ7XqAE4/5Y9ShekbEQU=; b=NntbZKjtz8sxVe2VyeHMUb+BORrV4NEPHlc2SccvkHnbLXjxaV9AKsP6FgXcz5Apuu cAuMZRHIcvz8nSM/ukomcOPKLjefeW9nzvNQY6cSnwcnstLXDq1gWVxF9hMot2Umm7kZ 3dEFN1xf5MMRPSIfLCpM4gIl+cC1FtrU4yGkS9WwNH11td4VF8BA36jKFNAj8xwhfF6s qV3uMjPd1vwg7iiRwAMTAtB3Xoe7aJ7j2N8LmdgFTUQrKTUV+F2CMai5cIj0He/o3VLc 2S9vymmQdM+nSUVH/NbMpkG4SP8U3KJ+yBic4mVm1ZIeOoCrafg0Hhp4MUJzdMeifaKC szqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787128938; x=1787733738; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nHLYTAe2NeEYLvkSf0CCqbrwJ7XqAE4/5Y9ShekbEQU=; b=hYj3/REszOsaUZM20pDgd+vbnofGj436CTL5MC38eQdADn10nYKvXDPJVFG9xaa280 +ZQGmGI14pHfo4mmeuMVOH2jnmYv1v/RV+1AERv4vRawMeDM0n4oL9SLWlWh9v73EO7i zcUYgILzVCdgcHsbo5QQNTh9H3GKfEdiHqstqKAkz2gpmeCCog0UztCN6OsDvanPZ2c/ FMH4fs90zQwhqtQpZxsrgE+nReu6eWdh1xjIBOZokyhM86cER9FTNOScURmoa/M5vWnx jvibSEMdyUIbkdwHO3xnGhTrSrXWmUBTK4guIye20SeKibEiQDtW/2xAoW3VDT7Ybrph slcw== X-Gm-Message-State: AOJu0YxP8o6Sjg9B0VLMdUBZwjPo/e3U7iVy1rsc1FdptVlfQ1tS2Tbb 76e3t6fOLoZRqEhTv8UBPQwXb7kxezrnoSFM80origAfmoH7wn/ZRex2 X-Gm-Gg: AR+sD10e+maNuZVHUk9xFBDPlkHQ9LIz8VdSxnxHnmQHkex4fITq+x745VO5v5hXvsh 8VQ3RX0hSpNps0TFm/9XDQc3xz7iW4SR3SZAO4ulB1mSWOy5uu5gTgDbjLo8EVf7JGRgOFRZpkv EtKhI7x/UZjV3s7387V19YpigKQIkSbK3uVOkXmfuI/4fSMJjBH1nfdic5ZCJT3puuadGDiOeKg e+iSJmnXI7iBVmttXTTleVm+GRS5iZOMphXf1wx0CWm27L3j/e0YFXMkXeEsg3RawuAvI201dHd kE7I4KzBPK/2G3Li/fFaAvhpXlXR5BdexN8OdCY8rMR8pdlwRf6KbaaCEbwxO+AhiVTfNXmjjIf wFkDhBJYI6zTnZURODOH/8JG1anjqYSHKB8iTQmYu5VDfGWgcTptMe+Fp0jjRB1gQCjR9C5qqHy jByD3C0CXLNbuWNnG95ZHGcnevKXbaj9q0DBoe63StoVg6IOXHqJeYIaBBuWyk/fCqtc/j X-Received: by 2002:a05:600c:3e0c:b0:499:4e47:eaf2 with SMTP id 5b1f17b1804b1-499aa1a3e87mr54233705e9.6.1787128937141; Wed, 19 Aug 2026 01:42:17 -0700 (PDT) Received: from SurHub.localdomain ([196.188.112.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499ab2a8b34sm48420125e9.8.2026.08.19.01.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 01:42:16 -0700 (PDT) From: Abdifatah Suruur To: linux-fpga@vger.kernel.org Cc: linux-kernel@vger.kernel.org, yilun.xu@intel.com, trix@redhat.com Subject: [PATCH] fpga: dfl: afu: prevent read-only port mappings from becoming writable Date: Wed, 19 Aug 2026 11:42:13 +0300 Message-ID: <20260819084213.1560-1-suruurism@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit afu_mmap() rejects writable mappings of port regions without the WRITE flag, but leaves VM_MAYWRITE set. Userspace can map such a region read-only and then upgrade the mapping to writable with mprotect(), writing to FPGA port control/status registers the host owns. A guest assigned an AFU can use this to reconfigure or reset the port and interfere with other tenants on the same FPGA. Clear VM_MAYWRITE for regions without the WRITE flag, as i915 does for its read-only objects and as fixed in drm/vc4 (CVE-2026-68445) and drm/panthor (CVE-2024-53071) and ptp: vmclock (commit a5edadbae57e2298a56cf7a4e774a027905a331f). Fixes: 1a1527cf5ddac ("fpga: dfl: add FPGA Accelerated Function Unit driver basic framework") Cc: stable@vger.kernel.org Signed-off-by: Abdifatah Suruur --- --- a/drivers/fpga/dfl-afu-main.c +++ b/drivers/fpga/dfl-afu-main.c @@ -836,7 +836,11 @@ if ((vma->vm_flags & VM_WRITE) && !(region.flags & DFL_PORT_REGION_WRITE)) return -EPERM; + /* Prevent read-only port mappings from being upgraded with mprotect() */ + if (!(region.flags & DFL_PORT_REGION_WRITE)) + vm_flags_clear(vma, VM_MAYWRITE); + /* Support debug access to the mapping */ vma->vm_ops = &afu_vma_ops; vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);