From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51EF73D3D02 for ; Wed, 19 Aug 2026 06:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787122407; cv=none; b=OJtPvlbgXVGxy7DA0EN1BoyDKx4+adNTDzf2E8jKZJnvTGM+CM7MUsCEB9+5d0jeXmAjfy3WriiS657bfXkG6yrkm5/mrTJXLijiRRorZKbqVnn8UY7qb+9gdte2YuejFopHD9VP3RBOVchDJ+FAXdi3jZeQSh+CHU7hFFkrx9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787122407; c=relaxed/simple; bh=ViPrjrGLX5Hxdc/Zs9vdFchHc6vI5aQgBpj7167p+6M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Iihi9sVxmK239jcx92eEZtpOPXgp7+3F5bfy+VcR2bPDXjviWeho7FGL49T5IqMQEinoMHyJYV8IfH9DnicceASPce42/RXPblmrqDbsUNEgrFbpqIHXbCoAFIEephmo5i3zckV6oz3tONi6HWz1Od/S8iuP3d1T7xjpmSWshUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SnyG/VAT; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SnyG/VAT" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-495590dde14so7538535e9.0 for ; Tue, 18 Aug 2026 23:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787122404; x=1787727204; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=IpqeN5lIytC9amcBTT7riRYHzG5rbVz5f45Yb8g38Eo=; b=SnyG/VATLdpbRUxd1tq9pshly/Kh66bANPAqGwJFP80lrGxmcQFaSU31fF9P9n51YF LoRdAungqEZMyPrw7s16rFPL6rpTkC9k2DJADeCCci9+v9hAuEzvUu5WncOtGT6lETWA /eveWIbqYCCMXsmnt0TJIgkvE2As7lAIB+UHCtK/wssfClYa0XI6SdmeiGU4H2b+yj33 WdaqrqEOcPhPFokZqH+QhyUEeym2MrTStWJS1foARWL3llh+Ycny88Cg0fPgN5nD8tul kTJjRNC5V/oUTFl8uiMpI33Hi8BN/dl8qPwVsmKnXTvmS8aa7st9GlK7nvC9W/+Zy8un OpMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787122404; x=1787727204; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IpqeN5lIytC9amcBTT7riRYHzG5rbVz5f45Yb8g38Eo=; b=rBipFlhapFvY9HMaOwFFlZ5pp/b1gNj+/bwtjgLwHEZHidCDFxK8StxXj/0q0NBZaH DJxoqAqUa2MkXv7Mc9+VOvTifr+ibCgC0iGOgo18V1soT4WXuXyVd/WbmIj8taHvnClk bThbEFYl+N+fNThybh7o+mG5iCPu3tnR3PHiIMFrEQYGqtmYG+nni19pEY6TaEnSw0ZV F/X/LbFXd69xwC0fs1Lhe2qy1FZdHDS5++3oVxkzzUiaN2k5YMvIYt/ovB4iMVP+Bhmi GDfOAAaPgNhxuWoFQNggTgcWzt2qkDkh6sI41tC/mEzu/glLAFC0ewkEmKpT8VW98aaH cBCg== X-Forwarded-Encrypted: i=1; AHgh+RofMtQiXz4WG1Wg12xCBi2ftiUxI94jiOTD/P9wUIp/px11b/ITSjqzlhhh9jBpo6oqEFyrSe8LUSUSZV8=@vger.kernel.org X-Gm-Message-State: AOJu0YxX6BK/08bpUeQYG0WwW2jn732fZDaokuWB2OV3kBf1dt8AFPRC c3Sv5+OdsvE35DUS/XLG7uHYMGXRafEsulnKByVoIEFN0BLA9yv7Qhd8 X-Gm-Gg: AR+sD134t5QseAm3PhCRIJX1NG8iR5Y3EmSNv47FCp8p6WTEnAkjV40GLX7X6+5aqyH Q72o00KLM9q2cDqbMdNPR3th0engUQKkXNHlpFxF4H1Ksvat7xntF8PYQPZa7WvkW/2Ur17v9Q2 nv1FqvevxuHzuEWNdbtZPk7mWG/3SHa/dNjg1zWnyrdBSeKiwAGP5cbeO54OdFAEJ7kQxYdeBjY zJYYsLJjXAB6T7FUHugYswvx/86ffc1+sP1STpbbTOb92tzyKPC4IJpbF+7MIw1OJyYXkYzBdLC VdyRDi9VJrJNijMVR/E8JRO2Q3Ei0ojUXIldzR/7oMfA/MGcg+gQJ0TLi0YUC/9iqbkxJx4QyZw cD5k8pr4KO+ITRVR/T9D+oICm/9DaFC5WcetPj20JQEsVw969wuNHpwJUQtohHUXKoLoAfSSKC/ EG8XXHSwZPP2SX5coDYSM1tngyQE4rCY4BPcuZ4a2NvfHExK90mbr1TltexcDn7zyRy5/YbSd/F YRm+P15I668JOBbLvveymd7YMpMiXNd55tIt0XulXpy18kiIAEXn6D4wMhF1Cnh2SzWjZqDLqne jq0k9aWFJIpzScyQ8cJkvOiYZjtZdR8aTmHuZ2qPZfnntbjFGDUBCXf8+KOhOsc/37PdSY46AP+ puPiIH6NI4HI1Sr5dp4NKPPmsU3DAU/vzthhuWH4nGih1c9j3DrOf2RfXE5JZ+TXe0ikR1g== X-Received: by 2002:a05:600c:4e55:b0:499:a07d:a482 with SMTP id 5b1f17b1804b1-499aa1a28efmr46091735e9.10.1787122404470; Tue, 18 Aug 2026 23:53:24 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa0d6a84sm35256565e9.10.2026.08.18.23.53.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 23:53:24 -0700 (PDT) Date: Wed, 19 Aug 2026 08:52:55 +0200 From: Joshua Crofts To: Vladislav Leonov Cc: Jonathan Cameron , Heiko Stuebner , Andy Shevchenko , David Lechner , Conor Dooley , Krzysztof Kozlowski , Nuno =?ISO-8859-1?Q?S=E1?= , Rob Herring , Jonas Karlman , Simon Glass , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible Message-ID: <20260819085255.00001e60@gmail.com> In-Reply-To: <20260816113636.33635-1-vlad@zlab.su> References: <20260816113636.33635-1-vlad@zlab.su> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 16 Aug 2026 14:36:36 +0300 Vladislav Leonov wrote: > rockchip,rv1106-saradc was folded into the fallback enum together > with rockchip,rk3576-saradc, falling back to rockchip,rk3588-saradc. > The two IP blocks are not equivalent, though: per the RV1106 TRM v0.3, > chapter 20 (SAR-ADC), RV1106 only has 2 channels at 10-bit resolution, > versus 8 channels at 12-bit on RK3588. Documenting it as falling back > to rk3588-saradc allows device trees that would bind against the wrong > channel table and report an incorrect voltage scale. > > Remove rockchip,rv1106-saradc from the RK3588 fallback enum and give > it its own standalone compatible entry, matching the dedicated match > table entry added by the driver patch. > > Fixes: bdba14f6122c ("dt-bindings: iio: adc: rockchip-saradc: Add RV1106 compatible") > Link: https://lore.kernel.org/all/20260810090826.146758-1-vlad@zlab.su > Signed-off-by: Vladislav Leonov > --- Looking at the link provided, it seems that there should be a Suggested-by tag for Jonathan? Otherwise LGTM Reviewed-by: Joshua Crofts -- Kind regards, Joshua Crofts