From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B43E425866 for ; Wed, 19 Aug 2026 10:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787134744; cv=none; b=q8O0JEkKqQUCCKQTdHdGVDCqzWxrH6lPzFnQ3hvmcIEomH/hcsSCfMeykDAUyuKbb7IFD2zHUTVUnIM2O6TNb1UfDL3+8uibxSfFi68Rl+YILmIPOpL7mzd/PtlkdiuxuEVJFOPwtJiZ5gCm4jjyknxOqzRFG5lkKjiGGWpwDBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787134744; c=relaxed/simple; bh=coj4MMAGE22DbW+ZdR3ylhrlSHaRLYrkyTDy2imbEI0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mJAFQVavkOLgqEyHcHH2Fdvc7vwdd2RIc68PTWsxEH5sG7sdtdCjAhqruO2/GgXRg9bd7+q8cNeS80dy9o59crGC4kkAdkI0gF3m/2d4KVrFgi7e1b1p5t6rjOoPK9nHipl1ikFh+ZPC+iBRn5eUFdExaeCYFKFzOYlZa1EF23U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DnGMH2un; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DnGMH2un" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38e08baf860so984014a91.2 for ; Wed, 19 Aug 2026 03:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787134742; x=1787739542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5JyEyakg047/qVI/dgdygc+uAR+XzDJBCS95evddBW4=; b=DnGMH2un5zlwLMM1sv4/8Smd7VufwBTdq2cKBW4fyCUeiGofagXNit2NVvZpx1FKTD VMGpf1AU1y5irDat68GqLZXL9oBd6n5LbGmK+LPX4rhcX37lu5sdCkvqvzCleP3YYc+Q 6rVJKIMcrIRxaAgDds/EWxZ9zNX/3kUhBOzDvVRy/q4NU2X9Hf9Pj6ukjBMbPLIu1uAW 66wKIC/VWbaFxLe2swtU2OV9CudYvPHhhA29Z5NfyUOJIV1I7JVVog1a9lD+S/N5ijuZ TRodfg6bq5nciJF3Y48V4usP7fXYCvJxor+JFxswcDZqMQKLQe16RpNZkGxEJHsGckvu CMNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787134742; x=1787739542; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5JyEyakg047/qVI/dgdygc+uAR+XzDJBCS95evddBW4=; b=Ivwg+vW7XZBWOM6gEoBiGt13e0o2xWNpMUkH547xIpUVW8On218JPS065V/89adG2a ctUTcCO38nNHszenDLI0OQhZsHG8N6XjALTCL4jXuNhk+eoB+An30G/g2lNDEGI7rcDQ RBY91HW5YbqibyeqUM0LFo+fcUORB/uWYU8mWblYGTd0sh1g4BijagHuKx/reRzmM82T 5m31ivTmBs9AqXP7ktBFSEp97eIu3uct95Fwwy74gMijQL3Cb4dJgXbdRMvlpla4mnHJ 2HvmovQYxnHnX46BW0Y+kEDi6as4LpYcum1WzfxZLKm9UWab/y/NoDQh7YyxGPagsUhs q+Nw== X-Forwarded-Encrypted: i=1; AHgh+RrerYtSPjUtok3bZHYfjTJTN7ge2F3b5XhnsEGzMwX4i8rOzgwB+jHixoof/4UtFuNmTlkXBljsUfWavkk=@vger.kernel.org X-Gm-Message-State: AFuF++m3Vxbgq2yHVZ9Ty8h+gpW4OKs8VMQxbYIHcKXjsIahzRYhIHNt OMTmOZnga2GrF03RF4X9DLxLKFoPnxIDr/PNLSseE8TjlOovLWazwsJb X-Gm-Gg: AR+sD13lR6glHPq5ZCIHaryQN/eDHznh0EX7OMhTNrS1bTrB0VPWeEFIDmXljrYRFMt x0sLAHv2huIQTcb957lRAO96HdAWXYRGZ1FAvHjMwnzgp+ihx2Z49hnwprOYANKuonYHeQ0xZyC YvhFqbEE5CS0IGzzq87sbjgTuD18diNmz0kme65AoG/l/Y2GKHzej/mHG1tioiafR8Yvp6DaNNg HsrjTloFfHPNE28amtAVFGQxBh09lyPMpzZGK6Z08bikUfbRQVAR2hySV2/gE7J4jGkb7WXO2HD cjXzwfcUITGP5fgCcUv7v5DxtNQXb/VfBZvHHeNzfar9k38NbZLS+9QjifwIXxdcGPyeJWpZW2m wcY00OY6dj+SJtiFNhIpgi/t7MNwxT2NefinBhzPuqRs7pM5eo0G7DsSmiAtea0IbCrwe48bZnp CgqjpDLQ4974dIC4QN9N9rTb08Hi+/v/d1Phs+hOgrh+Ty/bkMTecG2nW07sfcsGmluMLylBFEN RLWImQGcT5E/1QuSKCNoTML9s3tuDvdnWqX2I/X+CiwtQb5Y7IurBEvQnECoH9p0nIgs/IF4x45 wT5WIEGsElIKLPs= X-Received: by 2002:a17:90b:2b4f:b0:38e:67e1:15b with SMTP id 98e67ed59e1d1-39580f0d585mr7158158a91.6.1787134741640; Wed, 19 Aug 2026 03:19:01 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957fb14bbfsm2146392a91.1.2026.08.19.03.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 03:19:01 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/4] ASoC: mediatek: mt8183: Fix wrong clock cleanup on clk_set_parent() failure Date: Wed, 19 Aug 2026 17:18:46 +0700 Message-ID: <20260819101849.68010-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc In mt8183_afe_enable_clock(), when clk_set_parent() fails, the current error path incorrectly cleans up the previously enabled clock instead of the clock used by clk_set_parent(). Fix the error path to clean up the correct clock when clk_set_parent() fails. Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8183/mt8183-afe-clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c index cc4f8f4d3dab..6ab0734ad136 100644 --- a/sound/soc/mediatek/mt8183/mt8183-afe-clk.c +++ b/sound/soc/mediatek/mt8183/mt8183-afe-clk.c @@ -137,7 +137,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIO], aud_clks[CLK_CLK26M], ret); - goto CLK_MUX_AUDIO_ERR; + goto CLK_MUX_AUDIO_INTBUS_ERR; } ret = clk_prepare_enable(afe_priv->clk[CLK_MUX_AUDIOINTBUS]); @@ -153,7 +153,7 @@ int mt8183_afe_enable_clock(struct mtk_base_afe *afe) dev_err(afe->dev, "%s(), clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_MUX_AUDIOINTBUS], aud_clks[CLK_TOP_SYSPLL_D2_D4], ret); - goto CLK_MUX_AUDIO_INTBUS_ERR; + goto CLK_AFE_ERR; } ret = clk_prepare_enable(afe_priv->clk[CLK_AFE]); -- 2.43.0