From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D442937CD45 for ; Wed, 19 Aug 2026 09:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787131991; cv=none; b=tsQsqqriZ1QSKGyX2cqJM1QosNWWz5itjdiDKUzR/AwykYFS0X77hZMzLNOdPZQfhgXHNCK9fWWxOw3rqdbg/780sK4xIhQsTTpaUrdu6TN7gK8v9DJs0hqtNWsKdOFmvliwyhFeYPM0UVAaDnGa0VGjbkvbLz9l1vH1rHbMEW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787131991; c=relaxed/simple; bh=Z8xVDZLjNmPh0/pryCTJOf3tHpufI7OLR/tEu2ETXkM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q8s0/X4v1tywQBc8FwM7Ja061xitoH4IKGYmJ4Di+cmIjND23XVJwbNH5KNdSozgM2/Q14pecQxffU6+hXBfyvcMROOMgFKOUaF3SpC0sMKR88aaEZCPl0NP2kmSe/35YKT8hvefhb2jA8bhYCv8IOlfuWYFe1nqrQ7Vii/GmiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=IiF/qXlu; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="IiF/qXlu" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 0777E4E412D0; Wed, 19 Aug 2026 09:33:07 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B53A75FF42; Wed, 19 Aug 2026 09:33:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0EC1B11C715B7; Wed, 19 Aug 2026 11:32:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1787131981; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=/J+2MYz8g8O18uMEI9fVj2SUHU+9gRW2v5KuunkJoXQ=; b=IiF/qXluNvYqTqO8j7kY3HeKbKYfEcgraO0wBT2XY00EB6UHbVHebizB1sXCnLEzGPhD5L WLZImu7N/6mAK6O5xAhRiMZH9MjxZwr1Etlb4s9GrZeRhUAlDC8aDAqEW2zrwaJXfblhrk vwPSV04hZ+jopaZhSXrb1kTjOGdu51Q4BUtGX+3ZVcsSFce82m1FWK5kRZCNrOb3xVT9MZ vZWbvfftEGoQB9y0mrGfXb7zDSAsIy+M/qcV7E9Zwg/78RN+MZ2yrXaPqpzSxe4bsFGPUU 43RK12wviPhhm0nmOFyHy8kuqNs0OQo97DF90d0ORYQGkD6DFsb/nCp8e2Wchw== Date: Wed, 19 Aug 2026 11:32:53 +0200 From: Herve Codina To: Esben Haabendal Cc: Luca Ceresoli , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Linus Walleij , Frieder Schrempf , Marek Vasut , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v4 1/3] drm/bridge: ti-sn65dsi83: Fix error handling in sn65dsi83_reset_work() Message-ID: <20260819113253.5d602b2d@bootlin.com> In-Reply-To: <20260810-ti-sn65dsi83-fixes-v4-1-ae9c95c8d162@geanix.com> References: <20260810-ti-sn65dsi83-fixes-v4-0-ae9c95c8d162@geanix.com> <20260810-ti-sn65dsi83-fixes-v4-1-ae9c95c8d162@geanix.com> Organization: Bootlin X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Esben, On Mon, 10 Aug 2026 09:19:40 +0200 Esben Haabendal wrote: > The error handling of sn65dsi83_reset_pipe() failure in > sn65dsi83_reset_work() has been a bit strange all the time, missing both > enable_irq() and drm_bridge_exit() in case of failure. But since > sn65dsi83_reset_pipe() have never been failing (always returning 0), it has > not caused any problems. > > As we are going to change sn65dsi83_reset_pipe() to return error values in > case of failure, we need to fix this. > > Fixes: ad5c6ecef27e ("drm: bridge: ti-sn65dsi83: Add error recovery mechanism") > Cc: stable@vger.kernel.org > Signed-off-by: Esben Haabendal > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > index 42b451432bbb..0ccfff401b2a 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > @@ -417,10 +417,9 @@ static void sn65dsi83_reset_work(struct work_struct *ws) > > /* Reset the pipe */ > ret = sn65dsi83_reset_pipe(ctx); > - if (ret) { > + if (ret) > dev_err(ctx->dev, "reset pipe failed %pe\n", ERR_PTR(ret)); > - return; > - } > + > if (ctx->irq) > enable_irq(ctx->irq); > > In this v4, enable_irq() is called even if we cannot reset the pipe. I know that sn65dsi83_reset_pipe() always returns 0 (and this will be change) but we have to take care here. If the pipe cannot be reset, the sn65dsi83 component could be in a state where it can force the interrupt line. This was the reason the irq is disabled https://elixir.bootlin.com/linux/v7.2/source/drivers/gpu/drm/bridge/ti-sn65dsi83.c#L455 Best regards, Hervé