From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7A03C3F4F for ; Wed, 19 Aug 2026 11:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787139711; cv=none; b=H0nzaF25TXAZrosbwJ2gqQ2Dw52hBUYxm1WxriL1LqzZzQZ1CPK4nUa9mKRrqSNRIxr+rpgL6avoL/pMKgexZzaGE4b0TeKkrem9rG3OA8Ljr3QtDBwkAVxlmFZJaxnsjfe6n94Lv3I3G3/G89EoUSc9e4AInm9+AJ6vqighDtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787139711; c=relaxed/simple; bh=FNu8r7MvjrskHjFJ/tvmVL2DfoUJxitxTiZYFXu8ttA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LJ0IB2Uv1saqDIX2j5ygC5WfsB0so17Ar85N9L7b4nWdbFRFW8gkRBXIyQdSsiNOt3ayo8/0ZzUKvjUbUAWDEJ1XhlHhrhpuTijgRah2e0TPcrsOW25eREO5N1OPuat9KM6mHzP2Gt4fFyszlGbkxwUN4fPq+7Sa7b11pg7qmM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QZZCsTla; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QZZCsTla" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49978908b35so6424235e9.0 for ; Wed, 19 Aug 2026 04:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787139708; x=1787744508; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cYVMpgG+N2JrVPtpFPop3fFzb0WwUz5sl8ApG6xBBo0=; b=QZZCsTladfozzdejczU98TaEt/5Sfxsr4JPPZaWLmq9uwkafdlmFDl4U0KfmJhAhhB h2EmdYuFkJ6yADHjvJ9gnfUn8+CiTTmQ2+vJailAOnuNnOjiBOGuaNfgcPBh56i+i1IM kWSyige512Z3ixp2hTrvHYCc7+yjbG41GdrtQsyyqkhg+qZ7e6ye+J1tvK1klclRkNYy a24Mr3lZsN0TNSsjy49AABpirKj0UbabBuQ0xcaAVNZUFki1VHtV/Pe9xkveeNhd0OdR iZWhPuvlWsGdmx05d8IFGdLoWAAlzhM7dCogkB2PewF7Xv5+iUN4r6hJvY3N4B7+FHzZ qOkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787139708; x=1787744508; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cYVMpgG+N2JrVPtpFPop3fFzb0WwUz5sl8ApG6xBBo0=; b=fmhCAfwzNboxshzYEASEGQtFOf5yzV6fXRQEbOn4e1TU6ja4kkt+nbW0zYNvHq1msD aqvZ5RIuY9ne6KsIcxqxUUmQaSx2Gys8JHl60GgLZ69uY2lFLTVOfqR4H7rUpPey/xz7 RiYE7kbQy5Qzb7wBnMrw1hfZm6be04lzh5izTbHWO7alWIBE544RS5EqYqD7vt9oaSdE tJvauvyN7J2iwd5o+PgM7jCYuFYJhCw4guTCCuzNiaAB/X473qEfds95pkYErhTVDSNc F8GRYZwsFNMUDNZ28F4BRnMhzi4YGBhanMQrN25HC4u+M9Ru7u+NgkpYyM+6ueQdi/iv 2GxA== X-Forwarded-Encrypted: i=1; AHgh+Rpo0KiVzjJ3GsCxAyeq/btEG3ud0dh2byDdRrSX1XFPqj7Vi+oQWKosiYcD731IEDrkiUQ3Cs02mVIWENE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7fYjZD7K9cvu+qyo9XhZsGba2lcRZb8o1GcRtCBkBOHZImiBA OeAjPQyQJM4ivqDxCyLByrH3bwqW/ch3KwdREP1YH4hm1ph4TILrNaCC X-Gm-Gg: AR+sD10aIUfX3ucUnQQ5sfA5IqH8mAROK6aqBlDEkTBtb4TxqqA+0jTJvnlO0OYou2D JZhkGvSJ/KBwKfvMop1tQ2c92kNupOGCS6Cj+Im5kY3qhapcf50Fy29hfCe3v4kYmq3akOPWPKG bRtL/2U2qmGyYvUaicykoWS/1T0aOU8ValJ1kPu6USSrA2x9krZ1hI7OHp+CD3A31FfsNF9k9aK c6vOcv0cxrgHNzKPeeZS6J+piPOXxEYrFPiW4PPIhT0+zUMWpv5hkvkOKFkA4fBfOk3yZ+lhcZW gLuh7yG8Bcsuiv4q4B1CHKSIaOvVUV/9FX5d+Px+H0SVzqi3CdJ/I//5CdApmffCdokJZmgAyzw FXwvaxx1pozXjzRNvn/ylIVMXJOk0Ss4VOuWDaibAsbHQZLV1gCxY6SsxRD5HomrONx++5CD8DR 74hcTIHq6ZMj70bpyvE2IZBwBXqv2akdvjJMhgtwfrm2GheiImt6qT0nt8URckH6gOlhJKyxXfP hzNxwi/8Z0oww== X-Received: by 2002:a05:600c:524a:b0:499:737c:8a8b with SMTP id 5b1f17b1804b1-499aa1ce8f4mr63599395e9.12.1787139708045; Wed, 19 Aug 2026 04:41:48 -0700 (PDT) Received: from localhost.localdomain ([165.51.108.173]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499ab2a8b34sm61183125e9.8.2026.08.19.04.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 04:41:47 -0700 (PDT) From: Salah Triki To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Salah Triki Subject: [PATCH] iio: accel: sca3000: fix frequency divider condition check Date: Wed, 19 Aug 2026 12:41:01 +0100 Message-ID: <20260819114101.28232-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When setting the sampling frequency, the check for `base_freq / 2` is followed by an independent `if` statement for `base_freq / 4`. If `val` equals `base_freq / 2`, the second check fails and falls through to the `else if (val != base_freq)` branch, returning `-EINVAL` erroneously. Fix this by chaining the checks with `else if`. Signed-off-by: Salah Triki --- drivers/iio/accel/sca3000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index 573831199bba..cced5cd82b02 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -638,7 +638,7 @@ static int sca3000_write_raw_samp_freq(struct sca3000_state *st, int val) if (val == base_freq / 2) ctrlval |= SCA3000_REG_OUT_CTRL_BUF_DIV_2; - if (val == base_freq / 4) + else if (val == base_freq / 4) ctrlval |= SCA3000_REG_OUT_CTRL_BUF_DIV_4; else if (val != base_freq) return -EINVAL; -- 2.43.0