From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D96944BC92 for ; Wed, 19 Aug 2026 11:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787140323; cv=none; b=chd0Nz0N0cIO3wsi2kd0a8X/hoXoI00sSIdoE23zM0aPZtXQuqx2u67CdUcmVZ+oGG4rNm3zR8WHgUQ3fi5dreBMYdrCp+NEuFWYmcbHdYkLXN0xH0ND1J7Ll1PdC3LyGHN8W+GPNcX2BZwSPWIcpQqok4fkI7QiTFdaxKzCmRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787140323; c=relaxed/simple; bh=342E++jBLjft9puIOlZ7pk5T2b/w/HbFwx0G1Sda1j4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iNepencDzSU1dwq0nEdhs/Rs6j2eoDOzry39c9dylXhiVZcQi01H9ExJ2F7F2eXL1tAwi8pbA8za2xBmW8ZJeYlty50XTZGLVLzU7hF2zAIuZL378D+io/nZr3pRo3phCLS+Jj31YpaW3fLh9GU5kG2jTFJCeZxEQcLPVTPicHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K5OCPpwj; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K5OCPpwj" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso9365325e9.3 for ; Wed, 19 Aug 2026 04:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787140320; x=1787745120; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pBwot5MAFOKV94xjUQ6DV8U7OVQ8PP20J0qQhKJ2qDk=; b=K5OCPpwjjYYEyytJJBbfU5j+xy2P55/MYuyMQQIiJOcUJBAaPPniBZVnlUf4bDrVyN 0WPwqBxIJFpe8KN5Qo+4LGb6NgWsYKTwuvwxy4F1ExBlx6VY+ccFBINrQHqBjLo4xBxR H0FcKYkOI6VkuDdNn14Ma6wk2wD7IaIZg+HH3Pc2bPTA28SZwr20LeMjVkvq4Pr+ak3u GtH8TtE4FMYUgBzKYKBXArjbQr/0iRGETpXeRJaCx2livyJkzqfvQwICAcGjhwo+a24x AJWlXv466hXVGmwFQfEaCOmdVjPLeAwoBUyc2DRJA5Ki3PB0/8mrYoDfh2ftdgM5/lUI 3O4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787140320; x=1787745120; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pBwot5MAFOKV94xjUQ6DV8U7OVQ8PP20J0qQhKJ2qDk=; b=D8QgGYjmdg4YU0mJ/bn4TbQVPpKXDF2mLFEArpyMatAO2sfsBC/jPTIYhgsJ9KGaEl TY2ftqfRL5W+KeNkY6aFKGFkfE3X8bAUl0f2pMrmA3k8ln9xL+D5dCY/hgKXPejkbNCL ALlKOtVS7F/oWtZ85vyvwrNR2G+3d6tghfh5uEeNLgMeeHzJ+Xz9aY5iwk6NvOhp8Tyz HPD+GpbyxfKCnedDzFoL79MKkupwOzG4Vm19utVmdD7SX/YMnMh1dUtrB9MzsY9Ksla1 CCkDvR14jVxYl2V6YxKICIb5jjyABpvBXZgv7bsIhserw8j8NcjfWDrQnN55Cbm920le WtFA== X-Forwarded-Encrypted: i=1; AHgh+RrKs/4aKrUTFa1MfdrLZI146y97Tu0G3mWgJUizvpxNADc6UYIvoS6ddo+A5V2TCDLR8xJYQ6qLZqVRsVo=@vger.kernel.org X-Gm-Message-State: AOJu0YyVE5xD84eI83sP59W5eMj4Z98Yeg5pqulxYLiiw8Pr05/KYZ31 9tnBrf/4cmLxGu1OjyCGrt6dertqWPJOKYy4j8tyReOSZVMEDwi9P0ta X-Gm-Gg: AR+sD10+DQUwlJcI9DF9+R9AiziyI7tnp1f5V/jww1uFcS+W1gsB99i49ghmFLSQO4i WVCnERk0AP6FAQfLYARhNKyrRbA3v43FsOXxpHQSFxZUT2MAcGc8xKEB7IkP2HpxohmBjVMknNF /ucYzNevAvYigsXYqSXlv4tfARPpuIJ7j0jYtYVdIh/FVsMUcKQ1LVe1VFzDAV8SgAglsost7lA DZuTTdXmYclcklpLL4MnV/qK50akZEMGngkIcXkyXsIpaGHS00c5PavDSy1OemLyRub6YoXnsA7 K8eIPKuL1NTep3O/fxpHv6fz8vIKSgI3fFkr8Y7j63JEb5ojDa33Uiptcr6p6e6Gm/E5g4cDgvi BPQY72vRYm03pMJsP0+Om1gSIcjLFt9GDh82rYbEyHjvHhBhcLw6vfnSpap6lHFekLIsIkbUiZj X2p1mbt0bZ7euwKpGVHL0BXOfVKFSGcz1NE+YnIcloClxKhUfl3gSLQm1n2qj/Y8cIVywaf8cSG pzSMqe//BoPMF2c8byqWzjeKyKJGy4Y8CccLDiDhdywOpjefY1vglqaSjWCurxLOa7jfdcLbfPP 2mhJN6Z8XhOlTxRCa7qlMpOidkKAGPbeR9ameUvReKT85McABWf94foVv86perNjxEbzWPXSM9I VnbzDC868gw+XR64gx+7e64AkqEFVPnEKAcY8/GEJvKinLXyByY/2Kk0tSl8UhaLIKKNrk+4BFe MuI1JQ X-Received: by 2002:a05:600c:c170:b0:499:86ce:465e with SMTP id 5b1f17b1804b1-499aa15d8dcmr79633395e9.4.1787140319342; Wed, 19 Aug 2026 04:51:59 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14d9783sm5101103f8f.37.2026.08.19.04.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 04:51:58 -0700 (PDT) Date: Wed, 19 Aug 2026 13:51:56 +0200 From: Joshua Crofts To: Salah Triki Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: accel: sca3000: fix frequency divider condition check Message-ID: <20260819135156.00002b2c@gmail.com> In-Reply-To: <20260819114101.28232-1-salah.triki@gmail.com> References: <20260819114101.28232-1-salah.triki@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 19 Aug 2026 12:41:01 +0100 Salah Triki wrote: > When setting the sampling frequency, the check for `base_freq / 2` is > followed by an independent `if` statement for `base_freq / 4`. If `val` > equals `base_freq / 2`, the second check fails and falls through to the > `else if (val != base_freq)` branch, returning `-EINVAL` erroneously. > > Fix this by chaining the checks with `else if`. > > Signed-off-by: Salah Triki > --- Good catch, this issue is 10 years old! However, you're missing a fixes tag, I think b4 will pick it up if I leave it here since I already ran git blame. Fixes: e0f3fc9b47e6 ("iio: accel: sca3000_core: implemented IIO_CHAN_INFO_SAMP_FREQ") + cc stable Reviewed-by: Joshua Crofts -- Kind regards, Joshua Crofts