From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736E93D25CC for ; Wed, 19 Aug 2026 18:48:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787165288; cv=none; b=uQBZoXGilXP4zOMTXk/+0ykYk9/DCIdPK8tVpBr1x8Y8il6p6to0nBQgxTXN039twrRJUz1FiiDSMW+UNHC1m9XXds5+l3cOodu6W3rd01R/qjef3mxuPnyc6nv4EcAJYbnyecfpFlXN6ISmO3GeUYt3EKpPi79U4tD/0L58ECo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787165288; c=relaxed/simple; bh=c8aPY25za8j+RU3zvlgJ6EeVwOXii3Jb778xBQ5WaUM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PRfILytDde2QzIoxVuuwfvb7nmKZFs9ZjQ4ggvVUly7LXVixFVTMIlYzlX5p2T3TSdKI9APCxRAsv1aVBUnv0DKjNCrqCVvCwRgekDGSmt5bcyG2FhURFkrz54b566tDEB5AsGGh19Z8s7+066WoBqVO7MLapHE1h3LjjHtok0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZlSpjzUS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZlSpjzUS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC4D81F000E9; Wed, 19 Aug 2026 18:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787165286; bh=9rSLaXgeddzz48/rqF4OH1ISXnelxn4t6j9K8o/CmfA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZlSpjzUSKZCoiBnDnh7nkxKVprjHp7Kc4+Yrvm1gw7n7reIEKBPTI9CMYjdmB4P+x VPKl9e6YnE7pSYN98JhQVueH+MDJw7BPq9iMUSPFlhDsMw3lEO5qDItdFyLLeAPexA trODMPrN0WOuTaSUvPA7OcNYNtksFKs7Ygcw3DKMBF+eWnZqGRQeox576orH+TCHhQ mEmZs02Bvrim+bszXmd0JiN/G/yFicm58+R12w76q0HD1s+IGju1qaEkEiRt2FmipU e+C2fyMmc/SsZA8xQ8Og7cVeIvErR/7p0nj+YxUt1SJ8/ggRFr0ue9Bt/m8vayEyBy Zwv+O+ItsrwmQ== Date: Wed, 19 Aug 2026 11:48:03 -0700 From: Nathan Chancellor To: Thomas Gleixner Cc: Linus Torvalds , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [GIT pull] timers/cleanups for v7.3-rc1 Message-ID: <20260819184803.GA3333711@ax162> References: <178696575118.1270771.17154447195623102039.tglx@fw13> <178696575847.1270771.17330908414715876847.tglx@fw13> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178696575847.1270771.17330908414715876847.tglx@fw13> Hi Thomas, On Mon, Aug 17, 2026 at 01:23:52PM +0200, Thomas Gleixner wrote: > calibrate: Rework delay timer calibration ... > diff --git a/arch/arm/include/asm/timex.h b/arch/arm/include/asm/timex.h > index 6d1337c169cd..94e40c19cfc5 100644 > --- a/arch/arm/include/asm/timex.h > +++ b/arch/arm/include/asm/timex.h > @@ -10,7 +10,10 @@ > #define _ASMARM_TIMEX_H > > typedef unsigned long cycles_t; > -#define get_cycles() ({ cycles_t c; read_current_timer(&c) ? 0 : c; }) > +// Temporary workaround until timex.h is cleaned up > +bool delay_read_timer(unsigned long *t); > + > +#define get_cycles() ({ cycles_t c; delay_read_timer(&c) ? 0 : c; }) > #define random_get_entropy() (((unsigned long)get_cycles()) ?: random_get_entropy_fallback()) > > #endif > diff --git a/arch/arm/lib/delay.c b/arch/arm/lib/delay.c > index b7fe84f68bf1..7e9304012a68 100644 > --- a/arch/arm/lib/delay.c > +++ b/arch/arm/lib/delay.c > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > > /* > * Default to the loop-based delay implementation. > @@ -27,15 +26,14 @@ static const struct delay_timer *delay_timer; > static bool delay_calibrated; > static u64 delay_res; > > -int read_current_timer(unsigned long *timer_val) > +bool delay_read_timer(unsigned long *timer_val) > { > if (!delay_timer) > - return -ENXIO; > - > + return false; > *timer_val = delay_timer->read_current_timer(); > - return 0; > + return true; > } > -EXPORT_SYMBOL_GPL(read_current_timer); > +EXPORT_SYMBOL_GPL(delay_read_timer); > > static inline u64 cyc_to_ns(u64 cyc, u32 mult, u32 shift) > { I bisected a hang that I see after getting to userspace when virtually testing some ARM configurations to commit dfc256dac54c ("calibrate: Rework delay timer calibration"). It looks like the branches in get_cycles() were not updated for the changed meaning of the return of delay_read_timer()? This appears to resolve it for me but I am not sure if I am missing something. diff --git a/arch/arm/include/asm/timex.h b/arch/arm/include/asm/timex.h index 94e40c19cfc5..4d31eab9dba2 100644 --- a/arch/arm/include/asm/timex.h +++ b/arch/arm/include/asm/timex.h @@ -13,7 +13,7 @@ typedef unsigned long cycles_t; // Temporary workaround until timex.h is cleaned up bool delay_read_timer(unsigned long *t); -#define get_cycles() ({ cycles_t c; delay_read_timer(&c) ? 0 : c; }) +#define get_cycles() ({ cycles_t c; delay_read_timer(&c) ? c : 0; }) #define random_get_entropy() (((unsigned long)get_cycles()) ?: random_get_entropy_fallback()) #endif -- # bad: [f4cdf7ca9a1fdcca413157df19753f388a5a224e] Merge tag 'media/v7.3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media # good: [8d3ae59288f1e7d58d76558a6ee96d533bc5019f] Linux 7.2 git bisect start 'f4cdf7ca9a1fdcca413157df19753f388a5a224e' 'v7.2' # bad: [cbe8aadf1551f3f4a853f24b3b96d9f0eea49c53] Merge tag 'soc-dt-7.3' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc git bisect bad cbe8aadf1551f3f4a853f24b3b96d9f0eea49c53 # good: [762fffa407d8d24288513538cf5d17c2c5425258] Merge tag 'irq-core-2026-08-17' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip git bisect good 762fffa407d8d24288513538cf5d17c2c5425258 # good: [0b02b8f941911895775b56c428e01b117ce9d2f3] Merge tag 'spacemit-dt-for-7.3-1' of https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux into soc/dt git bisect good 0b02b8f941911895775b56c428e01b117ce9d2f3 # good: [f809cedd3f614e4596aae23756ed44085fee1691] Merge tag 'qcom-arm32-for-7.3' of https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux into soc/dt git bisect good f809cedd3f614e4596aae23756ed44085fee1691 # bad: [3b4128b9f374b4219eb716f4ad8a307bc7eb3d84] Merge tag 'timers-core-2026-08-17' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip git bisect bad 3b4128b9f374b4219eb716f4ad8a307bc7eb3d84 # bad: [030c9f813b8e48d2b066983c94cf6294968f9496] Merge tag 'timers-cleanups-2026-08-17' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip git bisect bad 030c9f813b8e48d2b066983c94cf6294968f9496 # good: [8b5d31123f41957fe265deeb03ee87fe62f155a8] Merge tag 'irq-drivers-2026-08-17' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip git bisect good 8b5d31123f41957fe265deeb03ee87fe62f155a8 # good: [6c4a1b972643d72bd26f674677df8b5a6a3fe94f] selftests/futex: Provide thread creation and synchronization helpers git bisect good 6c4a1b972643d72bd26f674677df8b5a6a3fe94f # good: [66344732b058e75f7ef25dcd0fbb483f9c000633] smp: Remove preempt_disable() from smp_call_function() git bisect good 66344732b058e75f7ef25dcd0fbb483f9c000633 # good: [0dd1a54f44348d9cf6bae57a2b5cb0b53826a2c7] Merge tag 'smp-core-2026-08-17' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip git bisect good 0dd1a54f44348d9cf6bae57a2b5cb0b53826a2c7 # good: [3ed403bbc967a3138b8e37566510e9b062751372] treewide: Remove CLOCK_TICK_RATE git bisect good 3ed403bbc967a3138b8e37566510e9b062751372 # bad: [dfc256dac54c8b692110bf905c64cb130e15963d] calibrate: Rework delay timer calibration git bisect bad dfc256dac54c8b692110bf905c64cb130e15963d # first 'bad' commit: [dfc256dac54c8b692110bf905c64cb130e15963d] calibrate: Rework delay timer calibration -- Cheers, Nathan