From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AB9236829D for ; Wed, 19 Aug 2026 20:37:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787171866; cv=none; b=bCsEIRQJ3fuzqNKFCYXG3vksuoadtpsL/QO8Bge4L93rdGGXt/vt9xt8xhVCQ0HA0EjnNMM0QsaZpM9+xpq0GeuK1RLfgVDi3/D/th9cd/U50WFZ//Qkfls+ujhAI1L5OBo9fvfeebg2OUZi47MX602hK44uNeryALgvMzWEI6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787171866; c=relaxed/simple; bh=uToOyf/ES533DOfgWtk4VhwEH90KHBccxnpEcS/Chrw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Uf8Z6blUj4LAObg/zjXSL+JmAjoRmAe+f4WzT7RMCOim/ZnuE3wWV1/R49KmnwHfaRlYm/RsJuvY8ENNoa36gMoVPcTQapuXP9Ro+Ahjxkw72ezKCgqMcgqyUGBw+P7e/Fm5XUwBjS2+Wz6i0V2fnTNita60qIzTIyrsVFw3EIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MnP1s7/J; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MnP1s7/J" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6a156627e22so547118a12.1 for ; Wed, 19 Aug 2026 13:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787171863; x=1787776663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=PcyBHwH+6uHNvA8WjjMW8g7Vm+W/8j/2VjtnxxOdiR0=; b=MnP1s7/JGbTgJEU3LCbQoK6HgT3D36lD9SwICvMUIekBE8W4R6chI6oijmIFwBor0e jBwEy0y65VvujjlGkHos6BNdy8fco7lfzFybYZSqdNDBDcJrx6kuTa6xffQVt5TsC2Ac l3N7E9Q6AdlCJqLujgbPC7EXC5lHGfRuULuVeAkoB9Qdo5ixkho0+pi2SQEDbEXHEMGb iZVkyUdfsBRVMuckaUZs7+xJMHeoDsNDGywHayaqGDv8eIQi41nQoxOOHaZHcSejElLo gScc6SWUymwj3bsfJeCfCEUoOHHe4Ez/MXzRwM4jNGuUOSw5DBeRXkVmYM0xkkxDEJPR jaHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787171863; x=1787776663; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PcyBHwH+6uHNvA8WjjMW8g7Vm+W/8j/2VjtnxxOdiR0=; b=Jbf/jOg+j4bO3ZG6T4s+qcxR7WPT5tsNNiD8aTlZuBvAmgIX3JDzN6aaR/D/5kAGc4 IgsXBRk/SbCWEiSOdO/xab75n78eNwx4F1BfT6VFJt6pup5BWa02okXIZz6TN8hPDsSm iOxvWE6ebUMD1BzTIZu7749xAK90VNI/EwvOX7donG7qkrerdo2wJDIM4Yhz+ReQgTwj nbIaHWImseeHSsGOFJx6z5kBGt6JQ5bF2bsSiSk/orV6ljENCor1TTh9kF7yDbXKKsta YlhF+1QRjrnlEgeBgXM7bu736o7/SGyZI4cJSyfeAob9FD3louHqTHg/j49h02qj0Ul4 6Yww== X-Forwarded-Encrypted: i=1; AHgh+RrdSZkgm1uPAioSc53sm1INzju7m96FR6ms+xc6Kk3MA6/zuX8x2WPiA1I7qL+KGr4iLnWrcktb5Zmqe+I=@vger.kernel.org X-Gm-Message-State: AFuF++mYDM9njcYfXf9YU6fTO/E5eeTiv9wo4pim42sCcf2YY5n1QrwK sU81jUhEGmS5KOtd2GtUPKrSAekVZF6syPohVZL81LKMWwdMxzO3MnjV X-Gm-Gg: AR+sD11X2LY0iteh3G+BbEShVekZd890SMJWFZQs2/cQDqQvfMyL/Glz6e6Igc8lB7S 0qqwP98QZsNYFsFzvwo99Fq92FQt22kNMjy1qFMIjpGQgQT+Yky1GVkQ7iRzUVnCCn+9pDwJyl6 QdPt6B+c8y/1Moodu88r+Enk3Psv4yPhF0ZhhNqUli4yRQqjExJKy9fT8G7r7sG8Qs2CNdTA5hS JrarlWTbeFRrQYGa8tjdwDmEuQC+HRZpJCuNZL8uT1maVBCpQ1AU+A6EqnvhohkJZJLWWslyScY Y/t5kCsOdmEmBYQS32FoTg6U9kHKIcfNMuehmQ4ky3XsFkxFdFKCBtktRBVnKskqvuQtYaMv95A A0cMV9cBziR5XgSlLS0gLoWX8Q6KtmTxZVGCpqmvwOthCQM0fwnRUREXCh8NKZIgEkaGL1hmJ48 mUWDFp6DhvojzxXcyQ88Ld9VxHTn/vELqLLk8CYnUZxIczTZRGSlVcEFrFtRGXEKhaFY5sxfOdd Ms= X-Received: by 2002:a05:6402:8c4:b0:695:4916:b97c with SMTP id 4fb4d7f45d1cf-6a41133589dmr840635a12.8.1787171863213; Wed, 19 Aug 2026 13:37:43 -0700 (PDT) Received: from localhost.localdomain ([196.235.194.47]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3ff158e82sm1408070a12.16.2026.08.19.13.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 13:37:42 -0700 (PDT) From: Salah Triki To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Salah Triki Subject: [PATCH] iio: proximity: vcnl3020: fix ISR bitmask check in IRQ handler Date: Wed, 19 Aug 2026 21:37:33 +0100 Message-ID: <20260819203733.12730-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In vcnl3020_handle_irq_thread(), the status register (VCNL_ISR) was incorrectly checked against VCNL_ICR_THRES_EN (BIT(1)), which is a bit mask intended for the Interrupt Control Register (VCNL_PS_ICR). Because BIT(1) in the ISR register corresponds only to VCNL_INT_TH_LOW, any high-threshold interrupt (VCNL_INT_TH_HI, BIT(0)) occurring on its own resulted in the handler returning IRQ_NONE and ignoring the event. Fix this by checking the ISR value against both valid status bits: VCNL_INT_TH_HI and VCNL_INT_TH_LOW. Fixes: 3363fbbe19e5 ("iio: proximity: vcnl3020: add periodic mode") Signed-off-by: Salah Triki --- drivers/iio/proximity/vcnl3020.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/proximity/vcnl3020.c b/drivers/iio/proximity/vcnl3020.c index 7f417372566a..d4ad06f8f366 100644 --- a/drivers/iio/proximity/vcnl3020.c +++ b/drivers/iio/proximity/vcnl3020.c @@ -584,7 +584,7 @@ static irqreturn_t vcnl3020_handle_irq_thread(int irq, void *p) return IRQ_HANDLED; } - if (!(isr & VCNL_ICR_THRES_EN)) + if (!(isr & (VCNL_INT_TH_HI | VCNL_INT_TH_LOW))) return IRQ_NONE; iio_push_event(indio_dev, -- 2.43.0