From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75C6A3546D7 for ; Thu, 20 Aug 2026 14:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787236286; cv=none; b=W+Km+hNKpmi2M4GNXmAxR9yyLPjMPfxc4yrbaRvbLI15Hx6aj86YFmuOkPg/0sma4EDUnMqmn0fI2pJM2LRmWLQhoxzCjL11aTuv+mT2OsudcCHn7nAdLxjdmtOFHEuAhYnD+cjGBC+gE4Cc2PEdwF889ScAynVBiHOWHA3oQK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787236286; c=relaxed/simple; bh=BhkOYK28pMRgnAFg3axElJ/0jV+SlRNGNmaeKhCabOk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oLV9rI+gu30qjKQk6PaaXzJQSbd/ZRMgKpecT+5Dn1yZ2krdPS99EqYbBUH22YP1gHrV1XnVIJ7nt6/nbt2AOkoMWcovNt4+SYywKSThanKua6nkVgAAOYIwNSaoEWhaBuuQ7w6ZYLeTuvdHG+oPa1jaIMmtJN7xUvNHKzlosfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k+HO7BtV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J46gNBau; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k+HO7BtV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J46gNBau" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67KE7WHe3559836 for ; Thu, 20 Aug 2026 14:31:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= w/t5DVoi7TH5Cdgh1wqQM1FGHTFp6QNHPSNcYTK660k=; b=k+HO7BtVyOTPCX5k vngtbsUGCspDYm1c3h3K++oGDzn3zab9VMva/c//EuPvz4e4G1/qDWH3Q1JdWpud 1tqhJ+72fMQqfRCIAoeptvXHpJ7HxqnJjaxIjiRK8Y1qoooPWAJXdiSLmuMEXndh t1cNF1vBekOT3e9UQAB7pmz2Jsl+s6zN3ny7+2pFaG3vuqZM92+9nPuMae9Airx0 oBiALQPwmNVMeM8PTwzHb7/JhuELcE0ZJoZGG3A0xsIGsA/I9qDrTeerhZs/pm1i EiVC7bDEiZFzLWIWlZIS7iDyskfKATj3HTSXfcb1fBbcZllpowVDiCuAQVu0LSB2 aq6arA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5xuk18bf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 14:31:20 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-936cadb0e8bso198195085a.0 for ; Thu, 20 Aug 2026 07:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787236280; x=1787841080; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=w/t5DVoi7TH5Cdgh1wqQM1FGHTFp6QNHPSNcYTK660k=; b=J46gNBauphgcSZnkmrBkuCBsnH+B6uLyTYIjKmmtDqbWGZa1SKsbzqvt9ZkOQ0tzWz 9pwfIIVghNs3NEINuqAPGfUGEr/8nbBSvo0ZNdETRtLs4BhOUHOQ4+9bXGKhLAcy7leD MXkRfbOSu8SElbK/oppMhr2DquwxiYHhHL8CgTc4RrkbpnxlHeJP1kdQtYmmM3hrcvwk ppMtiLPDeZg0Fj+bOSp5Hg47Nqi+fNr9Z0tJNQkfR7rgTqdOMcpdroRuVWABS1IJHZY9 Wrxho0IplLqwKS+HDIjJ992jLP7TQ2u3a4oj5GYYUch9PJIc4jLgiy0HXGq0SK7X+kj0 4rZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787236280; x=1787841080; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=w/t5DVoi7TH5Cdgh1wqQM1FGHTFp6QNHPSNcYTK660k=; b=hiH7M73k6VWYAZwVmdNqPw8NhvUssalS2V4pXB4oPyFU4HSbmeO5X9kEAdmh4DNUXR M1vXClXRXC28UjnomEuhr0MVCtNvTmkgfNKd9O56g7k8QWA9hsSUC43Qqu5AgQ7KXh24 q9W46xM3ZwYwVJ+0LlVX1XWHxFjJwAptVa4vYlGvtwzu/ZxfLX5xIP2Zs4uiAKk2gqpT LD2VmhsK8KLxD83GpZnORzXY53meqClcQOyLZQQRE+2nFk9erBtMW8ANJZ2oziOQcZyT XD4TxqTlT66SX5ZjxOCTc0ri1a/dJSp1U82hZR2Sky6E27V/Wu0ECFP5I3ky4tDdrrJX Ye5Q== X-Forwarded-Encrypted: i=1; AHgh+RomhXczBrYQybyKFkqIhFLYCqJDT5OlsprBq4fWfiB8pDA1ZIj6ksqKPJ6mQCpxjE2y3kmOAyXky6njtOI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn75KXwRlfhjdoN1exy4A61dSd6M7PcBSwgWpuudR7gKPNfffo hiK983zVglvodpfuFfLlHXI71Fr8wrackumP6fPSmKCOxKpO8+okdQhpSKf6RAbEKSUv2n3y5mF UmRX/3z8R0108kp0dIz5xK4tbe5OkLYjk4hp6+DGOIG/jKd+ACYDNzckJj+ExJJ2qPghT8+REBp g= X-Gm-Gg: AR+sD10kt+C1h99JCAdu9VQ6GKdd03Wv956+1+HT7226lXo8sYq7Gehc6POwAeU2Scy qxYPzWrTkkhbKXoRRxgv3Kohs4og8fIpEgyQ7l8f3EHjphGQ00iyI9vezq80MkbGnn7M4ZhFj4Z aciZ5SJBiBenX9AeMavMSgV/a7IsqlI5y34qF5GS55W9tOdrFYItcJf8D74H1eNuNBpUh/4x4My gnFe4dXR2G42Z+dhcrmDzdxdWOqKJZApfxQP9MPF5nARfDCSZLSzsJivD4aBAgSdlg+25LZ0iwD Suuh8FMLwc+VETiY0uM/c5txY+iC7UdYq8oK5rt2MWFUFgK309YtpFnzlaPoc2/W5GWcpNKs+Pe 0BW8pKOALUFKLnW+XaWzzKJNU5C167Wk5Q4s9 X-Received: by 2002:a05:620a:4594:b0:936:f984:bbb4 with SMTP id af79cd13be357-9371e2cfc85mr1067601785a.3.1787236280228; Thu, 20 Aug 2026 07:31:20 -0700 (PDT) X-Received: by 2002:a05:620a:4594:b0:936:f984:bbb4 with SMTP id af79cd13be357-9371e2cfc85mr1067593185a.3.1787236279786; Thu, 20 Aug 2026 07:31:19 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b145c9d7sm15226618f8f.15.2026.08.20.07.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 07:31:18 -0700 (PDT) From: Viken Dadhaniya Date: Thu, 20 Aug 2026 20:00:58 +0530 Subject: [PATCH v2 1/4] soc: qcom: geni-se: Fix endian conversion for serial_protocol comparison Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260820-fix-write-to-read-only-firmware-buffer-v2-1-7badcdc455fe@oss.qualcomm.com> References: <20260820-fix-write-to-read-only-firmware-buffer-v2-0-7badcdc455fe@oss.qualcomm.com> In-Reply-To: <20260820-fix-write-to-read-only-firmware-buffer-v2-0-7badcdc455fe@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Viken Dadhaniya , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1787236268; l=1170; i=viken.dadhaniya@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=BhkOYK28pMRgnAFg3axElJ/0jV+SlRNGNmaeKhCabOk=; b=iJQJCCKhcAJMSKaI/4t0HLYDUFkDFGoH+1Fm9791WNrlxjwkVegDOzDLJDcZDypTHk9xeZRgD Ne7/j/jUjpwCwijydn0HDlBgTrxIKdzDDAFvzu0z33ZAcMbQ6w5EQJr X-Developer-Key: i=viken.dadhaniya@oss.qualcomm.com; a=ed25519; pk=C39f+LOIGhh/02LQpT46TsUSXRvBn9qXC8Xb26KJ44Y= X-Proofpoint-GUID: 0te7ka-mbSKW9O2ELewsRJxF2yJKnCfb X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDEwOCBTYWx0ZWRfXzRD4wdWNhkqT /JKFhlp3YYUpRgdHyuXmTJNJuLQPmErZq0QMyKEQbpDogOjfwV+z9UbBPv3tuU2GZhq2rgSvEab XE4ldDnDCv18XgXdOX2xyTWR2Nj2vho= X-Authority-Analysis: v=2.4 cv=T/O8ifKQ c=1 sm=1 tr=0 ts=6a870fb8 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=BdrV15eiT15NMrSX6N4A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDEwOCBTYWx0ZWRfXy49j2wksLYGW 0tOBiDlmE6VLSP39WkaaNGQ7Z3odak8bMiMR2jDfPWKwAmrJCRDWl6JLPMwDZPoOae6mY62VUFP 7vZGRWdTkD0WFzy1aZ/8nl6BOa1P8r42cWdkejxftDNSzGz9L1Vq0D8TtezR95frJy9gAcM2ol0 lUWQQwOXLJ9vYWvXy2L6d6goKG8RiTAXpnCIW3iNsWF5D/bH0YvANKz925FaGp1kJ/IQCiW2fzo C46VVtFQOXVjyppyVSMdftOgKUJ/YkGfbKFT65m6wiOUXyolb/VD42rF3aAu/nUH82sXulsd/31 N3/7VQdZWmFRXh36V1Mc2F3pmE0A91pMD1HmqucOGQE+ZWtNnNajsXj+xau2Dd1BcrEdHQGJAz4 0UMaQ5d21HXbTE2eWh5YH/b7Vkf7+U4u8TH5m1YO/+WKz6cWcYVhRliKFDUYuhktJm2XtVTibzf 9yRQZjETAsYinVHCQDQ== X-Proofpoint-ORIG-GUID: 0te7ka-mbSKW9O2ELewsRJxF2yJKnCfb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200108 serial_protocol is declared as __le16 in struct se_fw_hdr, but was decoded with le32_to_cpu(). On big-endian systems the extra byte swap causes the field to always compare unequal to the protocol argument, so no firmware segment is ever selected. Use le16_to_cpu() to match the field width. Fixes: d4bf06592ad6 ("soc: qcom: geni-se: Add support to load QUP SE Firmware via Linux subsystem") Cc: stable@vger.kernel.org Signed-off-by: Viken Dadhaniya --- drivers/soc/qcom/qcom-geni-se.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c index 873bfbd6b2b7..1d6e6611441d 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1298,7 +1298,7 @@ static struct se_fw_hdr *geni_find_protocol_fw(struct geni_se *se, const struct if (le32_to_cpu(sefw->magic) != SE_MAGIC_NUM || le32_to_cpu(sefw->version) != 1) continue; - if (le32_to_cpu(sefw->serial_protocol) != protocol) + if (le16_to_cpu(sefw->serial_protocol) != protocol) continue; if (fw_size % 2 != 0) { -- 2.34.1