From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDAC23A16A1 for ; Thu, 20 Aug 2026 23:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787268770; cv=none; b=d73U1WcFL4/YB2PLO5vaxNRbvyhBpd5KyDi9wKKCk+LRBRuN993F3IeRbGbPacw61xE6W1X0ZtNhuyr8w/RJS0g2qKHm138E3pKMlLDqKzAzKTwpKCEwykDuPgrRNaFeUiGmpCedEKnZSszj2FhnySNkZ2n8eeU+HyR3UZL9mDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787268770; c=relaxed/simple; bh=1sJotEgA8ehiPs3J9DAGu4AbZ2bnjjEWvNkwbMlJckU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=m18BUd4By0ESP5K0EXXFemFaIeOdjIv3EGnjSIHLzmAh2uryi8CgQ9gv11FrcygJU2j44IcolIelj5bBt8MGc5HOb4nsdtsqMKlUMrM7uJZLBFg3yIQ1QfXcyujgjo9P8+Qqf4BxNjFH7SRkcEw03HFXRXcrgDLzA8A97516gQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=k6T6Wv+7; arc=none smtp.client-ip=209.85.210.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="k6T6Wv+7" Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84857446424so630517b3a.1 for ; Thu, 20 Aug 2026 16:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787268765; x=1787873565; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=D9DlHJtu4nYE/0Q7Tlo35sv+3vAygx91goMAZ3ynrq4=; b=k6T6Wv+7k/owLB+flVvGutMx1PlrVtxMdLjFhSbvL/j7uz/Q4R3lJ7Edl64397L5eW mlOBHIRyCozdIVxe4jRhFXEY/a6zC3vgUPH7sFYxXg/qYj75rYJab6CPY8BFaIizPykJ 0WaHeZc2nJl4CfM3vNXubTp7TtduOSGzI0beLNl8qstNwzB+3ex9WYaSmcj04bTjVw5O bjHjqXzC/VzMmjFwitr+3GmMoHJbyM9nFM3Z7o60P3On0DLs/O33V6y4uuZZrf98BbaC 4Dp016aRTR2i4tleuK8+UDu1t9ch/7+X75Z+CkNHe0r/aRa0Eft9vuvWGFwgz2fgAxBs vLzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787268765; x=1787873565; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=D9DlHJtu4nYE/0Q7Tlo35sv+3vAygx91goMAZ3ynrq4=; b=FvZWjIaamjKBQbUuKew6vhLjXfkX3LEhZi83FQ6Zt4jr7p4a+fkCvDlbs5ija538IM m7OEN2VDDvC3lfpb3yeLAzMAPUcP1lD/qZskH7QE9ZaoGYOZjSP71t+A4REG0dSiznZh i3es51dXGUSOdYvRXzLLL30yKozrtGUC/Fatl4hmRi9TcgVmzCEyAzsscMfB4FDIM5M9 7Xg8A0xUUyZv+/seM+/LMzLlS3YmsKJKlMADANtpF2pBaefuLojbxG8atRZnoX1Ic4HL P8bGlTolsIEaTM6wIwXoJ+KdIkyDMo5ECz6jo84kK00Qkm3b4wHmbQrCyDfm6APIO8Uk xiYA== X-Forwarded-Encrypted: i=1; AHgh+RqmNjLdsz6uqtebb7MY8jPHGn4OS3FWybBQyj8/ZdkFz6sMC5E8o8dyV1AK5eoPd6IRN9wgaFI8V+SJ3sk=@vger.kernel.org X-Gm-Message-State: AFuF++nYc80vGgfabAoTWt6joyjK/f3sTLuz5R8PohePJquCwBftqqZr W3pfdKhZhrMCYj3ymQCU05kZawXKQACS7YlzQUP/KYnIkJM/SQfKo6Qkh2ByAInsHRD2rMb/G0F OVqT+tnOizTOvS7E01cm0pMGZgw== X-Received: from pgsb12.prod.google.com ([2002:a65:67cc:0:b0:cc1:4df5:5acb]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:8010:b0:84f:a170:4f5b with SMTP id d2e1a72fcca58-851f9aa7714mr2971480b3a.8.1787268764952; Thu, 20 Aug 2026 16:32:44 -0700 (PDT) Date: Thu, 20 Aug 2026 23:32:36 +0000 In-Reply-To: <20260820-gmem-no-return-page-v3-0-3bf8f80a7b4d@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260820-gmem-no-return-page-v3-0-3bf8f80a7b4d@google.com> X-Developer-Key: i=ackerleytng@google.com; a=ed25519; pk=sAZDYXdm6Iz8FHitpHeFlCMXwabodTm7p8/3/8xUxuU= X-Developer-Signature: v=1; a=ed25519-sha256; t=1787268758; l=1353; i=ackerleytng@google.com; s=20260225; h=from:subject:message-id; bh=1sJotEgA8ehiPs3J9DAGu4AbZ2bnjjEWvNkwbMlJckU=; b=x9w/WvPH12uIL2DGAb5DL+tydH0mG6AFPF/kocY0XpSFzUkQYU6qgERR2lFjs4T457yY7MM0c q7HGbnpu+exD47dSoIA22tQ/jsBNKwgkYwIbWfbJghtPXWJ6s+RH79A X-Mailer: b4 0.16.0 Message-ID: <20260820-gmem-no-return-page-v3-3-3bf8f80a7b4d@google.com> Subject: [PATCH v3 3/4] KVM: SEV: Drop page refcount early in VMSA reload From: Ackerley Tng To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ashish Kalra , Michael Roth , Brijesh Singh , Marc Zyngier , Oliver Upton , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , David Hildenbrand , Fuad Tabba , Yan Zhao , "Edgecombe, Rick P" , Vishal Annapurve Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, Ackerley Tng Content-Type: text/plain; charset="utf-8" When reloading the guest VMSA for an SEV-SNP vCPU, KVM retrieves the PFN from guest_memfd. Drop the page reference immediately after retrieving the PFN instead of holding it across MMU lock acquisition in preparation for a follow-up patch to stop returning page pointers from guest_memfd PFN lookups. This is safe because the page's validity and presence are governed by KVM's MMU invalidation protocol rather than the page reference. No functional change intended. Reviewed-by: Michael Roth Signed-off-by: Ackerley Tng --- arch/x86/kvm/svm/sev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 563870342a2ba..0375ef709ee2c 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -4062,6 +4062,7 @@ static void __sev_snp_reload_vmsa(struct kvm_vcpu *vcpu, gpa_t gpa) */ if (kvm_gmem_get_pfn(vcpu->kvm, slot, gfn, &pfn, &page, NULL)) return; + kvm_release_page_clean(page); read_lock(&kvm->mmu_lock); /* @@ -4076,8 +4077,6 @@ static void __sev_snp_reload_vmsa(struct kvm_vcpu *vcpu, gpa_t gpa) else svm->vmcb->control.vmsa_pa = pfn_to_hpa(pfn); read_unlock(&kvm->mmu_lock); - - kvm_release_page_clean(page); } /* -- 2.55.0.766.g2966f0265a-goog