From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F5DE2D2394 for ; Thu, 20 Aug 2026 03:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787195469; cv=none; b=Ul0THi0NXcXLDwzcQMH3AN1RqrCunU6AyjCemlz/YiPEpdK5yak66bJUd1pdznl8WoQwrQcprvALxCYi5aRN90cIyQevsPaI1+afSj1veXtTb+EEhzwYu7c3S6kR3lVSA5MevppgSh3Yx6yQnsC372qkT7bcFHaIHoVzrhsXoxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787195469; c=relaxed/simple; bh=A1RtEHDnTX4VqteBsoNtnFeqhWignpf+3HRBFtSi41Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=moLAWmUksWMGIznNhsHixjI5xu6UVzvltP+TMOzNO1oTo43BBUgxj6EgcSeDGHU2caTR3xNYbVT3et0+vl3YSfSHapJnqJUcHb8ZnOl0Po5y7dcfaaA6M6mps9VfhbUia2n2um3GKuKLjBWoB2CJnPUyCB+ZRJjXdNJZ/qWqsjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TrzxCnH0; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TrzxCnH0" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cc891373e0so21018445ad.2 for ; Wed, 19 Aug 2026 20:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787195468; x=1787800268; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LsQFRjNiJYCD/Hb5maV9dtGODC4Q60m2oS5/S3Jp00Q=; b=TrzxCnH0FQNElVxmEhsAsrMjTN6M3ZSU3732UZ0jaeudlYlr7+Wct5+wMN04FcOQVE M4Nu9/8nJmw3iBaKBkJKiuYUcv/jMB7YUG4ZyypTEE+Xt1932gPaiXYcUo5Kzz1/Y2yf UY4wlM2eSMLTn9L1THrjrHAQ1K2N7biONfrkRBVZVDWJcip7ycZ1bVSrcO+eQ4TS/cFZ 27F7alQ6tfZ5wPX+bZf+q6AWKscy+CtfqNe6HEUEXjIRl60LSL+Rl6SQc4YeSLKhAKpr nh3RYVOsxsxjd3rpYKL88VZ3uZ34BSNSaXUycHfHOTgc6jQREPCoUbvCR3vuIdcX/PNK RkKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787195468; x=1787800268; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LsQFRjNiJYCD/Hb5maV9dtGODC4Q60m2oS5/S3Jp00Q=; b=OE4l/VrbhGVt8BLLEcS1iN/7RZyrUOvSNILFMFWm14pOgZyltjfvgmkCpDzkTKS5A5 IG23kKYngzAKi0xKOdG309cKTOPW9WHPyfzt2rY2vYol9oPUu7jC1nK1Udypm17F+hR/ qWxLvGZa2+QgF9NiMTylP5aJHlxQA6n4/Y8+dN+CEEul5qSr/qG1XiUpMsGfV/DNPA3G p+jCXa/GT0QUAySoIEQ6ld1llJvjP85OgxcXBxR9b9icywPF5YazzrkdFOK3gUPrXeGF nit8UTNcDjb0M9RpiJKjMD9GE4XgsekznNnnwInm0PnlG/oZn/BJs5JSgTaLgeVQeGjp MU0w== X-Forwarded-Encrypted: i=1; AHgh+Rrv7cjNAZKJKciGRT5ZIez7k71MXY+kEHX+k9zbGe86fU+RI+RdtUDQkXOxsd0ZLJHfZlZMfgOHWmiCTYg=@vger.kernel.org X-Gm-Message-State: AFuF++lsMhpZWvRoqqlMAWVTlX51hFqDSApYVHExCptsSJivmgKWQpNV 6lp5d/fx4lsIkl25V9J8yAsGfaoOjS7MPkPyZAne1KT+g0MM7wJ7C+Tr X-Gm-Gg: AR+sD12ztnpqw0D8YYla0lHm/U7/MHiisg+/G3q/CP1DghT5FhMLNC2nEJpfjIDGnbF QsDBj64LVDsnOuGThKPJVZeJrOsUe+NQalokqEKBnoMfqbqMyWvhEEVNS8tmH2tmIpMJARg8LNS tdM/JzvPzUWLBezpQUFdXGa4CWaFPyL3HfIxInbBN8II/iilOnA6ukGZ07q5UpmUxfPfnuUKfW1 qKhBiDGFcCfiUv9vSsXJ2/5moZhElxgKY78sqBTWlUjhJ+hVViCgC0SYNqXXBuSDIl6OR4PPkzu Nd6nefSE7Cj5aPOJk3aydArkaOLAdpUCEzYcKbcslixltp3ulO56TELdOyxdREczV3AqMft++F5 tyD+kVIfZP+0cJG9h58NnFAs14KrJzYnBt7p9r63QuL1atInIo1YD68EgWYSkWmjEgb59yqhX/U iCeMEwJBbNgeqXmgEVLFhq/JWV2dEETvrfiFCtSvB8S7sxfG2+zcOpIawDVC57X9Qg3VwnTUJZ X-Received: by 2002:a17:90b:4a4b:b0:37c:607b:2cd9 with SMTP id 98e67ed59e1d1-3958054b82bmr15871490a91.0.1787195467778; Wed, 19 Aug 2026 20:11:07 -0700 (PDT) Received: from osman.mioffice.cn ([43.224.245.178]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957fb17f48sm5562328a91.2.2026.08.19.20.11.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 20:11:07 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org Cc: Zhan Xusheng , linux-kernel@vger.kernel.org Subject: Re: [PATCH] erofs: support SEEK_HOLE/SEEK_DATA in inode_share mode Date: Thu, 20 Aug 2026 11:10:59 +0800 Message-ID: <20260820031100.1038753-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260818113713.116849-1-jefflexu@linux.alibaba.com> References: <20260818113713.116849-1-jefflexu@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 18 Aug 2026 19:37:13 +0800, Jingbo Xu wrote: > - .llseek = generic_file_llseek, > + .llseek = erofs_file_llseek, No objection to the change. While in that table, .splice_read is the entry left that touches the page cache without going through ->private_data: .read_iter kiocb_clone() onto private_data, then filemap_read() .mmap vma_set_file(vma, realfile) .fadvise vfs_fadvise(file->private_data, ...) .splice_read filemap_splice_read filemap_splice_read() does init_sync_kiocb(&iocb, in), and filemap_get_pages() then takes iocb->ki_filp->f_mapping (mm/filemap.c:2686), so it works on the user file's mapping, which after your patch is confirmed to be the real inode's. erofs_fill_inode() sets that mapping's a_ops unconditionally, so the data splice() and sendfile() return is correct, but they populate the per-file page cache from disk rather than the shared one read() and mmap() use, caching the same content twice. Thanks, Zhan Xusheng