From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD1DC387371 for ; Thu, 20 Aug 2026 04:57:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787201825; cv=none; b=NCEpOdNJSkixZ+x9jf/TsfiTqSkhCPG/pUY781LHGs3l68/LzWqbBLtBkCwj0YvTk5tCb7X7oTc7QayyINcJxgZ8Xd2rPSVcbVVVWi8JpO/xI+dioTnJAs7Q3fy4/mH/U91JfEc2zZFODb1aJ7/N3pewcPakHmiE/zzi1gC8YXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787201825; c=relaxed/simple; bh=Il/QPT8I8KLH9DxQsynuoV5Cl8hwv6pjB//hiP3RD2E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Z6BXenPKSfcMVZSbrtGe7Kv6/TVzbHCAw+h1FUVljWp6Q7BnbQSJ8yahFd2ylaSx89nnQDmfK32xYKyDGSrxI8ONaVURUJgUVkoXvkUo46b3lYkDYEtIDErbA8jmDsM2biFhrb7rtcq4c/O77Jlqio70p2EVSJFTOXoknERA0Fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sz5NyFbw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sz5NyFbw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F42331F00A3A; Thu, 20 Aug 2026 04:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787201823; bh=migX9AimFf4wvpqfBtI4GwlSnq6tIejoAluPFOiC/J4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Sz5NyFbwN2J4MMhQTyIvIxHNG8WSaelqyeR9V2UqarMofhJfHfpA0yGE/5BYbjgN6 /Sf6OYsPdEFbl8s5wk+cZkll9yhKUfYCQfAFV3dY8AqkhZZJt8cq9ED/MluPOatJmf j1i7BRj76XWTMzulyczJjbuwxND4gRMhH15HUKznwBXH2ceV0E6NRWteBIlhE23fs0 tl/CY+BZ3nfJF8ujtVZT3oQ6cuZrJXLC6bpfzs/fyl1EW5Fdp6bljzEZhU4NwEK/LT rEkzIkO74KJwivg7V97pP0luoGdP4lA+UPfWdOmgRET8RnrW0nyxVPrEE/vWI21EKS sz92nkve/+HAA== From: "Barry Song (Xiaomi)" To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: axelrasmussen@google.com, baolin.wang@linux.alibaba.com, baoquan.he@linux.dev, chenridong@xiaomi.com, david@kernel.org, hannes@cmpxchg.org, kasong@tencent.com, lianux.mm@gmail.com, linux-kernel@vger.kernel.org, ljs@kernel.org, lyugaofei@xiaomi.com, mhocko@kernel.org, qi.zheng@linux.dev, shakeel.butt@linux.dev, stevensd@chromium.org, wangzicheng@honor.com, weixugc@google.com, yuanchu@google.com, Barry Song Subject: [PATCH 1/3] mm/mglru: improve readability of isolate_folios() Date: Thu, 20 Aug 2026 12:56:01 +0800 Message-Id: <20260820045603.68809-2-baohua@kernel.org> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20260820045603.68809-1-baohua@kernel.org> References: <20260820045603.68809-1-baohua@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ridong Chen The for_each_evictable_type() loop in isolate_folios() is misleading: it does not actually iterate over each evictable type. Instead, get_type_to_scan() selects the type to scan, while the iterator `i` merely bounds the number of attempts. Make the fallback behavior explicit in the code and remove the opaque for_each_evictable_type(i, swappiness). Signed-off-by: Ridong Chen Co-developed-by: Barry Song (Xiaomi) Signed-off-by: Barry Song (Xiaomi) --- mm/vmscan.c | 46 ++++++++++++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index c1404a59523d..d5cc30b667ad 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4833,35 +4833,41 @@ static int get_type_to_scan(struct lruvec *lruvec, int swappiness) return positive_ctrl_err(&sp, &pv); } +static inline bool is_single_type_reclaim(int swappiness) +{ + return swappiness == MIN_SWAPPINESS || + swappiness == SWAPPINESS_ANON_ONLY; +} + static int isolate_folios(unsigned long nr_to_scan, struct lruvec *lruvec, struct scan_control *sc, int swappiness, struct list_head *list, int *isolated, int *isolate_type, int *isolate_scanned) { - int i; - int total_scanned = 0; + bool type_fallback_allowed = !is_single_type_reclaim(swappiness); int type = get_type_to_scan(lruvec, swappiness); + int total_scanned = 0, scanned, tier; - for_each_evictable_type(i, swappiness) { - int scanned; - int tier = get_tier_idx(lruvec, type); +retry: + tier = get_tier_idx(lruvec, type); + scanned = scan_folios(nr_to_scan, lruvec, sc, + type, tier, list, isolated); - scanned = scan_folios(nr_to_scan, lruvec, sc, - type, tier, list, isolated); + total_scanned += scanned; + if (*isolated) { + *isolate_type = type; + *isolate_scanned = scanned; + return total_scanned; + } - total_scanned += scanned; - if (*isolated) { - *isolate_type = type; - *isolate_scanned = scanned; - break; - } - /* - * If scanned > 0 and isolated == 0, avoid falling back to the - * other type, as this type remains sufficient. Falling back - * too readily can disrupt the positive_ctrl_err() bias. - */ - if (!scanned) - type = !type; + /* + * We are running out of the current reclaim type. Fall back to + * the other type if allowed. + */ + if (!scanned && type_fallback_allowed) { + type = !type; + type_fallback_allowed = false; + goto retry; } return total_scanned; -- 2.34.1