From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56B333B8BB9 for ; Thu, 20 Aug 2026 07:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787209600; cv=none; b=Dx11sDwLG2ij1Di9uSJ0uK/7C8DmM6vd0g3uuIGpS2nwRJb0zZgiGRxdjOorRv03UDyAemb5fQTtTmFxxE4bF0bCP8vEYvTMNGMtbC5jlY8kWbrzp8vi0yi62KX/4zKywpuZvIYaFsTEGnRWj0C0u7yhvs83hw8YYZGK4TXeq20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787209600; c=relaxed/simple; bh=bISfyicDdSVgGTIJ3XXfHhL121ttkBeyMJAc4teMCF0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=quxOCXhlQCrC4HxajH9pFQaGricJD57AXL18ZsCUmuFs35hUo0QB+sSGR7QlHMkxAwe8NeSZnfgTxXqYn2S3uQP7a/LrogBtkUQTLpP5Nuhs0t3e4OBDu/c2W6jPYjb0AISNyO1ooH82vNBDMJduMYEuBr+XqPMEwLPDm6kgv7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IlD9NSwW; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IlD9NSwW" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c9e607d81fcso991183a12.2 for ; Thu, 20 Aug 2026 00:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787209598; x=1787814398; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zMAp3wQtiDEpnFh3jW4YwdqqglRZMQsWXmp530DZXnI=; b=IlD9NSwWblpxFhct0JA+wVaeh1wQTAc+IfTxJ0zo9y4QtxbVIki4GHrN274TOQiNZt tUikPAIgjrVS1qACfBDbjGKGrWeydMqIbTml14B64UjNepP3jvrOJXGk4Aw8oET7R9Mf I5gP2xF8f4Zl9dGr8Rq7g7wznR+ViV9T/7TR9PQMWs9SBVWGFKhfbh7rINJxsL6dAuWR 1zETZVYhePqwCA/f32w5aMdX29z4U727VCyEu29+gcSizhzgMJYsu9krUkThPMXMlvpS onWU9f5TRLlO90Eecm6G3KnoD++m+VOoNCpUrDngeXFgUQzicO6j9tnXxy6PfYMlwzDV Lvww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787209598; x=1787814398; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zMAp3wQtiDEpnFh3jW4YwdqqglRZMQsWXmp530DZXnI=; b=CRAtTRi2cnWLwUWOhiGxzaBve1mTxo8pg/REXAPG6OypJ5wn5UpRAfTeynIuvquCfd cLMtP+EA8bYxIPVr1QiYUapTz7ferEkRrPoP1v5oeXg7iaBCi4Re1fYyztrKQD912z52 1sayvrWfDAUMz4+anOvGcCmgw1i5OwcWZTgnhWV4/8KEfnhQqGKU8pXFV2KoiXCnsb2T Q+x6xzejTyZbdZV+15qkASFej/QkEUxLxRkkuWvgvPQQXU7P9kKhU86Ju1L2N3rfaWMT 4Q0LkIOkgX8Zla4Jv9unXzVi92FG3x4c3aBlY7tpAcj7s0Vwas7K7HQInPVUmr5zZYe2 BL7Q== X-Forwarded-Encrypted: i=1; AHgh+RqoUlHNhdq0LNf/kmsuz/uZUbskHfJRSdCUQolfCFp19BiKEA4gx6VGS8Duf5r8q15Kw6lSA8sKDFhTo9g=@vger.kernel.org X-Gm-Message-State: AOJu0YxU1EtyJL8EphSaCgUyU16qY1gPzBe0TXX3HGvbFujACeX23u03 XEXPI2Y4vPd6/OlytEMe7lXeZZE7PdZ1WateNBe/Lht6vyKVRhf1Cy64 X-Gm-Gg: AR+sD13bjZfdFv8uGmAkM9A+MP+yfLi73iG+RByi3IwyDpjInfQWSZr6sHrqu1jIIcS NVrxmGQynEHI0L/zSyuAK85mNZh0LER+dwPCOBMglxcaOe5mg6M4GBgbNtkGbIcjvKMlJnGg/5M dO5YK7TIuhCYCQt/+ZZYkXv3Mma4M0KN/gp7g0anHlBXxaRXCleOoiTp0qYfwdfSoELyY/9U7oU xt//mYncF0QkWFC/zeLyJN6eMK3TLeT+rwH99nG3UejA936q+mzcBqZBznZTnpQktraSFT3fjGg t8TZ6jHr2QaeUrDwJamEXrkMBIPcLrs+mm9GQh601K6P175WN90Sj/4X99zZI5lkUc5Y0xpILEE d381Bwy1ZlpTrgoLINAugYLf+lmRdyjEKbALknJa/MLtOaTjBwy2Er/20Zydg5qOgm09MO060zL fJ2qdWW/MQBt/lAFZM1DGAIClR2BGBz8AtIwtOr4Lneip2IuXPgJmKvLjcmnSG X-Received: by 2002:a05:6a20:a126:b0:3bf:9b61:f7ae with SMTP id adf61e73a8af0-3cd011a0cfbmr19140084637.14.1787209598506; Thu, 20 Aug 2026 00:06:38 -0700 (PDT) Received: from tradnomic.. ([2601:646:8300:7570:17d0:9614:8caa:e85d]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1416ad69638sm12460899c88.7.2026.08.20.00.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 00:06:37 -0700 (PDT) From: Rafael Alejandro Diaz Cruz To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+e5e28c3e953b2eebb16e@syzkaller.appspotmail.com, Rafael Alejandro Diaz Cruz Subject: [PATCH usb-next v1] USB: serial: keyspan: Fixing use-after-free in usa49_glocont_callback() Date: Thu, 20 Aug 2026 00:06:21 -0700 Message-ID: <20260820070621.3286443-1-rafad900@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit usa49_glocont_callback() obtains the private data from all ports of a serial device using usb_get_serial_port_data(). This can happen during keyspan_port_remove() which frees the private data which can cause UAF. Fix this by calling usb_set_serial_port_data(port, NULL) inside keyspan_port_remove() right before kfree() of private data. This in turn allows "if (!p_priv) continue;" condition within usa49_glocont_callback() to execute properly. Reported-by: syzbot+e5e28c3e953b2eebb16e@syzkaller.appspotmail.com Signed-off-by: Rafael Alejandro Diaz Cruz --- drivers/usb/serial/keyspan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c index 4d3746c7a94e..0e08acb99970 100644 --- a/drivers/usb/serial/keyspan.c +++ b/drivers/usb/serial/keyspan.c @@ -2997,6 +2997,8 @@ static void keyspan_port_remove(struct usb_serial_port *port) for (i = 0; i < ARRAY_SIZE(p_priv->in_buffer); ++i) kfree(p_priv->in_buffer[i]); + usb_set_serial_port_data(port, NULL); + kfree(p_priv); } -- 2.43.0