From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 918D63C09F5 for ; Thu, 20 Aug 2026 07:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787212594; cv=none; b=SVt6M7GbVkvjJ2Z2xNnUkQwhExaCyBV3SQKLDOuVAJAA0HRk5etRDK5HrVhAUwxnOi6uTFH/ZC8U6M5AHc1B92ITirER3WfC0yE+8OHV898cPQ7wmfhKYJ9XJIFde0W+4mUcsdMR93ZKD5Utg8p4dBoIaUGIThDUCZSGNF26uBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787212594; c=relaxed/simple; bh=mkIJqeI5lb0TvwcAO/Hc+RpTXNevimkR7Kn1RSFWUzY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Axi3RchCIElsZ1PhD1QnriTBSzYcSlQJSERNEs/kFc127YZx+5ThWmHYLZalxOpaQkpXlziDRX9iPsajkVM2E/X/NwfnhShGIAMtR5Ik+tmfvkEK+bwuwYHXl6+xooxyQkYf6ETTA7C0MBWfKmDEnevtLwvVXUPZI+m2SmfMPLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QwalRe8S; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QwalRe8S" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84eb992a881so1568966b3a.2 for ; Thu, 20 Aug 2026 00:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787212593; x=1787817393; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mkIJqeI5lb0TvwcAO/Hc+RpTXNevimkR7Kn1RSFWUzY=; b=QwalRe8SowImY98OdCsZ+ZaQT2hHytv7UD/0s5jMRbJcLsjUxn14WmW/lZ2DYVlt5y 21lR03b9DmI7hXC8PXYv48LtgyqjEOPlmN7RpAETYmIBI31d5HMfgcF8zrC3S+//pcCY 0TGEhvZ9ZT9166Oe/4HhMwSjCD3JOYCrE+EepxVysqFOaARtIHtpAlF6Pmhn+jqecVQA UdubMIUOyHtI2UnOi0piL0OBTNA49R5m23EN/OyLIc97yNjd8ZqIbmUBT2ZZhmEEbDZV pqKmb6KComnME3fUQJrWL8H1tUUzjTWar7fj+gvAUWpP4dgH9gElOYZzjWbthWlqEme/ sgbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787212593; x=1787817393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mkIJqeI5lb0TvwcAO/Hc+RpTXNevimkR7Kn1RSFWUzY=; b=YpBjxDqtHg4z9E4XI7Mbg8qbrWwPGy378RzXom7GHTaKkcvFLpxTRVbsH3HuT5/vHF FUVhNgMySOTXRHiT9u+MtjNvN1yodt0ttiP0CZBPT1goi18eXztaGQU/0xhD8zJ7ogo+ 2cRvm5y/qcvtyGVfuHK6RNJQzB4R/AowfGW5yTy5qYTSG7+CjaE6IzXG/oBISBWcmTWv G3kHQGmZU3EgVKtEgjEm2iHeHVRErxcmY6zf8u0kCys/iUds71Lzoaym50EVNWNy6SfL Z9HU/7R0dcKM2emKdtEKn6WWGYu3wo9aXcy4CdYmy9iEPlsngNezikrbIQcCG1cVFEgp 1lAg== X-Forwarded-Encrypted: i=1; AHgh+Rp+jjBeoFU7x1tiOXbHhJVY4npD7YqNyLIgMzJQ6GPXEBV2SSxpixN4jlD7bRy+iGbdZVLZMpvHQTWF+6g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/EFpXsGohT89Ofj6QkkCy4N00kPs81P+/MLQRj4OhbrShBa2z SCBMWO9wqrXCirCrwyU9QbHRnNeUpkCZbhW4Ase5nTAKBwtqbbZPXw1/ X-Gm-Gg: AR+sD12hpftJJQzIMtvdQ4/GhZ7JdhRfDDubZY9WDva6ur7uahOBmFVJ0Amk4hmwhhb xxmyX1eNAmHlkvLWnAaSJPYQ+JX9vZ0CBskrm+2MH9vFwdD86F7d/q7GIS9crudpdk0bJ28myMY x+38itZdyAodI2Eee9323R+xnJwNKos6/rr2W2sOQHXTsJjYsgSHAfcfvIsx7BBtwCb7Wx2Eyq5 qQO4LCSENDZo5VqBGxa/3NX9xhyyyay7ts8T+EB0q6RB0MqU8bcTurbg/nfSs+Bh5EYYxDsvcew WXlnI+dYlOfxA+Ru47Znx3U78OBxLH32yJle86J25APYs4WWbfmII9Nhr+9cCSUotk9zKPD0NoK uQHZ5Y0e60OP9bS5oZWpUve4ya40Brw7gto3sWyj5cPG3z17pK5moy8GP9abJmpbAHZk9kSsbEH /Bd3ULSb3lP92rcsz7m0uBGEtgRRPMHJgw16RYLUQUVN21VrYMaTw0FoaAp012PNjRCQmFU5vyO jIAforAXB0rHvXymOHHxe88YA== X-Received: by 2002:a05:6a00:94f1:b0:84e:24df:3870 with SMTP id d2e1a72fcca58-851d3488537mr16682622b3a.0.1787212592741; Thu, 20 Aug 2026 00:56:32 -0700 (PDT) Received: from localhost.localdomain ([2409:8903:6320:18d1:7d9a:dd79:e573:720]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d3668afasm1367347b3a.48.2026.08.20.00.56.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 20 Aug 2026 00:56:32 -0700 (PDT) From: "Lian Wang (ProcessMission)" To: "Barry Song (Xiaomi)" Cc: Lian Wang , akpm@linux-foundation.org, linux-mm@kvack.org, axelrasmussen@google.com, baolin.wang@linux.alibaba.com, baoquan.he@linux.dev, chenridong@xiaomi.com, david@kernel.org, hannes@cmpxchg.org, kasong@tencent.com, linux-kernel@vger.kernel.org, ljs@kernel.org, lyugaofei@xiaomi.com, mhocko@kernel.org, qi.zheng@linux.dev, shakeel.butt@linux.dev, stevensd@chromium.org, wangzicheng@honor.com, weixugc@google.com, yuanchu@google.com Subject: Re: [PATCH 0/3] mm/mglru: clean up isolate_folios and scan_folios for readability and clarity Date: Thu, 20 Aug 2026 15:56:03 +0800 Message-ID: <20260820075613.99377-1-lianux.mm@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820045603.68809-1-baohua@kernel.org> References: <20260820045603.68809-1-baohua@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Lian Wang Hi Barry, I went through all three patches. The explicit fallback, exhaustion reporting, and bounded retry make the control flow much clearer. In particular, the exhaustion check preserves the early-stop cases and avoids falling back after only the oldest generation has been drained when another generation remains reclaimable. The retry is still bounded to one extra attempt. No issues from my side. For the series: Reviewed-by: Lian Wang Thanks, Lian On Thu, 20 Aug 2026 12:56:00 +0800 "Barry Song (Xiaomi)" wrote: > This is a cleanup series split out from the MGLRU swappiness series [1], > with the cleanup changes separated to make them easier to review. > > This patchset makes these behaviors explicit and much easier to follow. > > Thanks very much to Baolin and Lian for their previous reviews of the > original RFC patchset for this part.