From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f3.google.com (mail-pj2-f3.google.com [74.125.227.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4B232F8E86 for ; Thu, 20 Aug 2026 08:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787214640; cv=none; b=Isidmm/ilxKajMEPwFN3UoB6JAr8BvOMdpqsqc/z0ywz4YXXuaq3hDnG9Aqusf3U8L/3P8r61iaCcqmz3a2YPCeX/EjLBx/wiz1ogz6qoaSiivm9udenzzn98iQqgfHdeiOufgwAr8aIngsgy+JNzzW/2k7xejC0xygpOitZMgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787214640; c=relaxed/simple; bh=ycfcrsS88+Nt+GFe4QVjIA3ff1Izs+kBQRQyUb14H6U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VHC0gLDNBEL4Wu25XgFpI99Q7lAWidWpno+1ljI8HfiBtekyWxb43CWE5ryQYSojdt1KnS3/16ySU5tLiFRlM9Vou3RRWGy3JvPFgpVooWI8jlJpd7jN2zcUqsC/yYM0mrPbW1NoNweLXZQ6dpC7EljJfax4Nh7pU7P9hUH+HA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fiJiogHi; arc=none smtp.client-ip=74.125.227.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fiJiogHi" Received: by mail-pj2-f3.google.com with SMTP id d9443c01a7336-2ca4f02483cso1429095ad.1 for ; Thu, 20 Aug 2026 01:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787214639; x=1787819439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=j/tM+bUJk1ib9h1gE6Ghw8HEeqSFvRkkksDedV1wvm8=; b=fiJiogHix7yO7YGPIBEOofOSPjQuORvZjfR3CWvHTKZ+wEx+ilN4mH5WfsAETvrvXR qmHtK/P7MSsKx+CzHcSwXKKRxP2t/KPvmmqxhSxGL2C9g5knESc/dYvRcw8dtJxiv1dh smw44g+nfPhBQv9EqkSCdS4R/5y9lrHXwlInpRf2IGmkU+ysv4NJtrQlT08Si+Jog+6l +76YybjyHGYQuPjJMHp+og55JFBiDwzXbNg8Y4cSIMPndovWW/vH/rnKMqCj8gl3WamH 2JuX+/tgYIacUEqvrTJUxjokjA3Xx6/HZUszPVLS+LEBjoKYsAmK4AchA/7PpR3OyT0j ikCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787214639; x=1787819439; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j/tM+bUJk1ib9h1gE6Ghw8HEeqSFvRkkksDedV1wvm8=; b=lkFuhKVVuoSCXHcZQ43BAGBdVSlVxbkGey3PDqjo310RcxKU8p8Y60XbAE4g0busLV 29EKxx9niL4RmUV3UsASeXMK2Sk00N/e7/s0Gvoz7yAOMuM5KVh2nUVaR2oG6e7ikfMH 6OLWvGnYaQicIAHBdl9ywq7cx5PSqdOXymaGgo81Jl632lZ1xy/y+Hp+xAYghmtRHqcC 06kys0XEFPILETe81Pb10fHDysEYpsUWqeDYyDYNpRZCjmxwV6ftFgj1Qq4Ae5N6c6X0 5Kj+Npg0nMYsY+Q0qF5m3Bmg6XfgwRHuYaikqeUOlLn2tifUVtxESLAbF8r8ko7jBI7R oxow== X-Forwarded-Encrypted: i=1; AHgh+RoSckclR7ixHke/WZv0B3DM6v2eZZwSdp0XU8r3G3Z+GicCVBoRU2gUyJHogCMHGiRw2GcBHs/xmCpppW8=@vger.kernel.org X-Gm-Message-State: AFuF++ki0OmwYiRMGwH6Sysv0vjz4oP2h35dOmdTva4oFRVvHTQasdHM Ah2HTFga4fdF0Ne34mUSxsmnrgIxvuQfsrnwCsteuN/5qXtu8prtfB0= X-Gm-Gg: AR+sD11ZP7YKflW/6Kqe5CNyD8HfD1PD+UBO9N8+O2on2uxrj8lkk6ucnwBdyQ8qxkD pu1NIZ4danA5db6/xJ4sZllUC/b5KempiVbU7EWEuoZgiGGZMr2KQPZbWieVPzgcA8A7b7ou9G9 Oz6khQGpPe856vFFJCw/XR+Cohetf4tvrjZZxDIFJ51KXSLjRjiJvuV8HU5RK9ODXotaJ4y0a+C DjMLOF0117P/x3WT9kC9LALmov/sNK3MkNkOte9pFZ7pUThmaYgUwwuB1NEj/jOVQB0lirPLVcl /kEJ0j65i2vZHILrsF+Io66TaUEQrWcRGUHM40lXLd9gP7gjcRRrRNRTvzo85rst1gTm+QSv4U/ VWapLDBWtpT0oK6JlCzaXeehYxRGEQIBWfdnZHdx1/wyKA9PMa/2/hHhYBk5uotTAk9ugKSJNsD 15JsY7eRU4Nx4eJBv1QDU0tuwgNR7Uw7EXH1lHzWbpYFOLz+dDXG560oovNnnCwKeVVbsTcjydc A== X-Received: by 2002:a17:90b:5242:b0:38e:6d55:b1a6 with SMTP id 98e67ed59e1d1-395a056b7cbmr4849708a91.3.1787214638936; Thu, 20 Aug 2026 01:30:38 -0700 (PDT) Received: from DL2XHKPB4.dl.net ([103.63.104.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957fb12145sm5711410a91.4.2026.08.20.01.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 01:30:38 -0700 (PDT) From: Triet Hoang To: o-takashi@sakamocchi.jp Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Triet Hoang Subject: [PATCH] firewire: ohci: Convert to DEFINE_SIMPLE_DEV_PM_OPS() Date: Thu, 20 Aug 2026 15:30:34 +0700 Message-ID: <20260820083034.2087217-1-triet.hoang.dev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert the deprecated SIMPLE_DEV_PM_OPS to DEFINE_SIMPLE_DEV_PM_OPS and pm_sleep_ptr(). This lets us drop the __maybe_unused annotations from the suspend and resume callbacks, and reduces kernel size in case CONFIG_PM or CONFIG_PM_SLEEP is disabled. Signed-off-by: Triet Hoang --- drivers/firewire/ohci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index 46dd53ecedc7..b7df280bec51 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -3761,7 +3761,7 @@ static void pci_remove(struct pci_dev *dev) dev_notice(&dev->dev, "removing fw-ohci device\n"); } -static int __maybe_unused pci_suspend(struct device *dev) +static int pci_suspend(struct device *dev) { struct pci_dev *pdev = to_pci_dev(dev); struct fw_ohci *ohci = pci_get_drvdata(pdev); @@ -3773,7 +3773,7 @@ static int __maybe_unused pci_suspend(struct device *dev) } -static int __maybe_unused pci_resume(struct device *dev) +static int pci_resume(struct device *dev) { struct pci_dev *pdev = to_pci_dev(dev); struct fw_ohci *ohci = pci_get_drvdata(pdev); @@ -3804,14 +3804,14 @@ static const struct pci_device_id pci_table[] = { MODULE_DEVICE_TABLE(pci, pci_table); -static SIMPLE_DEV_PM_OPS(pci_pm_ops, pci_suspend, pci_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(pci_pm_ops, pci_suspend, pci_resume); static struct pci_driver fw_ohci_pci_driver = { .name = ohci_driver_name, .id_table = pci_table, .probe = pci_probe, .remove = pci_remove, - .driver.pm = &pci_pm_ops, + .driver.pm = pm_sleep_ptr(&pci_pm_ops), }; static int __init fw_ohci_init(void) -- 2.53.0