From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36DA7C2C8 for ; Thu, 20 Aug 2026 10:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787221111; cv=none; b=QGgDI7aBAxBvRvsY13/EpmPJU9Jt292CGnPII53k3EWRgXCyZ+5IMtUlkYYD3JYTjWnvPsyVV/9DR9TvNmrc2g7j/KsFXzgTvg8WHBSlaHUT8CnViUYbbIROt/ZC6PnGLUyPHCkE9zRf/XZp43l1QgKCT13YbypoG1bjp3kik2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787221111; c=relaxed/simple; bh=8MasO+dXRse9oNs8G6DKM2d+FNiyDBA15XhW4S0ONo8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pxfM4hYSCpYYOotoNdrYJ/WiAr+SvlvkqpK6Dl1ZG3tjz2tmbmmUpA3QXdCNdCHV5gRmNXkoxIq78LL5mK+uNyimQYpDlfCtTognvdobfNBWjxP03ETnwKJmnZIcd676RQx7EjUeAaRNXP9qKIxfhP7UiEwazzKwzuMVIyMoWXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sWZSoTg2; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sWZSoTg2" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-38759bcd877so2521460a91.2 for ; Thu, 20 Aug 2026 03:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787221100; x=1787825900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8MasO+dXRse9oNs8G6DKM2d+FNiyDBA15XhW4S0ONo8=; b=sWZSoTg2s+VBTR52EKuq8Tbyybd+SK8273NDcb7IGm0bbNbS9qoCd9HjgmauqeEBYC Uclvcx9GylpMI4Hq2oh9nphRNdc4In646qItfdS2gHAKQxd77/TVTTW0mp7ecazD0bfX wn0GpMIbJmcL+JZ+9+CdjQXslKrcOaVVwOQMGRtnpFqPcy6Uc5VrCw8MpmUpJJ+WyUlj +UKZr/BVfo+9IOpRUOIvbYB8VB7FyThdPtMAE807JRt6oTI1WWkI3WYiRYjnqs7OWibg 01Qo5RIVIJawtotBqPc5lPo8xDT/sJnUWDlvJqO5H1Fl5xxMru1TiG1ZFCr9SQDdqFl/ YsZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787221100; x=1787825900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8MasO+dXRse9oNs8G6DKM2d+FNiyDBA15XhW4S0ONo8=; b=BLtoQAW7dDMTo/lY/X2hCBIzoWHhUDVNU9HBSqYX34PkBwhMnQNMyBryGbCmdoAf/9 1hiQw3HZCcdf7yDt4fYC/CwNa+hptMAZB7vLEoXyTuUzeM7qBVPAWBL3le997NlZxGaI HDwC0MROws6m/02BaUVvkMtUBC4JOjvsymreY/ZjVIQ2WeihNloEkXjPLRYXrj8w02ho ljpgQVSWj4FQZo38aX7+qqL8AlpUIGkbTFuf1w+PjPYKje8qUi80LLx/6zvweqlwAxlm tCM3pqQTPNB7fzQ1kqMNAEvOcfE9f4W4Hv4Zt/eJDPk5pEWpx6YR1tavzfa2+H4f7dOI KTWQ== X-Forwarded-Encrypted: i=1; AHgh+RpgY9cntM+q5HetcZs6ARsMMfwOMzlCsCcWh80fauQ+7udXNf/3PaP+kCwixjubmyWCMxkP9PGlb+u+ank=@vger.kernel.org X-Gm-Message-State: AFuF++lSgm+hhnMWP70MMQi+JjKwlby1rHQRkk3/kfxvVvk92zJANHrk 1ZmW6Xx6654vfxHewDfygppNSvthPYKrJioxWTRQ4ndQf45UREyvUBKa X-Gm-Gg: AR+sD13c6IEQfp9Uxl3Ytofng7sDIiKvJ6T6jNPTXPYR3n8pGxcpbg+WPwQLBsLo+SP P4g1rQQR4oYLZOd25797qpjPw8BGtvGEZrHBAn7FY0ya+CvMrFEa5l8pG4s0f3WKLFGpon+rGnJ /ffeG+tceOen4eqTpW2dik7OWNQiuZIakuAg+5zRp00RYmmArvrO+ZfrXsiOrOmE0UdsUgjFIMK /uAuWPDD8RUnxfB6MAhhlF0aVX7C0/uCKaGT/yH//83HMXu1Bcb5h3mFDtkWJpkvl2CrNECP8a8 gU9IMETRIZd3m0L2wk/9Q18zmeELS+BoKg4NCumDLq++by3XoHviaaAkh3U06SGYul8FJU3wFC5 Ly/zoGTJPJdiGTLiE05lYIWW/OHjmoxU2InXcieXyjDBPKoAXcAaAc8OmVg9zzfLFNf1gR9qmHo +zLll7PteM43E9xY/flWhd3GlwNZBeA9vSmA2vebat2TWOx60c25z58QYcxd9xBkalVacLXZI= X-Received: by 2002:a17:90b:4a4b:b0:37c:607b:2cd9 with SMTP id 98e67ed59e1d1-3958054b82bmr19417140a91.0.1787221100254; Thu, 20 Aug 2026 03:18:20 -0700 (PDT) Received: from Default ([2409:40f4:1024:6824:6cd5:fefe:4ae2:d94b]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327c3fc6675sm22408447eec.13.2026.08.20.03.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 03:18:19 -0700 (PDT) From: Jeffin Philip To: jeffinphilip14@gmail.com Cc: gregkh@linuxfoundation.org, i@zenithal.me, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, shuah@kernel.org, stable@vger.kernel.org, syzbot+af76b01c9a0f0ab60fb0@syzkaller.appspotmail.com, valentina.manea.m@gmail.com Subject: [PATCH v3 0/2] usbip: usbip_host: remove legacy rebind_store in favor of drivers_probe Date: Thu, 20 Aug 2026 15:48:00 +0530 Message-ID: <20260820101800.14650-1-jeffinphilip14@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811160541.29461-1-jeffinphilip14@gmail.com> References: <20260811160541.29461-1-jeffinphilip14@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 11 Aug 2026 21:35:39 +0530, Jeffin Philip wrote: >do_rebind, which sleeps normally gets a mutex lock. However, it does not >or should I say, cannot check for null udev between spin lock dropped in >rebind_store and entering do_rebind. This is a potential race window >already. So, even if we check for null udev under spinlock, we cannot do >it outside. Regarding do_rebind, it is called during stub_device_rebind, >but that function is called during module exit when all files are removed. >So, do_rebind is not designed to work in a concurrent environment in the >first place. > >We have a safer function that can already do what do_rebind does, >drivers_probe. So, we use drivers_probe to rebind the device rather than >use rebind_store. > >usbip tool references this function immediately after the device is unbound, >which is safe for the tool itself but since we opted for drivers_probe, fix >it by using drivers_probe rather than rebind_store after unbinding device >which is more safer. > >Tested and working in both userspace via the tool and manually echoing >the busid in the related nodes. rebind node is still left active with a >warning to use drivers_probe upon encountering rebind_store. Friendly ping. Let me know if you want me to change anything. Thanks, Jeffin.