From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFF08419FDA for ; Thu, 20 Aug 2026 11:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224430; cv=none; b=TYC3pxqNQcjRP7HCgM4+oomYSyi1DsNLD+St7FkaCUQtwJ43CwHDlQQE14PF+qr4SCWZaL8N1axrm1zDbF66nnSse8kq4mlABvC9iyXo3D7BKpqu0DI2/0j+RV8ZkoV3xh/6EzzKnosgZ2v6X3G+0WoyzJDJZBsrSY4ny7ZENq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224430; c=relaxed/simple; bh=Ax02etNy0Gd17yLz9ovg3nfEQArEGnxo7zLc/NlrZHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K7LDL17Bn5nJEZHlQKcCmCjnBBEjWazi72IlJDs6QpvSYu6aYIZY9p7UmzrqwOU0EjSOBvWjjEwE3Of7LNJJsL1RmzGiL7YsV1P4DEg2TOJJSDB0blo5WcXx+F0F89qSdl6rmelX7drNH49L4PhzL/cfhyW7PIc9ZEWdM2uQtbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aye7hP3x; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aye7hP3x" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8487214ad2bso2645706b3a.1 for ; Thu, 20 Aug 2026 04:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224428; x=1787829228; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U9ybHqnWFVYiAtnm3we5B2R9frVzEugQA8Zyjjnu3r8=; b=aye7hP3xV7PIAHY4FYtTR6xiBmMOyJL+a/IlcOapMEXD6BJ0/vMUaIjZmKKs6ZSY/O WuaKm9jnG3JklgcgoljhRhYegiHwOT0Ezngk6JAbnrmrsB7CKQis2RB+SUDXnt8PjaC5 uyhTRqcGx6oMBWBYjr3ynbvhzn56rQg9bi5DCS4UEmZW0wepSYhoAWL3gEq5ICSwCNE0 NZOFgSmV67c4OWQUC/DzN+mbW84j5XsTjQu5KNcT7iKpF36A4zBKuoOYMOPYiQE71gbX uCH1dLrpJOP2WgYVjmumzW9al4A0ggWQ/ayYm9TBrxyOfNc+XR7qVw+yq5GQnFNv5fU+ Baew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224428; x=1787829228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=U9ybHqnWFVYiAtnm3we5B2R9frVzEugQA8Zyjjnu3r8=; b=Kea/emqDpLZ9VPczCmoihC/rsxGD3x0NsGaQV4Y1NyAZQiH8TZFJ6O2xi91iLMfBu2 iesHaVWpYuI4oqk8NC8YGZ1nzSkFJJ/17iJZOctYds5Hta6KpxCCCaMq7DcrqCAJPGP3 2vBhYmrbze+Fa47J7la1AGRyg+1avr9HaWaU85/9zNBWROPxlXsS8KkAzP5qWr62Gw5U INWrQ7zjZlHnR78QBT+aspOfReFoVSndyesnMZ3DXIV2xj4VpTutZXYTZ9UweuBi/MTP BXybf0hv/xHLe9Ir0nuujEyCOZkcVT7BSrPuhCPucpubGdgv9tElDQiYJFJVw2E7ARn/ Fe1w== X-Forwarded-Encrypted: i=1; AHgh+RrpZ60v7ABaDEfGHvbpgWJ4NliNn/lz1tuavUMl92lu8I6aaZ9HNym3FVVHlzjs8cm6CJsGjXconbXGqzk=@vger.kernel.org X-Gm-Message-State: AOJu0YxTuSduqHo4YOlIN7w2RcBLvxrpaw1HJX4bk/SnzPCSM2DY4rLE XceT86OuyvUfPx0yQidk1z37pQqGLOBEYKWSnhRPQq9A83+PEMId0xHq X-Gm-Gg: AR+sD10lCkVRwZ3+xQrGKoxdYHeeuFPfonNnzUrkbB7bVpOkxlKF1D1WWEYBUQkUMSZ idIuXte8I8b2/ucb53mwEVJtEcnS4Y7iNFVWBVtIv0yKule4wNgNYTR1GVt3HonRLDORIAuM/I9 EwZaLN7n6ChaXLntbQghU+DqNVhiFomRris01M4PffIfZbVMgxa9Rr8EAa2DIOMfWby20GbFb/2 SN42uPvVnyuVnSRGbnQBCscMoWGVp2/iQJBb+z9OLZYN+aC5mi93nzSDaOFyP3mBGsPi0X3B3mi EuFuUyWFElwhZNWfYdQN8htiY1D9f9DBQgDsQaB8rRFOHLMbZ3dGrw5A1Ui2hUv2LWvd6avK7I+ 6ND+lMJTSnzJVs/cgAovWauDV7LnYnaRwwS9ENr17bvWE1mhvzGVhj0QFjOFq4Um+iOhaPfnbmn fba/7QI9A44zloyArE0hcSIPkpqzYYfqddVEFyoki7htx2qo1d/7xmDbCnm0UkEeq6zLx30yq4L Ie77o1hLFIm/FR4nhaFd26CD9dYKdPSUHy3rw6PpGl0JrsXaom87KvcSiuEoYBy8E/2W5LvQmtB mG2g X-Received: by 2002:a05:6a00:9514:b0:848:6f5c:a327 with SMTP id d2e1a72fcca58-851d395a3b5mr18400958b3a.15.1787224428046; Thu, 20 Aug 2026 04:13:48 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d36185c8sm1515460b3a.38.2026.08.20.04.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:13:47 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Matthias Brugger Cc: Liam Girdwood , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 5/5] ASoC: mediatek: mt8186: Propagate clock lookup errors Date: Thu, 20 Aug 2026 18:12:53 +0700 Message-ID: <20260820111253.97866-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111253.97866-1-phucduc.bui@gmail.com> References: <20260820111253.97866-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The driver currently clears the clock pointer when devm_clk_get() fails and continues initialization. The clock operations later in the driver do not check for missing clocks before using them. Return the error from devm_clk_get() instead of continuing with an invalid clock state. Use dev_err_probe() to report the error while preserving the original error code. Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8186/mt8186-afe-clk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8186/mt8186-afe-clk.c b/sound/soc/mediatek/mt8186/mt8186-afe-clk.c index 8cc8eb8022b5..ddd509ca851b 100644 --- a/sound/soc/mediatek/mt8186/mt8186-afe-clk.c +++ b/sound/soc/mediatek/mt8186/mt8186-afe-clk.c @@ -592,12 +592,9 @@ int mt8186_init_clock(struct mtk_base_afe *afe) for (i = 0; i < CLK_NUM; i++) { afe_priv->clk[i] = devm_clk_get(afe->dev, aud_clks[i]); - if (IS_ERR(afe_priv->clk[i])) { - dev_err(afe->dev, "%s devm_clk_get %s fail, ret %ld\n", - __func__, - aud_clks[i], PTR_ERR(afe_priv->clk[i])); - afe_priv->clk[i] = NULL; - } + if (IS_ERR(afe_priv->clk[i])) + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]), + "failed to get clock %s\n", aud_clks[i]); } afe_priv->apmixedsys = syscon_regmap_lookup_by_phandle(of_node, -- 2.43.0