From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4FB5419FDF for ; Thu, 20 Aug 2026 11:14:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224476; cv=none; b=p064YW0rV0/Mq6DTD/OvD6wB1p7oGb66UtRn2VaocHslm0kT/9YAwxautbzA884ox1pLadKKflppRuVj9TV7AxA+ndOhQPwwdV1mHj8vKZjfnIDgjNEhlc7OkY37wAZbN85VJRKDOQ+8nsUWhQ4lfGam0ohokhcIROteJSMw+mc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224476; c=relaxed/simple; bh=0Kx8Gd725wpyS63x5QxMhg2JWPdRrXuRnIUd25tfkeA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=P/YMlajz/ptjnF3TMxcEccj/M5fUvws3Rzo9tAtDz/YKOPVjEb7sLdGlMUjQKV2LiDvaJUfAGs021Pl4NtGZlxGbLnwon0h0oTBkp6BAaIph2sblctocDEWYmotqWWpddhMRmGzcAz1myUazBPUDGUawYbrJEP91Q2y2Sz6q78E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eTiJcdWF; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eTiJcdWF" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-38e347638adso2229018a91.0 for ; Thu, 20 Aug 2026 04:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224474; x=1787829274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=uW/q9Ab1Wexm210w5L+2fH7SlAGlBFRAkle3jNwLoEk=; b=eTiJcdWFKYOOOHpzX1of7WTNClMG3XbuzzAt/hFGrNQEvIS2kFX3t4N0SESQAWQcyT rIqqr5bGSGun2dr1TJZC0eEesFmGpxIBU7DxvkgBRHQ7FW7KyyS7ejGovDnPvKs1r9yv GgnUlfowrCz7c0tmkscbt+csgGi8LIMLj4uBZbmVwId5Cfnjtw2TQEhZqMc8VyJbmaXm eq9kgpGx1nPXgfptZlVoDFD3fjYP0w2441CBSd6oqeA3hdyKIaTlsjTg5kx5K88j0tdK DFyojIL7a2MYWAgjfu+4vxJNXfJosxGG9kZTGhe7j1301HKOZE2b8QFV7Eo2V4VksRGs DfHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224474; x=1787829274; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uW/q9Ab1Wexm210w5L+2fH7SlAGlBFRAkle3jNwLoEk=; b=JsNa9Duv4JB85HLV32MGIAkJxMddbJSsw16UI3ACcNWket1XF8uxdzVU1veNqzKrvS NHzypqLSs1BZ8DzNr8cLCcjnrsEOO4103dBSmzyvVD95WJioD3Iy9x9wVGfA7pkHxi25 LqypU6gPDle4CRJPK8B+CsHI9fxAnUMwkoPtI4HUIiubwiSf72xOJTMc9dauXbeb/HM+ w/Ppdznx+sXK85xoKamm1m90ZOOkBY+kxxjQuWjA0twT4to0fTMpROj/lxAvzd4Zurn8 HFGz6SBns+F1tglg84XXuncAt+V0cfsWCWZOQZuO31F8OCQKPYLOK3Xp91emGWL8UvCJ avEg== X-Forwarded-Encrypted: i=1; AHgh+RpJk2gtup3QlNg9/TPPqekno+t+y5bnu1jBsGv+7HMa+bc/5HL21VA4deCPIJn+YWY6ZXngmkP7nPyH1AY=@vger.kernel.org X-Gm-Message-State: AFuF++nX1zVBtfcuJcI/HXzyu9KjGrnUVbEX7ZfRaVHoQbcSQa/Xh+0m 00TF6WJWlcXfAMiqoktbj45Ivtc5D+QXBKrYmB0/5pYB9qLYz7ER32y2 X-Gm-Gg: AR+sD10CCMzgj+1AXqP7YnF25w/rlmavC16vFZwPWJawJTPKz7xto5G9Acd5ZAmjZQH tagLNZsyl+X7rdD2WgyunxPwishAFUx5T8fXsEqsNOJjAXHq4UqqmEBVErWs1rao1pjkc0/HvtL QwvQ19Q9W61MWLACvQ+tPFqYxzo6N5iHlfH4ppzQ8SBqgC6N+gv97BPm1TBk68wuQmcKDins2yk WjMz/qYWjI2FkWoLA7cX93NsPFlyU3MIXeWb7b4RUz7+hZTCmL0xyb7A7RxEm2utH7MQlfq/JGh d777H/vxHwrqc66r/L75EYZY5mHkAUS9PdyEMHUx5BhUOrGaqN0/7wxIRBnPCF5LZV8TzSaOqxD vT86dK3AQJnojtuWBkKfONvGf4UBzgbNBxaNErb6+a20wTFSs6S3J0i7aQ3vl39JstSO0sToHBk KX7By9sKq918MCXgjAOQjMLs55bGa89tJ3X/ye81MMeXEY6I0zRoKKXrN3VhzhS+KikzUWpC2RI O+irqSQBrtaKc0Z0Edg86oj8y88mfnglydve5H4p1rMqd2CGXEZwxbUXPVqSvYQrHccmOBBYoLM c3uQ X-Received: by 2002:a17:90b:3c8f:b0:395:4de4:92c8 with SMTP id 98e67ed59e1d1-395810e9626mr24040537a91.15.1787224474148; Thu, 20 Aug 2026 04:14:34 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395ada57c39sm719965a91.3.2026.08.20.04.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:14:33 -0700 (PDT) From: phucduc.bui@gmail.com To: Wei Fang , Frank Li , Shenwei Wang Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , imx@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 1/2] net: fec: Propagate PTP initialization errors Date: Thu, 20 Aug 2026 18:14:15 +0700 Message-ID: <20260820111416.97917-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Change fec_ptp_init() to return an error code instead of silently ignoring failures during PTP initialization. The PPS IRQ is not required for the FEC/PTP functionality, so its absence should not make the probe fail. However, an unavailable optional IRQ should be distinguished from an actual error returned during the IRQ lookup. If a platform does not support the PPS IRQ, it can omit the IRQ from its device tree and the optional lookup will return -ENXIO. Propagate other errors from the IRQ lookup instead of silently ignoring them. Also propagate failures from devm_request_irq() and ptp_clock_register(). Update the function declaration in fec.h accordingly. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/freescale/fec.h | 2 +- drivers/net/ethernet/freescale/fec_ptp.c | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h index 7176803146f3..8831da37326b 100644 --- a/drivers/net/ethernet/freescale/fec.h +++ b/drivers/net/ethernet/freescale/fec.h @@ -692,7 +692,7 @@ struct fec_enet_private { u64 ethtool_stats[]; }; -void fec_ptp_init(struct platform_device *pdev, int irq_idx); +int fec_ptp_init(struct platform_device *pdev, int irq_idx); void fec_ptp_restore_state(struct fec_enet_private *fep); void fec_ptp_save_state(struct fec_enet_private *fep); void fec_ptp_stop(struct platform_device *pdev); diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 56801c2009d5..8ad680411b0c 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -736,7 +736,7 @@ static irqreturn_t fec_pps_interrupt(int irq, void *dev_id) * cyclecounter init routine and exits. */ -void fec_ptp_init(struct platform_device *pdev, int irq_idx) +int fec_ptp_init(struct platform_device *pdev, int irq_idx) { struct net_device *ndev = platform_get_drvdata(pdev); struct fec_enet_private *fep = netdev_priv(ndev); @@ -779,26 +779,29 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx) HRTIMER_MODE_REL); irq = platform_get_irq_byname_optional(pdev, "pps"); - if (irq < 0) + if (irq < 0) { irq = platform_get_irq_optional(pdev, irq_idx); - /* Failure to get an irq is not fatal, - * only the PTP_CLOCK_PPS clock events should stop - */ - if (irq >= 0) { + if (irq < 0 && irq != -ENXIO) + return irq; + } + + if (irq > 0) { ret = devm_request_irq(&pdev->dev, irq, fec_pps_interrupt, 0, pdev->name, ndev); if (ret < 0) - dev_warn(&pdev->dev, "request for pps irq failed(%d)\n", - ret); + return ret; } fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev); if (IS_ERR(fep->ptp_clock)) { fep->ptp_clock = NULL; dev_err(&pdev->dev, "ptp_clock_register failed\n"); + return PTR_ERR(fep->ptp_clock); } schedule_delayed_work(&fep->time_keep, HZ); + + return 0; } void fec_ptp_save_state(struct fec_enet_private *fep) -- 2.43.0