From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B5741A55B for ; Thu, 20 Aug 2026 11:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224481; cv=none; b=MEaVExXQTMCWwZSHYDOXcZwXY90ZxHEEr84FBIxWxa0vYhylDRflcfqT5JutcHn32zQmcpo6Hejy9GyC7BpG8HTcaXRD5CIjEK74E+j+Xr3xw2UPqv9fPv9jOMh5OezN3fIJrAYmyrSjkVWerBzTd8WNr/3mgYGOn6DFLwEvuMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224481; c=relaxed/simple; bh=ZdtX8xsbh4lQi/ck9/fe2r/hcaarQC4xCPivdR8GLbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vBalFMWAoFIivOiCgNBhzujTKilCgDJcEKSD45DNyyu8fJNel0kIgsrgEIm76CCkMR01+pLagrmqRuk8rlC6tD3knlTTxC/OKsv+zVowwTjk7H/7phkDSDrDgzt63V01BIz0UPro6XpmUrCuOadTf49+FlpueRpa9yLYdh+hjNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dAtCVG3D; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dAtCVG3D" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso1979024a91.3 for ; Thu, 20 Aug 2026 04:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224480; x=1787829280; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aa8JvoP4ttlAqARvv1+FX+80Og3e2TOWzjjuAVcvE4k=; b=dAtCVG3D3DxF951n4lxmzQk8RQi4gC3qu1IdSCONOqssA65WifAL9DSY7hcwASJ94K ss4gfrzGe1Rgqg4ofLzkmn0nBBibDX3HbcC2hnpJrmxryGWyUCwYBQzvbeY9Yo8f9qIb GUOl4YyfjOnYFjK3zYQ46NO8F73DEZXLNrhGeQ3ZAgFMqDp0yn8RUlL1FL7+yUZ0qZnI us/f3N9j41/m81y6/PPdP5QyGO5orkFYuJYVWKh6NsJu2xUKab0bAAe25oxE7hCY998D 0yvbd5z1bN6tbcJcWA+QxB3wriNBgfw3QMaXSjhp9RaCXpqgnX8nTwUMKDhlKa8sZ4bO 4m5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224480; x=1787829280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aa8JvoP4ttlAqARvv1+FX+80Og3e2TOWzjjuAVcvE4k=; b=Bs9t7Bhcpvlwrho6pZaEbNh5wPAgyI4RK2oG/sRyEw9k5hRivnq9x5MZgFyLPOZ46J Y1QB6aPHlNFoa4EKxD5D4WbVD5IC/LuQqJS7t/Rcg+XcdjcUFszf0JIxmTd89nK6t5CH RGmOXwBQXDDNEBkIhVsgY88T+1EYZEkCKwE1CpYD4x49hIUG0sr3bXZKBi7fQ/QqCAwE hmPhaUl5H62VT3OEnZbpUh/cpZDW8jD71QArnEk708eBAkONs4Uob8gOEwG97qojsPVr kuxeT7w5oxEzAxwd5v1KAaDjCb47A4870kYsO9DsEYNbbwNMkRKvuC/L+dAR3QdUkmBc JG7Q== X-Forwarded-Encrypted: i=1; AHgh+RrOZkJl7F015O5oUjwPjDksPz16w72CL+YqkyZDrOQECXREZ+39ngidF1UqWo3wHO2jZXDjHpWzG2Bsrd0=@vger.kernel.org X-Gm-Message-State: AFuF++mqIxQq0e5JbWVElEiNeXDX01Pi+vzWfeDv4ryVsCvNlgvM45M/ Fa2oz5EMcpsw23DP28+ATx6m1R7HEWJC3x6rKKP1+T2QQzvEGFUcx5Tb X-Gm-Gg: AR+sD11mHAodqMmZ7dPZt5reQcam3U88pPGzrQWMjsxCKjjPdbTErCoPwxNygOapB1g KhoX1JGU3srOBDE71GYRNlptT49g8XPMLvbjqINPb3emTxOV9go85GnIXgYP0JXWyZVc42HPrKQ Rn7Nzo1Z5HqPHPB3WTmg3vgFaZ9772AvctGoZwAgKRI8zHCmMznaDU+E6mvLsX+izfO3nIuYoJc vOgRpmWHEmXEQUORI3yRsgPe+cdNy6k9bi1E2i9ZMALJPU+nRoQWclRdu1vDpiow2W86wxrudkS 0xS2PCntFxWSmGG9iFFm8vU777hTZgGVvSeFo/RqyupjSVixCea36UJkq7nnoF0T9HvWORqkwb1 Vw3keoyusqx4WkTPpwcBaI247s1A6X/l+oPQnhlkLXNjZuRrPXaYwW45LnJrhBL+U4UjcLysipc 82hOSeftxDRP/oQGWKdy2RyhADqR+sOu+z+Un8v5sk58wSsWv5s4WfrlijR5X1Q/ObHfIuY2vPH EqtM5PCKm1GRTDrshsqIncRlJE+AM//h0q6ocj5xi5frEdAxxbdeFU98AAeCKouxadoB/jskOaK BixO X-Received: by 2002:a17:90b:2e42:b0:380:fead:448d with SMTP id 98e67ed59e1d1-3958109a525mr23538513a91.13.1787224479729; Thu, 20 Aug 2026 04:14:39 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395ada57c39sm719965a91.3.2026.08.20.04.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:14:39 -0700 (PDT) From: phucduc.bui@gmail.com To: Wei Fang , Frank Li , Shenwei Wang Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , imx@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 2/2] net: fec: Handle PTP initialization errors in probe Date: Thu, 20 Aug 2026 18:14:16 +0700 Message-ID: <20260820111416.97917-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111416.97917-1-phucduc.bui@gmail.com> References: <20260820111416.97917-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Check the return value of fec_ptp_init() and abort the probe if PTP initialization fails. Only call fec_ptp_stop() when PTP support was initialized to avoid stopping an uninitialized PTP instance during error handling. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/freescale/fec_main.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index ced4dbf8cd90..b6c22d6c1e69 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -5384,8 +5384,11 @@ fec_probe(struct platform_device *pdev) goto failed_reset; irq_cnt = fec_enet_get_irq_cnt(pdev); - if (fep->bufdesc_ex) - fec_ptp_init(pdev, irq_cnt); + if (fep->bufdesc_ex) { + ret = fec_ptp_init(pdev, irq_cnt); + if (ret) + goto failed_reset; + } ret = fec_enet_init(ndev); if (ret) @@ -5457,7 +5460,8 @@ fec_probe(struct platform_device *pdev) failed_irq: fec_enet_deinit(ndev); failed_init: - fec_ptp_stop(pdev); + if (fep->bufdesc_ex) + fec_ptp_stop(pdev); failed_reset: pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); -- 2.43.0