From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606143D7D8C for ; Thu, 20 Aug 2026 11:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224524; cv=none; b=guOPIeinsq4R3//vEsy+/PbyGKRgLLlrAO28nGrzV2sEuxJIcXDVg4VtcZSOfv/fmwhCNqfewMGt/LOdGUkUxCHhR618jfPmdbNsmBGavgr8XefnsWullb5KmSD0C9nOqT2ke+YEnK19HEUOab3zZZAn6pWz4BJ2/KICj8pgxrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224524; c=relaxed/simple; bh=3uDE4EBPIrEu/wlRDQMGu8LdJv+K8TTLdEoIbXB62jY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o6rntf4WKif0rXeSp6q+VDbd+s+z6eJ7/RFHBdIA0H7NNYOn03AIhIRm8LFYh+XG4lKcza7nTvlv/JCjPsvJztuFV8HaCNLRPHmSQbqGLxM6hWMXHGIp0aRysd2vYW4Lv890HM7DtIsa462WrWiVkNlx+BgQeXD+eylZLId5TmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qedqFoz3; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qedqFoz3" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-cbedbaba5fdso1080596a12.0 for ; Thu, 20 Aug 2026 04:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224523; x=1787829323; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BpV7OrLLJSmZ27VksgMp3lb1FLdxWSw9DXcxUIDAfzY=; b=qedqFoz3rN62rk457GrvMTkSFB4v2rMlmJQ7igPidq5l9IL5b4woOq5+/e7zSjW91c GYWkHAe3+XmPZ1xEmJhLhRnDy1dZNCyvdw4qiCuVdrj1+OsYF1kzfoQC3hx4D7j3UwJc t8Kmkh1XEiF5grSS5TQU4AnHvSEMayWJN29WaPH23ksr4b9RxZGLLApbRKYShNquf+zG 89uEX4A0txhntiPhjbBxOa8HoE3zj5CMbFiP6o6sKiOmiE4q3TAqjZGJECOHqVFKiCtF su3Qnml0Ce2EoQYcwNFJDqwH0p7xwS+wvJIBnrmbD10FaEbZ2obzDOHYGNPZBzAUNyc8 X3wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224523; x=1787829323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BpV7OrLLJSmZ27VksgMp3lb1FLdxWSw9DXcxUIDAfzY=; b=chityiTFpvrYZ7lehXAlfYv6PlTrryyqwdFTQ6Y0lDFyIkdrzYECc/D25vGvTY249Q JzxX1aFBPX1KgB8n4bdM2269tympV2zzmPcjD9yULQVGP4juu0oQ2jqJPNGJpwCPom0h vvvy9EHhJZ/s8kRktnh4/JEWHVBQfIWRW5yDEhR3l5M1icHi58K+6bjATsM5Q5hVzUvt i6lpuGKw5kFEAY6bQ17lM142n8h7BkjTd3IPBQt+V0JMebDugZxHGiOa5mKllnwN9tnp upe2+gbEzRvb+Xwe0dPQpu6SVWEa0RhIqF5PfKve9jprHVTDtrC3NOTc3OAK8dcFK751 2yhg== X-Forwarded-Encrypted: i=1; AHgh+Ro1OrVH2Kuen/F3AlvPXQZgTeTtpZXfENg3WkVVnrMVuuUC8W2yBjgg5HRRUCmbOB49Ylzi/iusLbiLb+I=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4loUKc8cKrvkkYBFGBbMxnx6VIqsqLXd15XUZuzdphilBqkfz cuZCyH9wrXI6GjJ2vavknZc/UJ0PRs/R/Ol4zLMImZiFhtPBva/RGryV X-Gm-Gg: AR+sD13nuVVv/m2QBudOSpykPPG3AhO9djLQ9MFKXykhxUrqPTcB7RnXeTX8Pb1pdts jha0F3yANQuwdruQtHnqn3bUQep4vXZagxtwRZsCT/WWBx1ghuVSl/xlOdNf210YpTYmb1paQCs rBFfazBzZJeYBO5CQTdDilNvNqwSWq0u5h+H3QS36GOcrm39ukp5dyU5Kd81V+E7/1KsNUqCpSN Ha1Dxa/qHO53TWvXDYoa9i8LoiIFZ3X9N6NqrXNSgURnidVuvmybuqxSHlhd2SMYgC7uwD0o8/3 kjd614nnL+LqQbt7Mluv+zC9w7k09U0v0zhTwrVxeDd3xLSfLDGya+5oukf9jAHSVCLxIYJWRAI dWiYmfD9l93wJeigdCrRX9Y27WjENQY0iZ8l/nBkHEMvaTHmv4vOp3qed8FqNnkvNHoKix3vpUy BLj6MMgFAJzSbLIwOfp5BQD2in8AB3Wr+9ouSMkV7ZLHOmFz77K6kR93bZTj3umffr96/GJQw2f mq//rt7IV77opKjRWorWehHBI1cYxebpThzRNosKXl24SxYtFTBHSD2pprrDaR2ghWg1oBk/i8d mgtiqCagDg== X-Received: by 2002:a05:6a20:2446:b0:3c3:b57b:6459 with SMTP id adf61e73a8af0-3cd0107f1eamr23055896637.7.1787224522634; Thu, 20 Aug 2026 04:15:22 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568c722sm1676503a12.24.2026.08.20.04.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:15:22 -0700 (PDT) From: phucduc.bui@gmail.com To: Justin Chen , Florian Fainelli , Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 1/4] net: bcmasp: Use platform_get_irq() for IRQ lookup Date: Thu, 20 Aug 2026 18:14:53 +0700 Message-ID: <20260820111456.97947-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111456.97947-1-phucduc.bui@gmail.com> References: <20260820111456.97947-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The platform_get_irq_optional() function currently returns all negative error values without distinguishing between the case where no IRQ is available and actual errors occurring during the IRQ lookup. Use platform_get_irq() instead, as it matches the existing error handling by propagating any error encountered during the IRQ lookup. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/asp2/bcmasp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c index 972474893a6b..d66a8bbd6e38 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c @@ -1094,7 +1094,7 @@ static int bcmasp_get_and_request_irq(struct bcmasp_priv *priv, int i) struct platform_device *pdev = priv->pdev; int irq, ret; - irq = platform_get_irq_optional(pdev, i); + irq = platform_get_irq(pdev, i); if (irq < 0) return irq; -- 2.43.0