From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773BC40EBB6 for ; Thu, 20 Aug 2026 11:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224528; cv=none; b=e/6desTGS57EiIvCdK7dn0tC7Fbtzy3mWkZcGYliADokZg/xq6xQwfisulLY2My8ZcO+sS69sgi7jOXBwqC/KRcKd0icHmu8v4ALQgIhUHCiHbK3oOqrgMgmxiwuM30M3iix5gMD86Afs4mS8pqhAyhlLISS3JQ5dGZjdFQ7F8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224528; c=relaxed/simple; bh=bnOez2D7W1xADEeYSlrlChjQSRZM4eKefXSq81oer5U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EYfGC0s7FSoBbf66csxA5SjnqkJi8uL39P5AQ86hIcQqRQ3vb8gpaGErbiC6j+XJ0z8EZgcC3AZA/cq9ltBZIFO+Sl1vxTGFsdNWih0XFjy5xQvbfVMUlbSe7hEOZg5GdsKRnuz+/UAt+d7xm58nIuuDj0P8vYN7OWbDRZCzo4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aJKFpWqA; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aJKFpWqA" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c9d1fff21edso1373120a12.1 for ; Thu, 20 Aug 2026 04:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224527; x=1787829327; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0EV4ghgeCZRM5rzTYzzjwsX6ZmAWQhJnMm9mekXvTWM=; b=aJKFpWqAKakPkQJC+b4Qf47S8gAU0AqtM4dwYAwgz0caF5GLBtx+M8b8hqNe739do8 MFuwJ563FGAoeDd4DfKPKJMH+miUgHFm4WY9fDBZkxvQO/hCVs3JAoPQfSCQemtHsSrG GBnR/YIj+1s7kZi8x5kBOfRGnpSw+OnhwinyQICY/uftwqj/1OOLd2/O+T0nymyyqDqw rr6f71ZM1SR58xReT9vGPeNazF14aqE828Rt0CgaH1qgIsqfhRLjRLq2zC93STsmnFXj 61tIiF6dT83TH4kRJWg33XTPhXPhzAypfTbt5FW3omP4zaq/8Ap7wErapfCGBa1JYhOl hpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224527; x=1787829327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0EV4ghgeCZRM5rzTYzzjwsX6ZmAWQhJnMm9mekXvTWM=; b=MyD0mq9arcdsbjKkUfbbnhZm84KGKhoXAMEOpfOpm8m0iPO+AMbxthePgD1U1XWKM2 oZDSIbKRrECoheXrOMfjixazKu1p/yXw0LLyKZJYYYRjLWpLEKyI0WCIvT4QkaZQdBOR 1f6k5b/s9KqDZbbOKBNGnJNFb39PVMAIP4l8Rdt/hZlVUUqEfjQRmlarooz51e2a64iF OqiOUXyht9nshxrcYL75aryBA/RlWFFeuqHIHrm3Z0cPe6HiXSKgVdgbzG3uNH2JEV+L MUY5DrsNh5XVAeF0euEaT6d+JkDr5OWYLjpWYHPVoojqR2nYJc4T3yRSABLQm95y64yW tEWw== X-Forwarded-Encrypted: i=1; AHgh+RrHahNBTvkXBrG667NwqIYRfw6XjGSUmP54LakX/14lmMljoSjnYOPOps03VnQWwIz81bfiIIEFBVOrOB8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyobawhy3R+tfnOAS6+keOXCetmJ0KX5Zg2982erBAPSisOR5If GZkcNAiO67nUUjuAGOYzoqygH5XNqBXaUqYpVQDIY3FSMVUPW2QrtOWy X-Gm-Gg: AR+sD112wlVzmJ2OMa2U+D+go0QwlNIo7EoEViFnWUIg/mHtxKWFBynJkMzGZD4tJpG EpXQL783G+At9tC2aJswdqQKzkYxArp37XgHw12bmHd2AeAnlcdoAt3T/pQo9okmcCN8tJ33Tmj J4VeTgy7/9aUnOB9UWoR1o6j0HiHL7s41cdUv2CO1uESTTLd7kOk3X7TkZV9h5kgEoHILLVejpg HFPJjLD5bpJrAOCXmCeNhdko22lEU9yakGE2R9swdWqMJc8sWTsS5wJIaeDhbOnwSXR0npvLRnO HMPwjJiX4Bxw2/hEymw4oQGv8uJd0kUxCr0v+7w/imVNsRCfoSxcuJ4vJ9QApWaGXb3ZOgaLZrP aYtZw/Rcqgndd9ax490Q+sw2iGL2DMaZoLupH9u0bj1KoJS8FpX6NGSo2H+4u0HtlRJ6Z4bUj6h 4cbdO7FE05EJbeUVwUaAJ9HBbo04JeUjvszMnfV+THiFRvbzBOPChLzOJlP+lQy+ri/FBwHtKRO LbdZcSf6tCQHkGZUPugoSAR116FWAl1Cm7u0bHRmJuOOvpe0ZvVGFuWRoQNDZbxTJ8HYjCjdDr/ efcM X-Received: by 2002:a05:6a20:2443:b0:3a0:bc61:62e6 with SMTP id adf61e73a8af0-3cd010d6404mr21262791637.8.1787224526694; Thu, 20 Aug 2026 04:15:26 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568c722sm1676503a12.24.2026.08.20.04.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:15:26 -0700 (PDT) From: phucduc.bui@gmail.com To: Justin Chen , Florian Fainelli , Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 2/4] net: bcmasp: Propagate WoL IRQ errors from probe Date: Thu, 20 Aug 2026 18:14:54 +0700 Message-ID: <20260820111456.97947-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111456.97947-1-phucduc.bui@gmail.com> References: <20260820111456.97947-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc bcmasp_init_wol() currently ignores errors returned by bcmasp_get_and_request_irq() and allows the probe to continue. Return the error from bcmasp_init_wol() and propagate it to the probe function instead of silently ignoring the failure to initialize the WoL IRQ. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/asp2/bcmasp.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c index d66a8bbd6e38..02e88adf4939 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c @@ -1106,21 +1106,20 @@ static int bcmasp_get_and_request_irq(struct bcmasp_priv *priv, int i) return irq; } -static void bcmasp_init_wol(struct bcmasp_priv *priv) +static int bcmasp_init_wol(struct bcmasp_priv *priv) { struct platform_device *pdev = priv->pdev; - struct device *dev = &pdev->dev; int irq; irq = bcmasp_get_and_request_irq(priv, 1); - if (irq < 0) { - dev_warn(dev, "Failed to init WoL irq: %d\n", irq); - return; - } + if (irq < 0) + return irq; priv->wol_irq = irq; priv->wol_irq_enabled_mask = 0; device_set_wakeup_capable(&pdev->dev, 1); + + return 0; } void bcmasp_enable_wol(struct bcmasp_intf *intf, bool en) @@ -1321,7 +1320,9 @@ static int bcmasp_probe(struct platform_device *pdev) bcmasp_core_init_filters(priv); - bcmasp_init_wol(priv); + ret = bcmasp_init_wol(priv); + if (ret) + goto err_clock_disable; ports_node = of_find_node_by_name(dev->of_node, "ethernet-ports"); if (!ports_node) { -- 2.43.0