From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78FC141B8D0 for ; Thu, 20 Aug 2026 11:15:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224532; cv=none; b=kaZR+9rs8P3an0DKcJweivYMOET0jiSkxCenQ8EeLZXzNA8ga61LKjJK3/s+QBjhd0JjcEXXFELgfKGD8F8L+ATcVx/2EHX3qKP1ThPYUH1aPhrc5/g1mbATXU5ye0K9XsioRq6QXbt9Hm9vjUKwNQLYJLJO3BC7hAtj1jZuQAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224532; c=relaxed/simple; bh=o5CuQsLtqAHkVCYO0+td7xiYDLntqu61PDPsgViuQIY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cl1SBvoNZ0eZ2pekEKGuDDullHXP5j5aBZdRVDi6+2oGvGF9m+5uODiS0Sxm15x2K7Y/clzg4TZox5eNK5XE1kFO7vXjERwBkww9MJm9gJTNlq/YuKzLESZOSBjtqxB1KNNLSIbfkI38MOP4gSi8Wjlrk7GkkpIC6Bm0aQq7Xp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=efpxZWKj; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="efpxZWKj" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cbedda4c154so965856a12.1 for ; Thu, 20 Aug 2026 04:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224531; x=1787829331; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kXwo8eezAKAf2A4o/+O3GLjl9XPgejnrObTpGultTzc=; b=efpxZWKjmdjKc8Rgl4dBxb8pRxaF5owqeizHklNX3qIps4/V/E+yHT6K4fCdcXzKT8 5VPOigTn7Q8QD7dFe8uVldtFVfHTfDNURJgj/tvvciQXRNB8qlxowzReqgS+nr1wZT0K cWmlplD+y6xdIAl3iFiMupZQUHPQwJPt4bUxDXthshme4QsyGZbfH6WIjq7pcHlb4ZPh VegLNLRE8AjsiKcG3b1FwEMih6QvDMhQe6Mifr/GgoMmPmRzI5WRc9QgpFI7qZmK6M4v vwRHFK1BUKMkHoil+KH3jNAg0FWe6ZUQAFlhmAqeKkcvJ+SfgOhKEBEdildVoObr80x8 257g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224531; x=1787829331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kXwo8eezAKAf2A4o/+O3GLjl9XPgejnrObTpGultTzc=; b=iOGoTWUeGukX7DyLIS9IRI3RDDLexWhCBsxzYQ+X6FJEANB1YigXHrqMg+ENTjfnyZ EyuMZ16L0kbMNbyC+LtHA6ZIrM+xMRcmvoKfnyUtVzmMQGxkH60Z+w2p08ceZ8mFDbGT YrqFNZp3dG9dmEebdpD9zUVTaW4P4mhKhclzV6C/rMn6D8fUOEtz8ERxYRPgt1WE3+WZ TxQWDmPMqYoJw03aEEuYTpX+msGO19qgyRToyIEBpO58+WuxMuMeHItGWiOJbXEUZEZ4 XhV6KYaP19WbHvG397miju5R7Eqi8PYgLb1yuXBG9JFTe5TU9ekAEbi6BtrauYfRAcQ5 SZ8A== X-Forwarded-Encrypted: i=1; AHgh+Rp3LMUsomzlXRrf8503I055ozktE1CFhUy/7dpvTojjRBvOQJaRsg+0eCZRCNGNt8L0FBfOBK+8GPCCpNw=@vger.kernel.org X-Gm-Message-State: AOJu0YyEut0A9W2VRhKMSHP99ZzfADbvM0T2Nw8yuLAQNIZGLnwXeUXU +RiIEI8uheEvoV548/KNQKtBhmZ18EhruydblBRj1kcvlpoUp6+XJkh0 X-Gm-Gg: AR+sD12Jd5kV7Vf9dwcrBGV4q3l+yvQeHxHrOsqpL5DptNOWkl550ZVD7fRrLVfWU0a qGB7v9h6klid54lEu1tFE0LdNmm3s2pxEU2f+ALfAL2juO8Z6IEMDNQbrWVFujLdUrIXZPGa9hi 3arGtbGaGTelg1w2PvwVmLB9YLlJxwodJ02RpFqOBRvizR4p3eI3zuZxbTgpNbXUzVe5sLwKLAP wicxF+i+ZFo+3g2PCXJ8+Txvmf5dUXlSHbtNb/IvoFJn7x2H71Eg9eyF3iGFnMY49K5qM7S9Lyi tLuEhfT1fhPEaRaxoNiErcWyCoucvUNGpM2srDUg5mROn8F7Nne6PGk2NX+7R8ziHVESq+vJsue g1W8k1YA8MD2SY0p26Z7s1uaCz/TdxqmidwfdEXdc0XXd18+PPkG5VYy8JBSCACtD3mFuKyAooy aulKz6DQxbcahfUHNCJgKEnpM9nYNU6TRqfTW05fPBo+KhgMEj3MURJr3LU+9zelI5ZehxSmfNv b2AW+m8i26K+Mcb4p6wn8oKVVkgIXkGSAKwZIJGaUshDkXGdiYMx4wx0+Uk+apwO7brjQyXvUR3 xxZ+ X-Received: by 2002:a05:6a20:3ca1:b0:3c3:66c5:68d6 with SMTP id adf61e73a8af0-3cd00f77410mr21961884637.9.1787224530717; Thu, 20 Aug 2026 04:15:30 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568c722sm1676503a12.24.2026.08.20.04.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:15:30 -0700 (PDT) From: phucduc.bui@gmail.com To: Justin Chen , Florian Fainelli , Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 3/4] net: systemport: Propagate IRQ lookup errors Date: Thu, 20 Aug 2026 18:14:55 +0700 Message-ID: <20260820111456.97947-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111456.97947-1-phucduc.bui@gmail.com> References: <20260820111456.97947-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Propagate the error codes returned by platform_get_irq() and platform_get_irq_optional() instead of converting them to -EINVAL. For the optional WoL IRQ, allow -ENXIO to indicate that the IRQ is not available, but propagate any other error returned by the IRQ lookup. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/bcmsysport.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index 4d06c6ba6641..2acaffccdb08 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -2499,14 +2499,22 @@ static int bcm_sysport_probe(struct platform_device *pdev) priv->num_rx_desc_words = params->num_rx_desc_words; priv->irq0 = platform_get_irq(pdev, 0); + if (priv->irq0 < 0) { + ret = priv->irq0; + goto err_free_netdev; + } if (!priv->is_lite) { priv->irq1 = platform_get_irq(pdev, 1); priv->wol_irq = platform_get_irq_optional(pdev, 2); } else { priv->wol_irq = platform_get_irq_optional(pdev, 1); } - if (priv->irq0 <= 0 || (priv->irq1 <= 0 && !priv->is_lite)) { - ret = -EINVAL; + if (priv->irq1 < 0 && !priv->is_lite) { + ret = priv->irq1; + goto err_free_netdev; + } + if (priv->wol_irq < 0 && priv->wol_irq != -ENXIO) { + ret = priv->wol_irq; goto err_free_netdev; } -- 2.43.0