From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A372D41D101 for ; Thu, 20 Aug 2026 11:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224537; cv=none; b=KDrmaYsGvuNebE8x06m29cQrfOmEuJ6rAStQlixvgkV9nKHhXk//D+knLO0XOKYPLUUn3WNu5fRldpIF5JtojSGN3AmrjZEWrMs4LTIW/1WK2/b97CxTchypII9wDP7UqCdaPAJyTx07lpNBQB1Fp/6QsN9on26nesuR74mBpUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224537; c=relaxed/simple; bh=1x2GjawIorbw/4908l+ScmK5Fw9DJ/ZcMIgpbcs16xM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WnIy/tL5lN7igv/rBLei06i67hheSD18K+I6qMrOo8vip5T7Ai1PN+ay5NpwX7xZDDcDZ+wVAewFwq3/BoKtXb5OtvKBQk0SZxiPq1QcW8Pvwx6ibmNX/PEfn5/lbOUZhlv0H88tooPYfi4F5I9t/HXeympc56dJXmMJdNuto5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b4qavLid; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4qavLid" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-cb5b8572b70so2118141a12.2 for ; Thu, 20 Aug 2026 04:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224535; x=1787829335; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3splNz+eKCLGRh8XFY3AA6oSixILCEDeXRfbtthshOI=; b=b4qavLidcS7rsxUKMhUFKAXMMRSMP3XCCZc99ChEsGt6Xc2PGmpFNj+mEPxVZs6DVg zCxsbOlr2EJSJWSxvRP2o9Bsl9NPeiNPeRh0T10wg5u1fwNffEmmn8LqLBvA5u5M/svG ow6yC8Spw03t/+5qq2t9rgNXYvmbJayRheO+eAUZzDeALp2K/jIBjIOb69PTV92Hp1oE Nfs0R0lbQXVI0Jw0OYx5E7KOQNri51vYz/F3ERN/0AcSBV2Q7h9ymIeGQP8VeM8fBcpn XNDD8+C4TqjWBHH0lCKB+G291sFBBuHu7Q+uOhEgGWopEWMXmO1fCpRDs/fkem4M9zTE TTPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224535; x=1787829335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3splNz+eKCLGRh8XFY3AA6oSixILCEDeXRfbtthshOI=; b=GQP2Z0Ou257bex3x8hTTf854Ks+Tof3HpFYATyn6TVcr++FnUsXuo+OBaP3mTJ1Xki HZC3qu3l5GUYJ6T+X6aAZoqxRCBrRL1Y7ErgBJ8/2kKbKrpoFOZQF92i/nan501zVaCg K5pBFm2KgvlrAliod+WR+G4FnpCnfLAi85+OjCyJ6se8i4ypLkzTx5XelfGDfIKJP528 rCJHNRko2/9CVNctNz+37hgC3pc8w3dAgb8rw99OxYVrZXzEb0aIb20TvLZ9d86OgDzI 99L1e5RbksEyGp9kwhgl8Jn3Xdb4+Ud7/I+sxVyldZg32t3qvovuseCQ5VBiNBfO5hRB cSMg== X-Forwarded-Encrypted: i=1; AHgh+RrNvC0hQrn70rOsaUM8rJM/wsecOYYgRfncfnKONlsTEGRG0AIPMgy+gzJuVG+j9mWKeNWb74L/ig3DvuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyqAXpriGdXHknAwr5Acn4uqvtQbx3sXDPIZTepxVJ8WiYjopJp cuhQq3bqFfXGrRDnU8d9zmdDK8LPXYI06AanhHIVKILB0IqpWWpFgdkR X-Gm-Gg: AR+sD10ph3qVyqFSQlaTSV7IetSFVNC9e9xZVz3574i1dMKxHGyev2+/m7CvGhYq5JR UHuqUK/gxdy5iH23r1/ROX+Gts4lGY8Rbwm7FdHhB0489z3yw7GpLU3hlYmvVXI2ZFhkxkV+2bD RkXZRAJaL9r8LZoRVbEmN8pYbuMCiyxQQC1p9Vu40BfI4ieskOnPmJLrEYvAKRz0X+9qlOMWllL 0F4vy7tfSxrIGgg7sRX4f8oglCN2ofmPfGr+/I83Q2IT7pOk2Nm+NK164bLmfsodNhJRXSCzSxi 5P7i9ZaBiVByjzpnc7eEdlilZ6DkeU/psdp5I0a/o3GJxvGAXYh6LwPP+/LSQJOvIDu7hIoD7L5 LY+hJfT+xY8CjE4QAyokrUxKEoLvIrldla0wen7dTN0qoCfzP+xhig5V/IFzR8wghzb6MyQhY/o zgHGA8c68K9BIjtHqsjfFldF3nZTjzFmM1iyN6p7v5Js7DE0Xf20sgGtM+V0eWMstvaAlxMAlx6 g9ICbsvTe48ySKdL8bLREXJa/RXK21iIpZERa36FYDI0+eQ4AhSLmhvFhmh6h2YYaWNVmJK3kGq v3GL X-Received: by 2002:aa7:9319:0:b0:846:bc60:5bf7 with SMTP id d2e1a72fcca58-851d3862b53mr23055166b3a.6.1787224534715; Thu, 20 Aug 2026 04:15:34 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc15568c722sm1676503a12.24.2026.08.20.04.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:15:34 -0700 (PDT) From: phucduc.bui@gmail.com To: Justin Chen , Florian Fainelli , Doug Berger Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH 4/4] net: bcmgenet: Propagate WoL IRQ errors Date: Thu, 20 Aug 2026 18:14:56 +0700 Message-ID: <20260820111456.97947-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820111456.97947-1-phucduc.bui@gmail.com> References: <20260820111456.97947-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Propagate errors from platform_get_irq_optional() instead of only handling -EPROBE_DEFER. Allow -ENXIO to indicate that the optional WoL IRQ is not available. Also propagate errors from devm_request_irq() instead of continuing the probe when the WoL IRQ cannot be requested. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index a2305e6428d1..c1c66a52efd0 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3993,7 +3993,7 @@ static int bcmgenet_probe(struct platform_device *pdev) goto err; } priv->wol_irq = platform_get_irq_optional(pdev, 2); - if (priv->wol_irq == -EPROBE_DEFER) { + if (priv->wol_irq < 0 && priv->wol_irq != -ENXIO) { err = priv->wol_irq; goto err; } @@ -4033,8 +4033,10 @@ static int bcmgenet_probe(struct platform_device *pdev) if (priv->wol_irq > 0) { err = devm_request_irq(&pdev->dev, priv->wol_irq, bcmgenet_wol_isr, 0, dev->name, priv); - if (!err) - device_set_wakeup_capable(&pdev->dev, 1); + if (err) + goto err; + + device_set_wakeup_capable(&pdev->dev, 1); } /* Set the needed headroom to account for any possible -- 2.43.0