From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23D2D41DEE1 for ; Thu, 20 Aug 2026 11:16:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224586; cv=none; b=nKb8uyZFqvdSO2dInbnSCz+q4SE4tr3SZpL2HsxdchLCGqM38Gd/C493TL7i/XWYa93JnlruCDWF5kTr0RYg+JbMdondaK4tWzaSOV7QZF2wTa8mrshuv7CWoWDXPakv+GbmHbd9hZAJW4N7ku6KwVomjxecG4cPR6mf+pdP3fk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787224586; c=relaxed/simple; bh=ppue0JSqwEjX5KpVPCrk1v1pQBRDVVORRdtVZNi4u3Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=egTLiU3ebxQICzjefGalu08g7VGs++CaF0fs74gN9Q3oGFS4IbR5BLeLTcbxiEmtJHDoaiUmwEGmIIjqy04EaNFhK9j9+PjBkRV+QUybOtg5ffoyLSQCY/IWv75W67B0jY3eH0p2Jb+BOU/oprEgvOdiQPWuu9J2GgISg93YYXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rPkSKk3V; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rPkSKk3V" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-84867f07d63so2076958b3a.2 for ; Thu, 20 Aug 2026 04:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787224584; x=1787829384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tLJE4MWDqQkE9SdIsVgvMszarH9pKrrkx4zPhYzjrH8=; b=rPkSKk3VQAMw+Vcpoo9/VbGkLvLeW6mBsz8tKFlW0rz099kofcrScwA5pzlksGs6XS Xk2tt6m80eIZEdknba4lvQH7etNmZODpJ7CuOiJsXT7a1VjkBb+iZiytdVlT6OYYJP7J /GTGj897hDOdXPXE8+NrvQ0hW83I7bTY8lSlc/exH0FROPbRDBeAsa+G8ETgiYbHTgCm fgvsO0Iq+bORfq5K90ZEbTTicZ2jnQ63EN3pY+sGCzYAAurXVk2wldP1kJJSETqzD0uk opWSLyV/g1lafnpJe0RDuZx+964I7SYYw+VIKoACLRqL+VirCMgn34ioPKuWZN8se7DG A6CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787224584; x=1787829384; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tLJE4MWDqQkE9SdIsVgvMszarH9pKrrkx4zPhYzjrH8=; b=h0TMDDlpbzUXohaqIM8giS8sYrcodwDirc6ygjefp5z50DxY9rbbAXJ72iQXnYfmil rKHpN94X6kRUfm3pmBK/qWLof7XH4ttetA9d9LjB4hSUXXtb0IP221dgDJHkE6uV6nqi KrjD+Dh0WoDUMuTVCUQujduZC+JKYhRZiKz92CmZdPqlC/MxhcIrnMtpFq4QVI+9X3dF vVbDKCfaVn/GflmVvip8JKWuCuifBvDQIYggE4WlflJ1Hfii/fXDa+mXr7zEab2GJzce ecW333F/MOslqw8y+4CDo4DmdFRzNEPz8LhZg8MJeugY2TAvj1xpTyRp3BQ18aAY6jGY NnaA== X-Forwarded-Encrypted: i=1; AHgh+RqgEUhkpA0R1FpQE2wBfutiTdl4wY2r31Wjj1DEEEU3qQVDsdpn0Oz9Km1RiIHrLQ8lJGJ9E9fMbeRic7k=@vger.kernel.org X-Gm-Message-State: AOJu0YyyrPWBRaNccorYCgPLwiJwLfzrmEXKNw1O5WTNMYf52oYhmgF8 3ctE5UO/UH1iiO0l/PUY4MOAwgLF2u3mg7vUd6X9SfizsPPWcfaRFkjl X-Gm-Gg: AR+sD11v1mcW0R/w1xZhI7m6W5csTx/EhWH7EnjrsvaHVbb8VSILI/rynMmuKiEQOnQ jDaB/KNCdRHud/eATJnW1XO4Cl2LjfhItHNgYbpH2X9bpJoLM94Ypx31ay0UzwUOifqtln8S6Hd ZcpYqcwJNnXXVOs8ZTRIniLd/MBzb3uGQP2Eq6FLfIPJ+UsTNcHG0WEGF0/uraA9RUX9BpB2AAK 2PL1rDYL//tTtcz42EMxGH9TYVcLKCL1oJKzyBcHNVnkePg1EjQSeiGpWmByAh6x5cwZZoNv8Tb X+GzQ3NsY1IIyXsIltg1XnvANKEiVaBlxLRkkffEgatt50UbL/khP14V4zYKNhjHp2c/IOvguVN X4auR5f660RidNPypAyAsITLqrkUk0syTVAAh5p3XdN/OOLHJQ7GmeM3VgToobE7XTAVTuOmLQN 51PSLv7dwk3AK1G4fPixh946fksm5576sTYjMrUyyTo/JAAff4/F556tmaByRyBAYElIwNRLugd p69cxO8TngLB8wmpRn1hpq8TDk4FW9/2aQ80F742pzCFfbKBmK94qvq9EaFqOiW6WpWB+jo3epZ XaDP X-Received: by 2002:a05:6a00:9515:b0:84e:24f:2677 with SMTP id d2e1a72fcca58-851d380a098mr19994118b3a.4.1787224584420; Thu, 20 Aug 2026 04:16:24 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d366f028sm1509554b3a.53.2026.08.20.04.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 04:16:24 -0700 (PDT) From: phucduc.bui@gmail.com To: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Takashi Sakamoto , Danilo Krummrich , Bjorn Helgaas , u.kleine-koenig@baylibre.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH] net: marvell: mvmdio: Handle errors from optional IRQ lookup Date: Thu, 20 Aug 2026 18:16:12 +0700 Message-ID: <20260820111612.98011-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors should be propagated so that the caller can handle them appropriately. The existing code propagates -EPROBE_DEFER, but ignores other negative errors. Propagate negative errors other than -ENXIO. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/marvell/mvmdio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index 2ccb8c8f5feb..d59cf332d1ec 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -373,8 +373,8 @@ static int orion_mdio_probe(struct platform_device *pdev) writel(MVMDIO_ERR_INT_SMI_DONE, dev->regs + MVMDIO_ERR_INT_MASK); - } else if (dev->err_interrupt == -EPROBE_DEFER) { - ret = -EPROBE_DEFER; + } else if (dev->err_interrupt < 0 && dev->err_interrupt != -ENXIO) { + ret = dev->err_interrupt; goto out_mdio; } -- 2.43.0