From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 083A6449B04 for ; Thu, 20 Aug 2026 13:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787231928; cv=none; b=ZALvyMR44wo7liM3+xDu/zW1aYreLEX52zR+7BnE5psgVBFEqH8bwkTfnfYdIAX+pPnB5LdFc4XQ7Ll7vnuzLN9oDCkqimsyv+7peDQWWUrJcHjAtIZ2+G2gmIYsxtuv9Le93IHJL2e9zC8HvAvbmknHv8Uvo780g0fxv3NUsC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787231928; c=relaxed/simple; bh=f/eVcXeoiqfV4jlIqAc69WXM4ZBCO3csmi5dXDXXPOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KMGZtj/q1z6bDfZvRgKaRTbOQCE1KPHA2QIWzxNkbpmLjoteQ+I9gt11DDst6kZCERmtYb3p8ly1suEjGEc2hOuLEBmLGmUBEhdulCULtiVrZkIs6reRAl/RmNhFJYAKXGicBLjRodlFLs9NcWA2h1/tbhTBwRxVpb54TTP2QS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QkQDIuaR; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QkQDIuaR" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4956242332dso23115125e9.2 for ; Thu, 20 Aug 2026 06:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787231925; x=1787836725; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vR40jF9Ss8LmiP9zSaPNfnunPJsok/mkpHKsfsj1AOo=; b=QkQDIuaR2WKegu2Qgjv7FQom99t505tsPoaT4Q+kXMp5E6f+JIP9/Xk0lUFiAoxUbZ 9VtFXzGW8pc+wDMb3lCcjUOxCRdWwA+O4v2s/rkYC9EgR8M+zOqZC5P4eaBwls2tnX35 IRSIQSD6IuRpH0SQL4FMrpd/6l6vszZoGC0zXzt041D7BQDi9+0iZdvPb9GOIOiwqBqo Ne1+mERowikGOfEydBzkFSOsd7WQjakLitEqlc3OAJR3WOIanYIdTuwC7qZL7Qlm2pqW qdvSMjm7/XwfcR2qRZF0y7j0cIXlVruWTEAiZK015pJvnIHjNRvUuHAkob+DLlsk5/4I geMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787231925; x=1787836725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vR40jF9Ss8LmiP9zSaPNfnunPJsok/mkpHKsfsj1AOo=; b=NXqWRzie0LyKDsnhyuYViGinp+WeP6KK76BnBG9krBI3azrEs9btZxsvbWBJiXxAHY CRM7jOseF1PD0I26joIOeopP9N6nhBLw+H7lY9M2vgVkUbq590vrXz4ix4j1VU+ZZnBA mpc65CAEZcN7uqGVKryg+d/qrCmIOqgyaizvjC76OhMHhltuT957T3y21WKyp/B23NNd L52pwmUHUXT+sdr7f6MKoLNM8RlZo2E1u9ivo7E9wF8JX5shgzXOHKkBmx347bmGHOpM F/yn+VhmW9dR/cpbCD5tJFwMfwbee+EomSavoxwHsxmG7LS+U1xzI59zlRkO/xM1Eqa6 5WJw== X-Gm-Message-State: AOJu0Yx5F0/wHN2O3e5BdAjEeEp56Cm6WHaI6rwfJ5Q1O08SCWGo93fN r9CweO4F2xNiu7jvHb4oyJDVmlS8hoWfmrDk6CPUo2vd68GnmbkPEK43 X-Gm-Gg: AR+sD12itep0fXZgRc/Hc3qxfnmBnZ0m+EsXgQinKjLBKa4k4T7D8aljnYdbS/cxxGZ Z/my7pZFPL9fHuD4AabZP7ooLzMJ6i3/bKE8OuvN3Mhs9+ZTm4uT8Py6cTB4UPbQZ5rrq91eSxS ZzvcaEU6+8EE7jZYnjTqM/I3h5Tkffi4Sj2xUIW7PNwYFGOdAOSfGvXo5lMs8wi689iqSFP/f3F oShmPlGlYOfazyiNEe3nWx5DuoCVl42GmC6dhZkGB1gQWo6wUGcAW/xRywqi8hAGkFL4AaXWzPw mEh69iNXxaskDUp6FDRLp+JwxOdZ1TgIyzoSEzcDOQnDKLU41hsG4Doq8Zgn2mlLO7eoY0t+82I XoldR+Sqt4AWfK0dqBiyg0JD3T45QBKZyOAtcrNBDqJLPHfvjn7h3SOl9Hyz1+zNa/BQtz580DP 3IQSXrjQ3H1OhF+cw7sCak7GhNPd2Y9F/4HAR4cjjzqGo2FdegWe8bxfwcOHqEaKsaOnogNji5Z 1ye X-Received: by 2002:a05:600c:470a:b0:499:a5fc:207e with SMTP id 5b1f17b1804b1-499aa17e2bamr164727435e9.8.1787231924991; Thu, 20 Aug 2026 06:18:44 -0700 (PDT) Received: from dell-desktop ([2a02:587:4b5e:1100:7303:647d:7cc4:8552]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa0e473dsm136027275e9.15.2026.08.20.06.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 06:18:44 -0700 (PDT) From: Anastasios Papagiannis To: bpf@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, david@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, kpsingh@kernel.org, matt@bobrowski.net, song@kernel.org, utilityemal77@gmail.com, tasos.papagiannnis@gmail.com Subject: [PATCH bpf-next v2 3/3] selftests/bpf: Test linux_binprm user memory kfuncs Date: Thu, 20 Aug 2026 16:18:01 +0300 Message-ID: <20260820131801.68759-4-tasos.papagiannnis@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820131801.68759-1-tasos.papagiannnis@gmail.com> References: <20260820131801.68759-1-tasos.papagiannnis@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds a sleepable BPF LSM program attached to bprm_check_security to test bpf_copy_from_user_bprm() and bpf_copy_from_user_bprm_str(). Starting at bprm->p, verify that bpf_copy_from_user_bprm() can copy the contiguous NUL-separated argument and environment data. Then use bpf_copy_from_user_bprm_str() to read each argument and environment string separately, by advancing the offset based on the returned length. Signed-off-by: Anastasios Papagiannis --- .../bpf/prog_tests/copy_from_user_bprm.c | 62 ++++++++++ .../selftests/bpf/progs/copy_from_user_bprm.c | 115 ++++++++++++++++++ 2 files changed, 177 insertions(+) create mode 100644 tools/testing/selftests/bpf/prog_tests/copy_from_user_bprm.c create mode 100644 tools/testing/selftests/bpf/progs/copy_from_user_bprm.c diff --git a/tools/testing/selftests/bpf/prog_tests/copy_from_user_bprm.c b/tools/testing/selftests/bpf/prog_tests/copy_from_user_bprm.c new file mode 100644 index 000000000000..1007e3aec054 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/copy_from_user_bprm.c @@ -0,0 +1,62 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include +#include +#include + +#include + +#include "copy_from_user_bprm.skel.h" + +void test_copy_from_user_bprm(void) +{ + char arg0[] = "first"; + char arg1[] = "second-argument"; + char env0[] = "SOME_ENV=a"; + char env1[] = "OTHER_ENV=something"; + struct copy_from_user_bprm *skel; + pid_t child; + int status; + + skel = copy_from_user_bprm__open_and_load(); + if (!ASSERT_OK_PTR(skel, "open_and_load")) + return; + + if (!ASSERT_OK(copy_from_user_bprm__attach(skel), "attach")) + goto out; + + child = fork(); + if (!ASSERT_GE(child, 0, "fork")) + goto out; + + if (!child) { + char *const argv[] = { arg0, arg1, NULL }; + char *const envp[] = { env0, env1, NULL }; + + skel->bss->monitored_pid = getpid(); + execve("/bin/true", argv, envp); + _exit(errno); + } + + if (!ASSERT_EQ(waitpid(child, &status, 0), child, "waitpid")) + goto out; + + if (ASSERT_TRUE(WIFEXITED(status), "child_exited")) + ASSERT_EQ(WEXITSTATUS(status), EPERM, "exec_errno"); + + ASSERT_EQ(skel->bss->bprm_argc, 2, "bprm_argc"); + ASSERT_EQ(skel->bss->bprm_envc, 2, "bprm_envc"); + ASSERT_EQ(skel->bss->data_len_match, 1, "data_len_match"); + ASSERT_EQ(skel->bss->invalid_flags_ret, -EINVAL, "invalid_flags_ret"); + ASSERT_EQ(skel->bss->copy_ret, 0, "copy_ret"); + ASSERT_EQ(skel->bss->str_arg0_ret, sizeof(arg0), "str_arg0_ret"); + ASSERT_EQ(skel->bss->str_arg1_ret, sizeof(arg1), "str_arg1_ret"); + ASSERT_EQ(skel->bss->str_env0_ret, sizeof(env0), "str_env0_ret"); + ASSERT_EQ(skel->bss->str_env1_ret, sizeof(env1), "str_env1_ret"); + ASSERT_EQ(skel->bss->data_match, 1, "data_match"); + ASSERT_EQ(skel->bss->str_args_match, 1, "str_args_match"); + ASSERT_EQ(skel->bss->str_envs_match, 1, "str_envs_match"); + +out: + copy_from_user_bprm__destroy(skel); +} diff --git a/tools/testing/selftests/bpf/progs/copy_from_user_bprm.c b/tools/testing/selftests/bpf/progs/copy_from_user_bprm.c new file mode 100644 index 000000000000..4d7e9002b45b --- /dev/null +++ b/tools/testing/selftests/bpf/progs/copy_from_user_bprm.c @@ -0,0 +1,115 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include "vmlinux.h" + +#include +#include +#include +#include "bpf_misc.h" + +char _license[] SEC("license") = "GPL"; + +static const char expected_data[] = "first\0second-argument\0" + "SOME_ENV=a\0OTHER_ENV=something"; +static const char expected_arg0[] = "first"; +static const char expected_arg1[] = "second-argument"; +static const char expected_env0[] = "SOME_ENV=a"; +static const char expected_env1[] = "OTHER_ENV=something"; + +int monitored_pid; +int bprm_argc; +int bprm_envc; +int data_len_match; +int invalid_flags_ret; +int copy_ret; +int str_arg0_ret; +int str_arg1_ret; +int str_env0_ret; +int str_env1_ret; +int data_match; +int str_args_match; +int str_envs_match; + +extern int bpf_copy_from_user_bprm(void *dst, u32 dst__sz, + const void *unsafe_ptr__ign, + const struct linux_binprm *bprm, + u64 flags) __ksym; + +extern int bpf_copy_from_user_bprm_str(void *dst, u32 dst__sz, + const void *unsafe_ptr__ign, + const struct linux_binprm *bprm, + u64 flags) __ksym; + +SEC("lsm.s/bprm_check_security") +int BPF_PROG(check_exec_args, struct linux_binprm *bprm) +{ + u32 pid = bpf_get_current_pid_tgid() >> 32; + char data[sizeof(expected_data)]; + char arg0[32]; + char arg1[32]; + char env0[32]; + char env1[32]; + u64 offset = 0; + u64 data_len; + + if (pid != monitored_pid) + return 0; + + bprm_argc = bprm->argc; + bprm_envc = bprm->envc; + + /* this is the total size of args and envs starting from bprm->p */ + data_len = bprm->exec - bprm->p; + data_len_match = data_len == sizeof(expected_data); + + invalid_flags_ret = bpf_copy_from_user_bprm(data, + sizeof(data), (void *)bprm->p, bprm, ~0ULL); + + copy_ret = bpf_copy_from_user_bprm(data, sizeof(data), (void *)bprm->p, + bprm, 0); + if (copy_ret) + return 0; + + data_match = + !__builtin_memcmp(data, expected_data, sizeof(expected_data)); + + /* arg0 is at bprm->p */ + str_arg0_ret = bpf_copy_from_user_bprm_str(arg0, sizeof(arg0), + (void *)(bprm->p + offset), + bprm, BPF_F_PAD_ZEROS); + if (str_arg0_ret != sizeof(expected_arg0)) + return 0; + offset += str_arg0_ret; + + /* arg1 is at bprm->p + sizeof(arg0) */ + str_arg1_ret = bpf_copy_from_user_bprm_str(arg1, sizeof(arg1), + (void *)(bprm->p + offset), + bprm, BPF_F_PAD_ZEROS); + if (str_arg1_ret != sizeof(expected_arg1)) + return 0; + offset += str_arg1_ret; + + /* env0 is at bprm->p + sizeof(arg0) + sizeof(arg1) */ + str_env0_ret = bpf_copy_from_user_bprm_str(env0, sizeof(env0), + (void *)(bprm->p + offset), + bprm, BPF_F_PAD_ZEROS); + if (str_env0_ret != sizeof(expected_env0)) + return 0; + offset += str_env0_ret; + + /* env1 is at bprm->p + sizeof(arg0) + sizeof(arg1) + sizeof(env0) */ + str_env1_ret = bpf_copy_from_user_bprm_str(env1, sizeof(env1), + (void *)(bprm->p + offset), + bprm, BPF_F_PAD_ZEROS); + if (str_env1_ret != sizeof(expected_env1)) + return 0; + + str_args_match = + !__builtin_memcmp(arg0, expected_arg0, sizeof(expected_arg0)) && + !__builtin_memcmp(arg1, expected_arg1, sizeof(expected_arg1)); + str_envs_match = + !__builtin_memcmp(env0, expected_env0, sizeof(expected_env0)) && + !__builtin_memcmp(env1, expected_env1, sizeof(expected_env1)); + + return data_match && str_args_match && str_envs_match ? -EPERM : 0; +} -- 2.55.0