From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E00C447CA74 for ; Thu, 20 Aug 2026 15:45:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787240730; cv=none; b=Ua2GhS/yJeGGdhKjR/xIDy5/1ZouYAOtf26YwZNqEb5lxvqxeRxMtuGB0Oir/0Qurrne1P1vrud+/kKu2kAVS4aqXDMZOiil4TfjIf72KmnDAWzhFn5EKwLIe1VP4mRBAKZdg/iIjqfPR7b2CkRqtgtDe8B9nc+xRXgXPHI6j4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787240730; c=relaxed/simple; bh=tEbIqJ9ScsXQrpZQUUwhzSLwBjcVgFFowcmVtrPMKkE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SEn/K/qGMbBd0QnWvPB03FK4Yp3OYPLpDwT0wSuhvWYR0fk2H1rNvP2T7d3HoY55DXKDfTPy4S5xCpGY28Lh8SZQWiy9MpWzRMh1S9X/bTFVlHVJfk4VxOnxjY2tXBnIvoUKJzutb+dlXrYIYpESno4APqK8914OFtPjw8lpidQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b9p/61RK; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b9p/61RK" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-499b02fc590so11109955e9.2 for ; Thu, 20 Aug 2026 08:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787240714; x=1787845514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=a1eX4DFVYT+BZd7oT7NYu1d4HaTZbGISixdfKYs3hNE=; b=b9p/61RKieSGCxstUo2u1RYhbYAgI7JKIbKqtF6X6sxt4EYLAdM04YGsZ81jvnkexK 0mObEVDgz5CfS1WQ6pNc2e4Ing63seVdsKUW0U7cTs5BGCZWgz5xqrzFldcfRecQWM6X eCF8dJ/dqniqQ0Dn5DFgmposO7VzdKi3q0263+berpHi8go1Q11oeIPFLN04EZGshyfd 7ghV66/tSr5snUdDiWrHa7oviqJRV+81zruwtfsfkXXajfWBwiRwwKPbByJ+f18XS82m yXeokb9KmqlYfy+AxgEWE4tNlxbJFEFBKPbfMCx3/amDTPDjzdjM2UzYJGsJdPwN3nl5 2T7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787240714; x=1787845514; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a1eX4DFVYT+BZd7oT7NYu1d4HaTZbGISixdfKYs3hNE=; b=SbngjovLXm8m1TmFCx7OKWxu8JON8jJtdes84aSVynsQegKxobPIZvjM1e84YejngV NNye+oSizf/NesvumWkh6P7muPfF5ySs7I6sI9QqLGO3Udhk7tpH7ySeky4bR7Lmx4tx xgzf/rUDnoCxAhHamLkKtDIkxraC0KCwExTgx93atQHErnwZxiMOUFT//kYsoK3ts5/A PHaB6z5GZrJii1ZKeYEIVv/Dibj0iGe4EsxuNjYMp61kGalB+NsWvessWyQKj4ZIVB64 GUFHPttx5FDfqr6TKaZaXfeWptL3Oql8vI/Ia3b6LeERJdhIvlMMUcCLwLJVDgFKu4/h fR4Q== X-Forwarded-Encrypted: i=1; AHgh+Rp8dBgwyKZX49e8RTzXEWaxIOcnT+LM1KnGWiT06gB1MVklbDYq4XEEjXdqn6mhbmg6OaOughccIupW74s=@vger.kernel.org X-Gm-Message-State: AOJu0YyL2/bJZckJLlZtM4lttaHFYngGRywU+1enLOchBdarTqaHpJ+o /VFW/C2Aw3jGgmcsVfWO7DyJrJPmQEEMSe1Xrp7AL46ycBfMK1dVE4+6 X-Gm-Gg: AR+sD13gsvHGXLr2bxe5DV6n0CWzmPGexqyU2yQHqCyXB2ScnLZF57n/W5WCyRunUMm 2t0EkHoDS6/UlweFTOaQhjHChRT9Nb7RcB3IGowspv2qPWXdIFEkCOC/q1f+pX1jJEx5nDaUkw6 1wH3x650VP3n9qCFQ+DFqlQSTeBSXXj0rMK1Z9C9DTd9XFJi2BL26RvU0ogen6ABsBtgp/dpkSz VFkIWaLVEgt5bho1Mn6UnnslWmzJN+uRKaALyyeL37TNl5X8EP+j0J+u+f19Jv0zGdFkSFKjgfK bftC92z+EsER+Hyjx7D8QuMKwXh4YW2JEgSr+9ms8jA/afKQdule2qNFzaNFeq+l/D2noGss9pD WbdGOJElieRcq+IfdcqDkxiYLqlabWfZScWRVXEZdMWiH8heVu0rsQ97tTifXKWrAIYDk/VDpkP GSQyCPsfIymjUQoRzA3ouesGRRQH8QbeqWOmtwWghwx8QTq6oYzG1XXofaK+RHq63cD2/Qtjqg X-Received: by 2002:a05:600c:8a1a:10b0:499:b001:b8d4 with SMTP id 5b1f17b1804b1-499b001b8e1mr129153565e9.5.1787240713825; Thu, 20 Aug 2026 08:45:13 -0700 (PDT) Received: from unicorn.lan.internal ([2a0d:3341:b894:4600:ea33:29d5:6d76:8b36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b1450fb9sm13444652f8f.14.2026.08.20.08.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 08:45:13 -0700 (PDT) From: Giuseppe Piscitelli To: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v3] net/sched: sch_cake: fix autorate reconfiguration throttling Date: Thu, 20 Aug 2026 17:45:03 +0200 Message-ID: <20260820154503.892214-1-ooonea@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit CAKE's autorate-ingress path intends to limit shaper reconfiguration to once per 250 ms, but last_reconfig_time is only checked and never updated. Since the field stays zero, every qualifying capacity-estimate window can call cake_reconfigure(), causing avoidable rate churn and scheduler work under bursty traffic. Store the current timestamp when autorate actually reconfigures the qdisc so the guard enforces the intended interval. Fixes: 7298de9cd725 ("sch_cake: Add ingress mode") Assisted-by: Codex:gpt-5.5 Signed-off-by: Giuseppe Piscitelli --- v3: resend via git send-email; v2 went out through a mail client that mangled whitespace and does not apply v2: spell out my full name in From/Signed-off-by (Paolo Abeni) net/sched/sch_cake.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index f25f60978..dc9326702 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1907,6 +1907,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, ktime_add_ms(q->last_reconfig_time, 250))) { q->config->rate_bps = (q->avg_peak_bandwidth * 15) >> 4; + q->last_reconfig_time = now; cake_reconfigure(sch); } } base-commit: 24ef02f934eeb48830cff6b739abc3c62b1d107b -- 2.54.0