From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D8CE25B0BE for ; Thu, 20 Aug 2026 17:47:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248063; cv=none; b=TbJ9PkKARBIzqxoIuFXiEazKAoJyU0lfLZvxQImMJpgehDA2VzeJYgAcQNq2yNmcofi+2z06ZUaEq8svpa8c/64Jp2GT/bLU7wVBd+uwbLJbGwyJh5eDeKYpouRoD7Ji0BjZV/CRqwqqePLr6PhEERkBGKt7f2MvoiL2xWHIAdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787248063; c=relaxed/simple; bh=7bZhKXDFYfZ99I/SGINR5Nc/mrdyDC5qKrF46f5SR+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SysZ6QPO26gV2k+xJnJIrkCzvXlUyd2kco3/D+bzDTUNXqNfrBhyWxN+YoYi5KskLsiIgq89PeK/OoBYkWS7O1SCowixVXdODj2vYyqs03JkMTMi13+fH3MX6ertckPDjxnbkaZG13IYF8T+sO6HXX7bK1wt9a+OAzCe2ZnqVTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=AtlMwP6L; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AtlMwP6L" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-90c522298d2so1078516d6.2 for ; Thu, 20 Aug 2026 10:47:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1787248061; x=1787852861; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nhC4gcMj6qZbqU/PjOfQzYKyx+7NDJFZ4HXjtdF8h8k=; b=AtlMwP6LSkIjHKjCpXqGHS5rZ3q2A6D5splILK2YKs5AoRSNsaB+By7yMMrSfOmn9O 57EHjiVa4nuHkqvKLxZreLCh3/oDHSmlE9fda3EVTlWuswSTwNb3S6UUb9N1THw3ozKE rAm4l8VmsJOjPEUXkLio9MHisH2/wt0QvqeV8vXVy/RLIrK0IaWD5rwXFfzDdMrp1XSN 9PETFP0ETO0asMZhTcfEH7v0J1Ub9rZRX47sRo5+35iXuGBWKO04PJphWBB8DklBJRsn ANZGQ6T0bvYM3j4CEHcgRGVH818lJKHZvNKOnB5RFgR9mhjoOWPNoRmPW4LJVNObVmoc /ZRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787248061; x=1787852861; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nhC4gcMj6qZbqU/PjOfQzYKyx+7NDJFZ4HXjtdF8h8k=; b=UTUMzcXOhqSeyBehQ7FDr7v5R+4T8MMMdUC48exNhGItl3ZmyW/kga2jtMxeLO1QaG eYU8PDB9dqW3PkWOPjKftRjN8FMM8RRA1F6bJQFuHmMkMGX5/j7Yonz46UN/xs6XB8BG 2Rsygmaz5GUegDyZIWqwXvjHwotquFkfyANJ6i8rDLnKeE5E7AtgtsPm0JuZa9YXFrbq roLTB68fkOAwvcg1cSDourkrR5ydquNMxcbXSJ+jq8cxVxB7nJcmGmTH1mk7blbV+hwx VoW45LSH14My+GKSrYpOvvmPu1eBoPGttRZ5frEwYfwSWpfwSvg1OwBsTRsuotsqTVhx N6QQ== X-Forwarded-Encrypted: i=1; AHgh+RrC5N7uL99ATmSQuoblnSf69ig48Ax1kAeK+Qw6SHuwHY8hf3UufYCehPQC4LEVgKRG11bEKia/VM5hp2c=@vger.kernel.org X-Gm-Message-State: AOJu0YwXCCrWzRI6C7dcMjB01vZ+mKubcKSSJB9XgA7MJWUQjo0xOJWD EU5UgcfFrA8kAiF6eljyaQzVrTqq4l1CrTitV3idB+DY0snoEODzWOxEXmHBJHj3L2g= X-Gm-Gg: AR+sD13hkZ88Iac9FdJsHOvTM/HrzgBGIyzGWja08CXWuvctKE+T9/MZKdS0s2/VLI6 HmyvPy42dkSIq1UovQbg/ba/fkHX7W+3AFbPKK/rb+9gg52RlX4zeTk0M71dXDYcZN8BND9rpqc /Ac82Eqi/AZi3myiv6JzRc84r7JYfnmYrDX8mYSylIAmD8/Cr9KC9Ly1LRBYVPNPVQpKYutlewb XDtnbltmSS6+GpuJgkQWjR/F3Mkalryv1V5C//DHKVZ5T0071UsS+Szil5VlGUvmYD9T2T9yzB/ uNx3mQ7goip3/DN4IcQsonLqOfoKFHp246A7Ri0RIFr8rTru35mfIi0XbuJaEGU9aTcEabHlOX+ 0P2JWqEtJ3Mr6C/Eezy9JnujjvhqFvCYFkTlNKlFRegfK5F9/h4akFgxlEf987KKm6Q1yfRCVP+ xPcXZC7811x58ucgjwz5Wvgsl7fcSLIIGJvri+gmo1OqRdp+i6OciCfjzbNykyRdBftSluSFMjZ riQc1vQ8R99EPc+EpG3wD1p25y5BphZBaZPvFNvgx99jA== X-Received: by 2002:a05:620a:3712:b0:936:9f47:e908 with SMTP id af79cd13be357-9371e259c99mr1294064585a.19.1787248060787; Thu, 20 Aug 2026 10:47:40 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93720493f40sm418053785a.1.2026.08.20.10.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 10:47:40 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wx6rb-00000004ADY-1Cil; Thu, 20 Aug 2026 14:47:39 -0300 Date: Thu, 20 Aug 2026 14:47:39 -0300 From: Jason Gunthorpe To: Catalin Marinas Cc: Steven Price , Christian =?utf-8?B?S8O2bmln?= , Marc Zyngier , Sumit Semwal , Thomas Gleixner , "T.J. Mercier" , Benjamin Gaignard , Brian Starkey , John Stultz , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Jiri Pirko , Marek Szyprowski , Suzuki K Poulose Subject: Re: [PATCH v2 1/4] irqchip/gic-v3-its: Zero shared pages after conversion Message-ID: <20260820174739.GA981928@ziepe.ca> References: <20260820150034.88729-1-steven.price@arm.com> <20260820150034.88729-2-steven.price@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 20, 2026 at 06:44:43PM +0100, Catalin Marinas wrote: > On Thu, Aug 20, 2026 at 04:00:30PM +0100, Steven Price wrote: > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > > index 6f5811aae59c..a055837832bc 100644 > > --- a/drivers/irqchip/irq-gic-v3-its.c > > +++ b/drivers/irqchip/irq-gic-v3-its.c > > @@ -213,16 +213,18 @@ static gfp_t gfp_flags_quirk; > > static struct page *its_alloc_pages_node(int node, gfp_t gfp, > > unsigned int order) > > { > > + bool want_zero = gfp & __GFP_ZERO; > > struct page *page; > > int ret = 0; > > > > - page = alloc_pages_node(node, gfp | gfp_flags_quirk, order); > > + page = alloc_pages_node(node, (gfp & ~__GFP_ZERO) | gfp_flags_quirk, > > + order); > > I don't think pKVM does any scrubbing on set_memory_decrypted(), so it > potentially exposes confidential guest data before it reaches > clear_pages() below. IMHO that has got to be handled in the arch code implementing set memory decrypted. Further pointing that maybe we should have an alloc decrypted so we can at least try to minimize the number of times we write to this memory. :( Jason