From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786C03A0B3F for ; Fri, 21 Aug 2026 13:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320225; cv=none; b=KHEv9VMYOoicHbS09tlgF9//LoSQ+ScYmFYpkRg2Td8lZDXbB0bnChV7V68hyQVcU09LeebKx4Ndxm7T2SP9JGtMc3cB3zmu/zCL9IYwNIF56C5LlrMPe5SlAZYovO5iMKMbomACbL2bcgCrPaBuHjGQ/NhLx47YR8hAqneq9ZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787320225; c=relaxed/simple; bh=RYqkv53J5NrkqBLuRcgdRfcpAvdgLLB7SotsZ958SG4=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=cMStf1/MeL96fAFpw1h89rrpABb4nEW+N1yQkC1ZzvGC6hVBMyumM4ARhas60MtHfm0e4LpGldWj+m5PmPIsjUVBVCdBi0Qh/OL7Vhg+HCBtSGfg7jsW5ZLdECJyVRxJrlkZD8H7/w12d94VoOmmijBES4tYrlSuSRFN3bhQKbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gJkbtIef; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=sjvM0q/o; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gJkbtIef"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="sjvM0q/o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787320222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FxYBqvqfSfMLOK6E3WTT29SXyr6Pc7OT1nYn+VS1dSk=; b=gJkbtIefgJ9Ei9WWyLu/WNFuKFChG2kQFE8LxHMGBrSWfqCwarrAnPPnGiN776lFFoL6h1 t2Szl2FZNhUz/t6tkMR/nETVTH2NlqrNF7h62FmIZvFG298b1rb71gd2yW0/i8UpfM4IS/ yokxS0BBP627+0/jGccIEuGyBVezrz0= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-gi1r8JT2NyysB5izri7qpA-1; Fri, 21 Aug 2026 09:50:15 -0400 X-MC-Unique: gi1r8JT2NyysB5izri7qpA-1 X-Mimecast-MFC-AGG-ID: gi1r8JT2NyysB5izri7qpA_1787320214 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3823dcc1647so1493733a91.3 for ; Fri, 21 Aug 2026 06:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787320214; x=1787925014; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=FxYBqvqfSfMLOK6E3WTT29SXyr6Pc7OT1nYn+VS1dSk=; b=sjvM0q/oQ5rHXkfITsrvO0uA8jovTa0DEKbVry1jQ4A1yABvNzNrO3tghNqDhk3vGM H/YoMaQvU8NUAk03lsRGF/6fpT0/vgFNA1YJp5giY3tCKx7f+KQg/KZPrBbUSZxHGndY cwmqyiiwwLEMTzH1fc+JRRUdBqllXzBJWiKKfgVoJcQ/91+OOuVy784p4G4cR9CnjL/V KlN4dRpzLAA8uxnbAhFmPVaOhkPY9IdWqgqxLUw75YCqSkX9tr18CGlUtw1EARkdF8ua ll53dymLObGlOdRsTs+K6OeLsDWfRYQ86ot+Gzw2F8jfPp86zUsl6b0eqiFPRbheMav2 aNLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787320214; x=1787925014; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=FxYBqvqfSfMLOK6E3WTT29SXyr6Pc7OT1nYn+VS1dSk=; b=I7KCseRrdv/JtSzU1FLVbDftSxBqB+upr5SFic9Jq5GUP5XaBbLBcTc6jiOHZbSHC0 kUYxzxuEw7CcM7Jp6peHNrPq1E94JTGtSMt9B5EPE6fMfWP3GGXDIyCZiGBzxZr68DX1 o6jvXUS4PkoBRbTcus6B9Vqg3fVURW/bgZy8MWf3TGjJ5/lZkMM63PMG25dXuzlyLWiO dGLEpjrgzePW/+ZYUaFVPlNGJV5bIjD9L0adgHWE9jqhT34xut6+tYYCkP1VGHNcO1mV dU7/Z/xEknI6iWqCT307tApVWA+aPqfvNvdlGXl2GCbKRdqgYNcXRoWGad1dDYaNUF7a TD7A== X-Forwarded-Encrypted: i=1; AHgh+RqhwRBUZy8hjuj3tTj7MIxzaPOGsrqs1wOXDiBgDNIE7AT3OXoiEdyaEUM0DN3I0eGe/IfAyBP8NacxloQ=@vger.kernel.org X-Gm-Message-State: AFuF++nvnnTfq4dfqwAo/wfknnAgfD+zO7Zl01Fbm5oR7rFWmMjAtGI7 V5K/tKmtIFlRHR44y695yVFZu5U8T4xFEpc2zu4TQ9WVFlWxjTK73Ti5+YEi1sMP3ne48zmIzrB TM/zME9p2jSODVVXPIpEWwnD3ZLFKBVULwyq6es8JmtiRTrkONs0+8FYxdQBV2KYNiQ== X-Gm-Gg: AR+sD13zPwqKU5VVWm4ADLeNIDx9zJSG95XUJbRvFXcFGom60Bcdlm0WDue9KmQUn3h NyvYj7jthJ5gCS1OQ8Icy5yfY0xmS6PjluJbUyl25Z/w+s0NKDM1trkQjp8jzkqnIlp2cK04oX2 bHaoAIZ0/FW5zT4ETEZ0VVgl7sgu6oFUfBkIx09adMOrO+eUXLmWUc1dE9/Ojhj1xJet65vAekG 1CcwXwnF2PgyLDCDvTlmczMRXdhaci2L0tvzpCqPMJbljm6REO0e47S8VcxlimJ7yO6dsYKkIfO qRnuPxCUp34OcUvCtOOdqK/WKxRh63Up4iaLfGORiI1G4OGKK6PAxj0I8meVB3th3sqF9hXmudS FMFizmyn2arRPZJhKoZG88PJpsuYo6hSu X-Received: by 2002:a17:90b:3ecc:b0:38e:ad9d:1161 with SMTP id 98e67ed59e1d1-395c2f9fa9bmr10834145a91.0.1787320213420; Fri, 21 Aug 2026 06:50:13 -0700 (PDT) X-Received: by 2002:a17:90b:3ecc:b0:38e:ad9d:1161 with SMTP id 98e67ed59e1d1-395c2f9fa9bmr10834046a91.0.1787320212881; Fri, 21 Aug 2026 06:50:12 -0700 (PDT) Received: from mpilaniy-mac.redhat.corp ([122.171.22.116]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c4c194d2sm3300502a91.15.2026.08.21.06.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 06:50:12 -0700 (PDT) From: Mukesh Pilaniya Subject: [PATCH v3 0/2] kexec: fix probe error codes and error propagation Date: Fri, 21 Aug 2026 19:19:56 +0530 Message-Id: <20260821-mpilaniy-v3-0-76b355399d2e@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/22Nyw6CMBQFf4V0bU0fYq0r/8O4gPZWrpFCWmwkh H+X4gYTl5OcmTORCAEhknMxkQAJI3Z+AbkriGkqfweKdmEimDiyE5e07fFZeRypczUzRgsjuST LvA/g8L2mrrcvx1f9ADNkPy8ajEMXxvUr8bz7k02ccqqUsgfLQDKnLgFsUw1707Ukd5PYmnpjC sqoLkELDRYYlD/mPM8fdp454+0AAAA= X-Change-ID: 20260813-mpilaniy-ffb0cc92c313 To: Catalin Marinas , Will Deacon , Mark Rutland , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andrew Morton , Baoquan He , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Tao Liu , Philipp Rudo Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, kexec@lists.infradead.org, Mukesh Pilaniya , Bradley Morgan X-Mailer: b4 0.15.2 While debugging a misleading error on s390x where kexec -s reported "syscall kexec_file_load not available" instead of the actual EINVAL from a kernel command line that exceeded the architecture limit, we found that some kexec image probe functions return -EINVAL instead of -ENOEXEC for format mismatches, and kexec_image_probe_default() has a bug where it returns whatever the last loader returned rather than always returning -ENOEXEC when no loader matches. Patch 1 fixes all probe functions to return -ENOEXEC when they do not recognize the image format. Patch 2 fixes kexec_image_probe_default() to distinguish format mismatches (-ENOEXEC) from real errors (e.g. -ENOMEM), propagating real errors immediately and only continuing to the next loader on -ENOEXEC. kexec-tools patch: https://lore.kernel.org/all/20260814075329.30203-1-mpilaniy@redhat.com/ Signed-off-by: Mukesh Pilaniya --- Changes in v3: - Patch 2: rename ret to err and change ret == 0 to !err as suggested by Mike. - Link to v2: https://patch.msgid.link/20260819-mpilaniy-v2-0-95e929ede0e5@redhat.com Changes in v2: - Added patch 2 to fix error propagation in kexec_image_probe_default(), as suggested by Pratyush Yadav. - Link to v1: https://patch.msgid.link/20260813-mpilaniy-v1-1-777d4d0e30f7@redhat.com To: Catalin Marinas To: Will Deacon To: Mark Rutland To: Huacai Chen To: WANG Xuerui To: Paul Walmsley To: Palmer Dabbelt To: Albert Ou To: Alexandre Ghiti To: Andrew Morton To: Baoquan He To: Mike Rapoport To: Pasha Tatashin To: Pratyush Yadav To: Philipp Rudo To: Tao Liu Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-riscv@lists.infradead.org Cc: kexec@lists.infradead.org --- Mukesh Pilaniya (2): kexec: return -ENOEXEC from image probe functions on mismatch kexec: fix error propagation in kexec_image_probe_default() arch/arm64/kernel/kexec_image.c | 4 ++-- arch/loongarch/kernel/kexec_efi.c | 4 ++-- arch/riscv/kernel/kexec_image.c | 4 ++-- kernel/kexec_elf.c | 4 ++-- kernel/kexec_file.c | 12 +++++++----- 5 files changed, 15 insertions(+), 13 deletions(-) --- base-commit: dd8c49a14f169d58e7a07a2c96fb588f3456efa0 change-id: 20260813-mpilaniy-ffb0cc92c313 Best regards, -- Mukesh Pilaniya