From: Jonathan Cameron <jic23@kernel.org>
To: Linkai Gong <gonglinkai@kylinos.cn>
Cc: "Remi Buisson" <remi.buisson@tdk.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] iio: imu: inv_icm45600: clamp FIFO packet count to buffer size
Date: Fri, 21 Aug 2026 02:51:05 +0100 [thread overview]
Message-ID: <20260821025105.4739d76b@jic23-huawei> (raw)
In-Reply-To: <20260820070208.3891851-1-gonglinkai@kylinos.cn>
On Thu, 20 Aug 2026 15:02:08 +0800
Linkai Gong <gonglinkai@kylinos.cn> wrote:
> The IRQ path calls inv_icm45600_buffer_fifo_read(st, 0), so the raw
> 16-bit FIFO count sizes the read into st->fifo.data (8K). Cap the
> packet count so the transfer cannot exceed that buffer.
>
> Fixes: 06674a72cf7a ("iio: imu: inv_icm45600: add buffer support in iio devices")
> Cc: stable@vger.kernel.org
> Signed-off-by: Linkai Gong <gonglinkai@kylinos.cn>
I believe this is fixed in the iio tree (and shortly upstream), though
in a slightly different way.
Fwiw I don't consider these fixes because the hardware doesn't return
out of range values - rather they are hardening against a potential problem.
A few other things inline.
> ---
> drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c b/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c
> index 2b9ea317385c..62e9e138bc89 100644
> --- a/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c
> +++ b/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c
> @@ -419,8 +419,10 @@ int inv_icm45600_buffer_fifo_read(struct inv_icm45600_state *st,
> fifo_nb = le16_to_cpup(raw_fifo_count);
> if (fifo_nb == 0)
> return 0;
> - if (max > 0 && fifo_nb > max)
> - fifo_nb = max;
> + if (max > 0)
> + fifo_nb = min(fifo_nb, (size_t)max);
This looks like an unrelated change. min is pretty flexible on inputs anyway
so perhaps this is fine without that cast.
> + fifo_nb = min_t(size_t, fifo_nb,
> + INV_ICM45600_FIFO_SIZE_MAX / packet_size);
Why is min_t needed? It very rarely is given how min handles mixed types.
Maybe I'm missing something here but I'm not going to chase
it down given we already have a fix in place
Thanks,
Jonathan
>
> /* Try to read all FIFO data in internal buffer. */
> st->fifo.count = fifo_nb * packet_size;
next prev parent reply other threads:[~2026-08-21 1:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 7:02 Linkai Gong
2026-08-21 1:51 ` Jonathan Cameron [this message]
2026-08-21 3:12 ` Linkai Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821025105.4739d76b@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gonglinkai@kylinos.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=remi.buisson@tdk.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®