From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 533783E3C7A for ; Fri, 21 Aug 2026 10:25:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307933; cv=none; b=Eepepzst4uqJn/qweaoKCdAwqzpyRrGNi3YoS49mf5yCitQpt6CF8/cN5qVsCgaWQLe5QpX/PUUP1E1lJPRwijmoS3vVOMGc2UjbG53q5j/LWhRTrQYifX+MGE06Nw3E/ch45YHqyiMFGM623mdjrvALfnCQ27+UIwJJ72FxSSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787307933; c=relaxed/simple; bh=gPhH4u7kFmeg8EHT11wFoZiSLcRlZ7le7pXzWEpGGPE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iozAQluTfIojRe9gqVdSFvqX04Ji+iJ3xyTiSvp6mjA+E2uLtjTs6D1hP1qs9Re9uFzqXTdVMXCCzK3NkP+qvkz6wf3nyOVtipPYb7Dl/iRnXRCQ/FQtj9PUVPkrJy+fRjCXs7sWvAPsavzXOZQJAtAJFW11uiHTwspu4wAwrR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y15U8pZ0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y15U8pZ0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-499b02fc590so5075165e9.2 for ; Fri, 21 Aug 2026 03:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787307918; x=1787912718; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wyIuAekOpVPDTOROhunhzyK0Yq3w+Qc14AFzLwRnzrE=; b=Y15U8pZ0GuPE7RdZiKMbS9/7LyVYhr+S3npWht5VFFl6bD+u1Ef3YGqZMp33R76Kfp 6briDVENEIpPeJnHVCIjyCJpD5xF24aoytgFRDu3EETAWKUT44udJQ2S/JePyGCp2gZj VUFdTLWXl+KB3mPOMqQzqJuLhQSeuP5/So10tId1YXQO9ZJ0yz4aeQA3+xeWaiVm3yT3 RWNCrwNL6YuLILRer5k8b6HcpnVajVmW6euhUA/8GH3CxJ3BCKThqBwogJqWD+OWNtsm zg2xM1hvmi1cwiXEn+e+o3IJQGe1WlTgEhlOdKhcuNpc1/CDqTSUyHXtuLYUwfLWYdXu Ogww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787307918; x=1787912718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wyIuAekOpVPDTOROhunhzyK0Yq3w+Qc14AFzLwRnzrE=; b=T097a/K4QdbvBhvfPeWMPI1EJijS4Q1DBIKVr8QbTcxDOYELYD0JgK6A47Z4PD0r9k 5gnU8z8gBdf0K6g0sGyFl9de229fK9UqCPWr9GhJnEsSmN6MIjGl/WoB0Oc+UUeT+vZZ nyA/AGWRjKxTPXTQJtlCCkdYxdA9wmM9ox1/fPudcksI0FyV2pVgXngPUR63E4YJ4zOL 8a4rdACkUMBO1i/UHTLs04DEWQsECMpVE5m/okympLW5zPd64Dj1OWyttyWJHI5gNqrp yrcavClQNEUBJAzvDQU5IhgcZ9LlLFsrG2ow87bv3uvozAlfPmXpiKLrYazMiVLeU9jZ 59hw== X-Forwarded-Encrypted: i=1; AHgh+Rqt/PnfHt+uPvDEcGLF0fOtwFu3o4bvohanBo5CrZsyzxd1cvmDxXJ9ZVnsZfZkP2VCrWv9vpra6TcElG0=@vger.kernel.org X-Gm-Message-State: AOJu0YytiayMPaCDI2uC4caH9GCtXuJKdakl8oJk9QH5/VuT9v8XfkGU LNVTDOPUQ6wtOstaBp7QG3Dc1dGgYR7v35hz1fA44uwP1m5LEQst0yPm X-Gm-Gg: AR+sD13PFtF+dx0iNHGW5guNLUY6TV3R/UlL4Eaj/bJt8X21CzJB7kDOIol5C1JyViE KF0/ejc11ncRZA/+FA+hmWxhQwl6OElwbnuSpvEqKRpFh076iK32jHoH7ewA5tRGi0x+ec86qNH q5y4c+T67WWJYUoFdeHGVINijDf8fQz3Rrl4m73O8sOq4adTFfvqQ7mgvt9gI2bT0OS0HhqDuiT qheE7nFU1b17csc8A4SARKUOy+y/fbgjz+4gffBN+S4j/XAAFgj+8YpQICBz/7itIgPGETTgT35 PC9285ZIFlm1RE1+s6S47oWLdNEIEESQTAElXdzvfTXCatcloqEnKp4J3miSMCPj2BtMZpDwUOK bRo1KDQaKyRPBk6qCzhTxhx3Lqc2oI2gBBVnHKVaTXdS8Kmbj5UPAO8X60sOTk+mhRKfzQTNUK5 TFGHjxFKtpQ7as+l7RwlY5mg8T0osIr3xzjLSNNFKBX7F5ApKxIlgVCG951oK797hBnwBQQvSCQ 9QCjK1XcJiTPw== X-Received: by 2002:a05:600c:c494:b0:499:a5c8:c6f3 with SMTP id 5b1f17b1804b1-499b82f4d3bmr68893055e9.3.1787307918131; Fri, 21 Aug 2026 03:25:18 -0700 (PDT) Received: from fedora ([105.74.130.192]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499b9ba5139sm11663155e9.2.2026.08.21.03.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 03:25:17 -0700 (PDT) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: jic23@kernel.org, lars@metafoo.de Cc: Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v5 6/6] iio: dac: ad5504: support scale via output-range-microvolt property Date: Fri, 21 Aug 2026 06:24:48 -0400 Message-ID: <20260821102452.37407-7-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821102452.37407-1-0rayn.dev@gmail.com> References: <20260821102452.37407-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The AD5504 output range is set by the R_SEL pin, not the VCC supply. Add support for 'output-range-microvolt' to set vref_mv directly from firmware. Use device_property_present() to distinguish absent from malformed property rather than relying on the ambiguous -EINVAL from device_property_read_u32_array(). Fall back to the vcc regulator voltage for old DTs that predate this property. Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 489d2e03e9f6..19ece5a2af58 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -300,6 +300,7 @@ static int ad5504_probe(struct spi_device *spi) struct device *dev = &spi->dev; struct iio_dev *indio_dev; struct ad5504_state *st; + u32 range[2]; int ret; indio_dev = devm_iio_device_alloc(dev, sizeof(*st)); @@ -315,12 +316,30 @@ static int ad5504_probe(struct spi_device *spi) if (is_acpi_device_node(dev_fwnode(dev))) { st->vref_mv = AD5504_VREF_ACPI_DEFAULT_mV; } else { - ret = devm_regulator_get_enable_read_voltage(dev, "vcc"); - if (ret < 0) - return dev_err_probe(dev, ret, - "Failed to get vcc regulator\n"); - - st->vref_mv = ret / 1000; + if (device_property_present(dev, "output-range-microvolt")) { + ret = device_property_read_u32_array(dev, "output-range-microvolt", + range, ARRAY_SIZE(range)); + if (ret) + return dev_err_probe(dev, ret, + "Error parsing output-range-microvolt\n"); + + if (range[0] != 0 || (range[1] != 30 * MICRO && range[1] != 60 * MICRO)) + return dev_err_probe(dev, -EINVAL, + "Invalid output-range-microvolt\n"); + + st->vref_mv = range[1] / (MICRO / MILLI); + + ret = devm_regulator_get_enable(dev, "vcc"); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to enable vcc regulator\n"); + } else { + /* Backward compat: old DTs without output-range-microvolt */ + ret = devm_regulator_get_enable_read_voltage(dev, "vcc"); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to get vcc regulator\n"); + + st->vref_mv = ret / (MICRO / MILLI); + } } st->spi = spi; -- 2.55.0