From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A3E38E8A0 for ; Fri, 21 Aug 2026 12:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787314913; cv=none; b=O1g7tFDLo1cpZoGrHB00v96B1J/jpj9hFiq+JFBEg9zGdO5gXyUfIdfzDcoImlbtfdHYhfKHYHf8GD5ti+zmN71njHVhQ/7k0XHfNVfGTEEJur4+HKWIh89Wv8tvhbpSvck62unkloij45Y5etYv9iC2lohqxoP6covh9N885dE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787314913; c=relaxed/simple; bh=vDG6VgGLB1ibhVtC5i7RLaGRct1dwqYniHcqmrujC5Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RnIHke2Luco3tjXKhjsziSfnskbv2WEiaF6S08JjjlzeVBo54gy9wR220Qa6Dav4AUSKKwO7u3wl0Zv6Wh8NLw3qYjefU/t+gKBq4Gjfpdw4c+anFf82eDPfycTjh/Y+B2rCodtAYvPMPUK76w7XrCdtWlfT/dL9za5QiydKe+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=STcQjtVn; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="STcQjtVn" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6a386a34603so2242041a12.1 for ; Fri, 21 Aug 2026 05:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787314907; x=1787919707; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=U+VklefX138oVd49VIDXjzUaX4u45OfIRfPWaoTXpLM=; b=STcQjtVnhubjh6QKj0fJ3DoJXoGFqP58Oyz+IBpjarDCY90bWXYvALd2HP6wyqkew5 2VDBk/No1O8etONMCzYA5xQ1PQ6terYp/ALM0MlQgoYr5TMYAvHrtz5Cfb4bVriyre6f CzHO3X4SteeSg2IbBKmZHNumLWDBiKOIOFZlNa5KqG68fDEE7pwnrHzk8eRJevbQU2qi +IuOdG8cIzf3Vrl0cfEMP8FZOpb4B6fZvTLVzipuG6lXCRRC4zkKbW8Z+51Qb/UxKJDq GWlu3fxxsWs80/a8k3UyrKF2uNaSote1eg4xJZtJ/W+a8FyhGN6Zt8DmNpNANJkpzS1Z EyDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787314907; x=1787919707; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U+VklefX138oVd49VIDXjzUaX4u45OfIRfPWaoTXpLM=; b=E+rc4sjRHPvAt3R2iar/YDkyDIvkuiQlGapu8K38T0/TqwYFR/zRSv7R1JuVBFvViT 5JzW5nnOZdPd5aTDOgi/XfT8Qkpb4UAQjvL8vqiRz+DXNsFZW/lEZPxURuArRwd29PBa aKM67xCCyFKcY0I4ZH4M14ywwO+V2EitQsuKgn9NGKNXW7TEQcKcKLXgIiM0QAw1MeSP 5pP4tXOphnLa6TN2Co+HJcxgCdZSVT9PRWTrOXgJBj9TxlJO7Q0fQDRX26UxARDwFYxZ d7IAQB5yrnc9VORKOyRgZbGpTBsgpAvILNUpSWJSPvKckWgMEPRMox71ifuRSu/avUmb yUgw== X-Forwarded-Encrypted: i=1; AHgh+Rqn8BhswgHdYR3wJbiwivYEB93Bf/vvWudCjck/dV0q7pfq+XiaWyspPA8LQr/fHfwH/2GepQ8qcDLh55E=@vger.kernel.org X-Gm-Message-State: AFuF++lPIVEWNm4QQdLUeeQYeomWkahOi3reSnScm3oqsGE7/r1cGnpm 2wIi6EISMfo7DcD1DQ5N4sQxDyJybXRzoXTdyVnfmCVkpLCgvAe8Qass X-Gm-Gg: AR+sD13161vDUA7tuthiXXRqa1vevl4dS4e/RWvWawhI3xBVE7zbSm7JP/SN8WDpePr Un0csB4HFvSa7CCE/7AWtCLv/JNe77Q+NLKm3zxBiMa9nqALq1y2/Bo7mHXerWO/I27oN32oWjs fXhgjY49TwIrk2ZBH78APW9TxRasq1hiKVM2L6IvJCQntrArhaYogbUDkJwd7X/Vj0nvwSJ3Ett X8VESJ/bUDmpqbtGJbZI9z3Yg7bPySnxRe+7ntXvI53BExiYsOnEHk4l8zIgvV2XfB9nEFiOPwf er5AM+5co+AkMDtHsMP+KR339ALJp5kg2Lcj38oNJMqF8UMozgEHpzK+XdLsqqIk3tIok/HG3s7 /n4WMaTaco+a1cq2BEa7E2bLShjHcGx12PqgfxG64Kyvm24i1n/IvvVoT0Ub3rz8kMda1axHN2n C4CsvNNxQHrGONu8W5RGUkQ5H8q7i4m79v2dvkIPbjEjvHWIL4+p+b3DsjN43E/1xDaEJl1qu3Y L+Gf34rF7OJg287UnZ4oFI= X-Received: by 2002:a05:6402:23c1:b0:6a3:ec9f:7e3d with SMTP id 4fb4d7f45d1cf-6a4112fafdcmr9645391a12.6.1787314907216; Fri, 21 Aug 2026 05:21:47 -0700 (PDT) Received: from hisam ([2407:d000:508:2027:f309:cd0f:ed5a:5b9]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3ff177b1esm6473776a12.29.2026.08.21.05.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 05:21:46 -0700 (PDT) From: Hisam Mehboob To: kvm@vger.kernel.org Cc: dmatlack@google.com, alex@shazbot.org, shuah@kernel.org, seanjc@google.com, jrhilke@google.com, rananta@google.com, vipinsh@google.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Hisam Mehboob Subject: [PATCH] selftests/vfio: Include for basename() on non-glibc builds Date: Fri, 21 Aug 2026 17:21:11 +0500 Message-ID: <20260821122110.902382-2-hisamshar@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sysfs.c calls basename() but does not include its declaration. Glibc exposes basename() through with _GNU_SOURCE, while musl declares it in . With musl, this results in an implicit-function-declaration error and subsequent type-mismatch errors at the callers. Include so the declaration is available on both glibc and musl. This is safe at both call sites: the arguments are local writable char[PATH_MAX] buffers filled by readlink_safe(). Link: https://lore.kernel.org/kvm/CALzav=fs4bqMM7BXNPXqhtbqGzA+LW5fgx2-1Q5=sTN5+krYhw@mail.gmail.com/ Fixes: a262fc49e0aa ("KVM: selftests: Build and link selftests/vfio/lib into KVM selftests") Signed-off-by: Hisam Mehboob --- tools/testing/selftests/vfio/lib/sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/vfio/lib/sysfs.c b/tools/testing/selftests/vfio/lib/sysfs.c index 11415448b2e2..daf117a299a6 100644 --- a/tools/testing/selftests/vfio/lib/sysfs.c +++ b/tools/testing/selftests/vfio/lib/sysfs.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only #include +#include #include #include #include -- 2.51.0