From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 821304963C3 for ; Fri, 21 Aug 2026 14:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787321868; cv=none; b=o9SmwxcWsCx7e4kEuEgP8krDYx2jZfPvS+7/y7+a9gkRrmWVTKNr0OVBdMon5M9+B48aE1SRUj/1kbl2lNFNvR+9eXE4Kt7UmQzzyJD5/x2dWKYBGdGT2ZjxuAGKdlMnpclyS34reUPNNDKWUZFDbb1+f6/eqChA+Bf100Bu+KA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787321868; c=relaxed/simple; bh=4MVmKoV3w/SclEbjjmQ6N5tRHfbCzJRv2Yqxya3W4CU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qpGGupRu9zDe07VDdv92xC5WCDaRJbM6NjpNWZq7GkNXCjCduar2ALAN12KOS5fefiH4GgWjpmd723ehJQCgbzMogyhqVdNA4yA2BVyyXyHH9O+S548ArO1jsaFNr2lE2tr+GJuN8EPjN0kmszDtb3yu8rn5Kltge8D+Dv3YXtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZBlXhKzf; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZBlXhKzf" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so1045384a91.3 for ; Fri, 21 Aug 2026 07:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787321867; x=1787926667; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XGD/qJJ3KEj6zHY2VvUqP6PvO8ZM+d/JB8kcTXQ76+M=; b=ZBlXhKzf4u3gylpmMJdJ3hHp/8SYNJmXLySvRuJjz0Rf3LeOJQkbKRaqu5RpdJrdLq /EFOjsgy+6Ap7D7VA2OhcgUDBPJ+n3WHLUnfLMJCIzWble8ILb0IVRO8/HbZaLWZCkAJ c8B5lUPo3GXmstNIjkmfnzMdn1LH1oLK7uSwWYJWq2fxvGCiO7iypYzxu7lwaEer+2nV 8OrK6kwJdb/PW1px3XDJjSDvAHtIAOC1CYaeOocpmteCXf6WFFKU0fXnFwpJhC4+dGVV Pj4U43k8T1be5oFk4pKC1K6Zf/ZOuwMzlqVLb/0gROb7yJbULav615r0x87KjYaa5usq sG3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787321867; x=1787926667; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XGD/qJJ3KEj6zHY2VvUqP6PvO8ZM+d/JB8kcTXQ76+M=; b=ZyaDSQ0pG+9nF/jA4Bkg9zNo7kZ1WeZWCjHqym9rSk5tKvtl937vH2+Nquy8OzNlDy 27lOHvUPEjY9z6cMtd4JK6PoHXbKNEX5uyQCQM41WlskBE6APduGGxtJjFUm3zIXrp4x fK8rwbXETdODziy+0x84P3VbSA4XgSRL/4LJ39rObsoG9fG8M8Bl1mE+/vJF17dSQt4J Fsgz8tIEI90BSOJ4tOY56BHgwq3/PEer37bsV2oME6OoUwr/J2xHOSgFzIYhSlbyKAjo X4P/zuvTAa2f5B53YZViItSoYuYzpHN4g+OiCq7hAR4BiMt81i0nyfD2aypbJage0Zfz voyA== X-Gm-Message-State: AFuF++m7ZHNXlGsR+zVUQt/mOkBrCr79S/Gk0mHqLNupiF2cL+MTt0In E4X3oo9AuFIWHvQMhaYL3O7nSF5YbI/u8wur3/tpDTcSwId3yq0y90naIJSSgzth X-Gm-Gg: AR+sD13WnIqd3zulrVtYucbsHg4JMqqiyscgD7JRgkWbxwjpBiTblmyw+zU7Q0efIfO GNpVLPz1O+3i2BnocfW+RT5df3sFgEtUQgrFkXLYd5wqqbIPI4UY9PzDAuHfpGQYAh8zDitk3NC xVKnVWcwM45LUbog1hpYTu5Of2Z34kqMhekrBF66TEPfbgViYbE8108SvKq+zojtxNHVlqyrKOi /Th3D0x6Jq3LQVrzMW1/NrvMN+cSA5DirsjFO9kW5sJzrTBuBtaSH7HNfkrklaRo/IEpHpjL55s JoqWO72qcnJ8R0ubsuKdmctm/xje7KbQqeLhfwJCHTAlayDfhWuHuaUnLHb1IEGqwxb+m2AUM3g cof1j0d1nmAWYll3b9ALsvsCMgBcQsISrfuEcXOb4K1CsIIdoQnRRu6TC9ueATSsAj/yhYw5/ZJ pB7p2Wv3IPnAluNIIHiKHQeQKDH8T+3XPN1Q/Bfo7p9mnPl7kzUDFvXXG17gOocie6+4RSu6GuQ xnZ/kzc3T2aKzWCRKIzLQKxyLR69k/ord4cv6RBcFQxV1iTp7nPt3Ldh4rxbonOdhmK5Hi5oIGw Qw4uXEjgqrK9 X-Received: by 2002:a17:90b:5907:b0:36a:5d1f:7b6 with SMTP id 98e67ed59e1d1-395c33ed38amr13024301a91.2.1787321866681; Fri, 21 Aug 2026 07:17:46 -0700 (PDT) Received: from daehojeong-desktop.mtv.corp.google.com ([2a00:79e0:2e7c:8:f50e:ef36:528f:d8d5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1416ae5f1ffsm42250523c88.13.2026.08.21.07.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 07:17:45 -0700 (PDT) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong , stable@kernel.org, Christophe JAILLET , Chao Yu Subject: [PATCH] f2fs: fix error handling on device alias check in rename and unlink Date: Fri, 21 Aug 2026 07:17:42 -0700 Message-ID: <20260821141742.2678300-1-daeho43@gmail.com> X-Mailer: git-send-email 2.55.0.766.g2966f0265a-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Daeho Jeong In f2fs_rename() and f2fs_unlink(), directly returning -EPERM when encountering a device aliasing file bypasses the cleanup path. Fix this by setting err to -EPERM and jumping to the proper cleanup labels (out_dir and out) instead of returning immediately. Fixes: a737e409a3d6 ("f2fs: support dynamic reserve/release for device aliasing") Cc: stable@kernel.org Reported-by: Christophe JAILLET Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu --- fs/f2fs/namei.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 784f636244e1..b9b15c5d28de 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -571,8 +571,10 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry) trace_f2fs_unlink_enter(dir, dentry); - if (IS_DEVICE_ALIASING(inode)) - return -EPERM; + if (IS_DEVICE_ALIASING(inode)) { + err = -EPERM; + goto out; + } if (unlikely(f2fs_cp_error(sbi))) { err = -EIO; @@ -1025,8 +1027,10 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir, } if (new_inode) { - if (IS_DEVICE_ALIASING(new_inode)) - return -EPERM; + if (IS_DEVICE_ALIASING(new_inode)) { + err = -EPERM; + goto out_dir; + } err = -ENOTEMPTY; if (old_is_dir && !f2fs_empty_dir(new_inode)) -- 2.55.0.766.g2966f0265a-goog