From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@kernel.org>,
linux-pm@vger.kernel.org (open list:POWER SUPPLY CLASS/SUBSYSTEM
and DRIVERS), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] power: supply: Fix power limit documentation
Date: Fri, 21 Aug 2026 17:39:49 +0200 [thread overview]
Message-ID: <20260821153949.2914201-1-daniel.lezcano@oss.qualcomm.com> (raw)
The documentation for the input current and voltage limits recommends
using those properties for problems that can be solved using a power
limit. This contradicts the recommendation to prefer input_power_limit
for such cases.
Similarly, the input_power_limit documentation recommends using the
current or voltage limits for problems that can be solved with a power
limit, which conveys the opposite of the intended meaning.
Fix the wording to clarify that input_power_limit should be preferred
whenever a power limit can address the problem, while current or
voltage limits should be used when it cannot.
Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
---
Documentation/ABI/testing/sysfs-class-power | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index 32697b926cc8..f0ef87d365dd 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -600,8 +600,8 @@ Description:
supply. Normally this is configured based on the type of
connection made (e.g. A configured SDP should output a maximum
of 500mA so the input current limit is set to the same value).
- Use preferably input_power_limit, and for problems that can be
- solved using power limit use input_current_limit.
+ Use preferably input_power_limit, and for problems that can not
+ be solved using power limit use input_current_limit.
Access: Read, Write
@@ -618,8 +618,8 @@ Description:
input power to 5V when the screen is on to meet Google's skin
temperature targets). Note that this feature should not be
used for safety critical things.
- Use preferably input_power_limit, and for problems that can be
- solved using power limit use input_voltage_limit.
+ Use preferably input_power_limit, and for problems that can not
+ be solved using power limit use input_voltage_limit.
Access: Read, Write
@@ -633,7 +633,7 @@ Description:
in the supply. Normally this is configured based on
system-level knowledge or user input. Use preferably this
feature to limit the incoming power and use current/voltage
- limit only for problems that can be solved using power limit.
+ limit only for problems that can not be solved using power limit.
Access: Read, Write
--
2.43.0
next reply other threads:[~2026-08-21 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 15:39 Daniel Lezcano [this message]
2026-09-09 21:33 ` Sebastian Reichel
2026-09-11 12:06 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821153949.2914201-1-daniel.lezcano@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=daniel.lezcano@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®