From: Eric Biggers <ebiggers@kernel.org>
To: Thomas Huth <thuth@redhat.com>
Cc: Ilya Dryomov <idryomov@gmail.com>,
Alex Markuze <amarkuze@redhat.com>,
Viacheslav Dubeyko <slava@dubeyko.com>,
Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libceph: Re-establish the FIPS keylength check in the Ceph code
Date: Fri, 21 Aug 2026 19:36:36 +0000 [thread overview]
Message-ID: <20260821193636.GB3141245@google.com> (raw)
In-Reply-To: <20260821175312.GA3141245@google.com>
On Fri, Aug 21, 2026 at 05:53:15PM +0000, Eric Biggers wrote:
> Do Ceph session keys shorter than 128 bits even actually occur in
> practice? It seems that the Ceph authenticated modes support only
> AES-based cipher suites, where the minimum valid session key length is
> 128 bits.
>
> I wonder if the client should just reject session_key_len < 16
> regardless of fips_enabled.
It looks like this is theoretically possible only when CEPH_AUTH_CEPHX
is being used but the session key uses CEPH_CRYPTO_NONE, which seems
insecure and contradictory, and likely not ever used by the server. I
suspect the ceph client should just reject that combination outright
(and also session_key_len < 16 as defense-in-depth). It is up to the
ceph folks who are the experts here, but if there are unnecessary
footguns like this, they should just be fixed for everyone.
- Eric
prev parent reply other threads:[~2026-08-21 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 14:43 Thomas Huth
2026-08-21 17:53 ` Eric Biggers
2026-08-21 19:36 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821193636.GB3141245@google.com \
--to=ebiggers@kernel.org \
--cc=Slava.Dubeyko@ibm.com \
--cc=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®