From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD03433057 for ; Fri, 21 Aug 2026 23:02:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787353343; cv=none; b=FAtVqYfiuybyqzAYGjvPY7lT2tnXbEuahQpgGkdnG27b++emY/+d3nwZvU3hja92QOZ3MatAqZCrbTxO0lFs7X0ckD9rNUEWHiAhYvbkouoSER75fF24XjIH2WVDyXSvFE9qcir+Jf7PNs7jae+5xvFxP9FRwHx6IYgH/Z7+36k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787353343; c=relaxed/simple; bh=zEuLCi59FgV6WCQuPZcABSe4ao+KrlKHHo3HZvY3YY0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RRJXqeMMGAGdCtq+S0AbQNX0UJHGpetZ9y/57I+y7U1200xqVGcxsHEQi2z6CnExIsabeVLn/sNIycuntoYj4b0yRtb5UwZ6b4HgKfzl2epVmUTdJZhT0Ak8c57k+m8HZAuHQNVhZTXWxG8lKilBxW/g275i6zn2lcXOr+CIHu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EbVLIclG; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EbVLIclG" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e041ea211so1394567a91.0 for ; Fri, 21 Aug 2026 16:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787353340; x=1787958140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L4K6nlhSQEP7UWfmOQMCFoOr9zDgXdEDG0G8EbGfjZc=; b=EbVLIclGRwex0wSmZ2Kc/ApnQNeJrQlRsfkfJecq23U07vkP1xh8q6AbVM2uX2dMyv WsCLYGVLVuB7n4Bg6qgZ0xNMxwv/LTErqk98fAVFDLyYcQ5KBgdj7EqE267F1v0RMVh4 QGkYS33CKE2K3hxY2kNRVlb6maRWGgo7D8txa5tvtLEK9sKPHOyt/IcXlNSiJi0qqoyA YI6RW0k3bCVZ6Fo3z0IkVBfS3BuxW+ms4oMQN1Zx7/UTlKLZmY35tV6d98b42JFS7Dji +ouWp6k1hH0sFnhR+QtgGs+Ah/6fT0a2BOkedYP8jqGMWpANARyB9xf5O6BwHSN2uqov gMIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787353340; x=1787958140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=L4K6nlhSQEP7UWfmOQMCFoOr9zDgXdEDG0G8EbGfjZc=; b=Pa6JuFjHzEILuQ9NERKFFOn41EYpT/bFIk0NFPUiWpi94tlgRkNhUhPrtJMJnCdHEI lPb3y0+6I+pqiaksUuk/vx/5ZlhQXEraoHOdhZTIsGD2wY3XKfTC47BzD+wwe0vkihhl urI5KD8dMxmaBJyfXNeQNiBz20Xq3lAQLZgtFa63CC9+IzgKSpfAoRGHMNUPmqwu/b01 JNm/FJLhs+5adyw8qXmI5QzpgI8xkIkpGOhglS1W5fAXYvsFd4XuAcY+mHkxLt7UycSt Tq5EBQfvsJ/SP9U4fOdh1KLz3pHWUskuo+N4yJEKaY6dbLmnyNPVuBwZKEhE9qefPVsZ iEdQ== X-Forwarded-Encrypted: i=1; AHgh+RpkzPTeLfmLhO05Pz3/VvQtYKJ9Ldf7E4dzRCphcp1kKsrGMCjnYzNihxfrh9K4p8Sk1uIAjt3ldmNkmW8=@vger.kernel.org X-Gm-Message-State: AFuF++m6RzQGRffEFbl6BQ5uKC9QtfClsG5LSbBE/fYUggV7QM3Mfzqr rWHXRzlXG/S1gTf6TwvtbCBzgzgFRkgq+VxYqhWxEAf77zDddRH2e5nU X-Gm-Gg: AR+sD109cMMRiz5t2xlusiHyORqT+/xEhAPFURipUrVl1tURI8X3IqPGUAF6xR2vhmP foeCeTMfBADqYLegzqu9uHvnZWl+4f2joT0B5nr5wOD370iRM4Y7P7Nbl48qKiVIeq4lZoRk6EU Jzq86n/JpWW+uZkTr+1xNo9f4DYtVCAz+L4JTkCAMgXN5548sLRrgZe2Lm2XFNJiGa/Ig9bXIJA zuWC7mpynioPjT3zd3g2zYII1IGGOZh4p6tnRwONqHbB8OXlUVT5NU0CvodWt7JF3wY6H4MP9AV 9UOzdfXgLW6cWDfkyD78QZC7APdzu+8j3mTonpbFhcZNtEEtXQkrFwGUO4KpynQ/Aus8zJotixN u5Yqyrantqtf/g4niwxLaYPFonEjyKvKxXMFQcrS1QjLtMHnbQjH/Lssg961Yeb/PUERwqtU3im uSQvBjN9gYxQTq6Jssg+tYaHfWZRyjnWEBTr0RNCqU+fu3HrmetrojE0fcGToo2x1vilh/UczQX HRx25zAU9FdpE3B3+kt4q1X1CDd2FpyZJnJ5CVZnV8EElX0URuXJqs+2CjkZH5DnXYIi7bQoYGF 18E4azx+gtdmnErgSJKgMz9feSNk0l0BgrkoKA== X-Received: by 2002:a17:90a:f945:b0:38f:aab1:5148 with SMTP id 98e67ed59e1d1-395c35b75efmr17088863a91.13.1787353340351; Fri, 21 Aug 2026 16:02:20 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e49d8b1csm552044a91.11.2026.08.21.16.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 16:02:19 -0700 (PDT) From: Rosen Penev To: linux-i2c@vger.kernel.org Cc: Andi Shyti , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/3] i2c: ibm_iic: ioremap with platform pointer Date: Fri, 21 Aug 2026 16:02:14 -0700 Message-ID: <20260821230217.319418-2-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821230217.319418-1-rosenp@gmail.com> References: <20260821230217.319418-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit devm_platform_ioremap_resource only needs a platform_device pointer and calling it early allows handling potential -EPROBE_DEFER. Signed-off-by: Rosen Penev --- drivers/i2c/busses/i2c-ibm_iic.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c index 7c70e8bda24e..043cb64a2544 100644 --- a/drivers/i2c/busses/i2c-ibm_iic.c +++ b/drivers/i2c/busses/i2c-ibm_iic.c @@ -684,21 +684,21 @@ static int iic_probe(struct platform_device *ofdev) struct device_node *np = ofdev->dev.of_node; struct ibm_iic_private *dev; struct i2c_adapter *adap; + void __iomem *vaddr; const u32 *freq; int ret; + vaddr = devm_platform_ioremap_resource(ofdev, 0); + if (IS_ERR(vaddr)) + return PTR_ERR(vaddr); + dev = kzalloc_obj(*dev); if (!dev) return -ENOMEM; platform_set_drvdata(ofdev, dev); - dev->vaddr = of_iomap(np, 0); - if (dev->vaddr == NULL) { - dev_err(&ofdev->dev, "failed to iomap device\n"); - ret = -ENXIO; - goto error_cleanup; - } + dev->vaddr = vaddr; init_waitqueue_head(&dev->wq); @@ -751,9 +751,6 @@ static int iic_probe(struct platform_device *ofdev) free_irq(dev->irq, dev); } - if (dev->vaddr) - iounmap(dev->vaddr); - kfree(dev); return ret; } @@ -772,7 +769,6 @@ static void iic_remove(struct platform_device *ofdev) free_irq(dev->irq, dev); } - iounmap(dev->vaddr); kfree(dev); } -- 2.55.0