From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27F6A4334AD for ; Fri, 21 Aug 2026 23:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787353414; cv=none; b=INNj+APxsMmbXhWYPlye7agEGJJyniZxT0Pe+xb/0/0p1HqmBhnmBmxdx2iIN5NaZ97iZcH1mNuDLhSt3+PpIwJuUxkZ4Txzw5z2F5S3LX1VbkdPo6KHs4bNiaDuMKdMmfN/xoRHgsq74I7Q76PXlwDLQ//7rs0FUEc7bBLWfRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787353414; c=relaxed/simple; bh=vRkxmKuIl9ewBQmjDUYYaovs0Oj+7wYtFQbAfltlMyo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Izqjf+McVA8s/iJxxh0IuZYAGQVc2STE6dWdet1xpwWePEyWvN/ql9VpQ4cqkIUs5fCNvgWv5b0pry7ZNFJxcWhlB8aEMB1CFlzOwkVIhJiNCeIkjo3F5uNGigEvOb125ISQYLr3pXrKUNYN0WelSfV/I00rtN4ScdND6ENec5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=pass smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=gPke9Ls7; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="gPke9Ls7" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2caea3f742bso24685105ad.0 for ; Fri, 21 Aug 2026 16:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1787353411; x=1787958211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lBk9ofAY5su2wW8rAM+OgbzN/EaU3SA9gi2BVAiSaEc=; b=gPke9Ls782tLSG89e/0nDuGwg+QeQP7MokYATmTuGaDCi43o0b+NLSdEtjSbpQJND0 P6QAlwShQqO6IYhkqo7V3wUxqH2BYzLp+2g/tZ6Ex4h6FOSJMhijE2poghb36WRhO1Fy mEITg6QL3wGkHzqVNTgmDJuC7L1u3ps7KmLQ88srE8ITBWDnxVsOrVQUgy4r/KSxt4Fx aq3+z0B+8+1UW1qy9UpBiX6E7mtvmq+BYMZ3p2oxoSp+j2Cawol8oFnbpzhpYFCfwylN tfA2xu2futZ5GSNOJHmwBXMivSt1uP0hD3g0U2DmT0MHnoNgcolht+2l0GET+sTlSGMy pnrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787353411; x=1787958211; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lBk9ofAY5su2wW8rAM+OgbzN/EaU3SA9gi2BVAiSaEc=; b=b+6kDJ5aXM/lf2uXtbcWL3cL0nz0tdx+hEUbyvUKr70WpEVZggdRzW0MNDskRnyg55 +6aygHNHGj2GPuLQUtQ/OP+V6nkqr1WgZakM8u2Hym7l7OMt0WhYA954rKhYCFNCU8TF S7EdKJpbXc11Zyz3u55yEQmy897322TIq08RVuImcBPODhWpm/CV6anh5NHy7w62fyl/ VSnslbioyPry1lRj9W4mfbwijV7DIrRt5/nwlPMDz8jZs4YGJhMUeIdjhK450OlA6FDi QpO8WalQuK4egqSMds+elVggd+HPdWl4iev0IgcQe+qrnDFqJ8a1eXdXpjP5BeKxxaHP tb9g== X-Forwarded-Encrypted: i=1; AHgh+RoIGpSBUmODsWY0T8e35mWq3xEuBBCLm3TV4zdJlvfFM4ooOB3KqLYD8uUmCFKThc6XW3E5+Y94AFOpQqI=@vger.kernel.org X-Gm-Message-State: AFuF++loUiEWPwZ0jcB/BmPECg8CwhSDVpfAOhun58DwBkwuieABvUCP tEA0VKyiKap2H4DWydBZhBb1A14VwES4fHcRVoWuyZ5tVA1AmtvtpVMCgAc1PbY4owfyGerVMcI YHvx0 X-Gm-Gg: AR+sD11IuZNOMqv3IwQKZOwxuIJatFczyfpb8LniKIXwA5FrGhPORUQAsZa7K1yl8Vy XfvCjtyGfxMOg+8JF/c9uhHkAwV3dnMoLSxQDOqaXy+MNb1/dCw5DAlxPHXis+AjycQzWzkrjbv VMbB7/DsjzNNa/RLjKRqlb5KeXj/QFXoy9c7+65iZWC98NaQ8zR4racLKUcoS7b7Yo5GIfx5bA/ WeC2IFAZhli+pzPeomd2kGVZ01ezpAHJrg2+91Sn3PF+OLic/nYAyA8nzL8qNIOsXpJsCs/n5YJ HRvhDHAt3jg9OeLaVx+je81AK08TJ1nrApAYB9RtYgisubuTrcoFcWfpjx4xTK+vcAxbu2Zao6w S7PxDkJa+vObblopkA8hMQkbLkkPcrYgGBEBk1NjONXdX3KdBOPGCFsgwHrEI8hRm4oaV8xIPeU 4zAxlQKw/DkeTXkNWjzNln2cUk0PTGEtUvQK0phBHwWTg5FlYl6RTJNN62L8X6wg0ZcubS42ReX hcHCxQ2cizcOkqrf0ZKPTk= X-Received: by 2002:a17:902:e949:b0:2d6:3c2f:6a5 with SMTP id d9443c01a7336-2d64b1d68bemr198688775ad.14.1787353411263; Fri, 21 Aug 2026 16:03:31 -0700 (PDT) Received: from apollo.purestorage.com ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-327f909c6c9sm122799eec.6.2026.08.21.16.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 16:03:30 -0700 (PDT) From: Mohamed Khalfella To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH 2/2] nvmet: print namespace IDs as unsigned 32bit value Date: Fri, 21 Aug 2026 16:03:10 -0700 Message-ID: <20260821230310.3937527-2-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260821230310.3937527-1-mkhalfella@purestorage.com> References: <20260821230310.3937527-1-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit struct nvmet_ns.nsid is a u32, but a few messages print it with %d. An NSID larger than 0x7fffffff is rendered as a negative number, which is misleading in general and particularly so for the configfs messages that echo back the NSID the user just asked for. For example: [ T200] nvmet: adding nsid -16 to subsystem mysubsystem Print them with %u. The invalid-NSID error in nvmet_ns_make() keeps its %#x because the two values it rejects, 0 and NVME_NSID_ALL, are more readable in hex format. No functional change other than how the NSID is formatted. Fixes: a07b4970f464 ("nvmet: add a generic NVMe target") Fixes: c6925093d0b2 ("nvmet: Optionally use PCI P2P memory") Fixes: 5a47c2080a73 ("nvmet: support reservation feature") Signed-off-by: Mohamed Khalfella --- drivers/nvme/target/configfs.c | 4 ++-- drivers/nvme/target/core.c | 2 +- drivers/nvme/target/pr.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index 413ee2d16d29..6286e38436dd 100644 --- a/drivers/nvme/target/configfs.c +++ b/drivers/nvme/target/configfs.c @@ -814,7 +814,7 @@ static ssize_t nvmet_ns_resv_enable_store(struct config_item *item, mutex_lock(&ns->subsys->lock); if (ns->enabled) { - pr_err("the ns:%d is already enabled.\n", ns->nsid); + pr_err("the ns:%u is already enabled.\n", ns->nsid); mutex_unlock(&ns->subsys->lock); return -EINVAL; } @@ -880,7 +880,7 @@ static struct config_group *nvmet_ns_make(struct config_group *group, goto out; config_group_init_type_name(&ns->group, name, &nvmet_ns_type); - pr_info("adding nsid %d to subsystem %s\n", nsid, subsys->subsysnqn); + pr_info("adding nsid %u to subsystem %s\n", nsid, subsys->subsysnqn); return &ns->group; out: diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index d74c01c98f19..ad60b91ced6c 100644 --- a/drivers/nvme/target/core.c +++ b/drivers/nvme/target/core.c @@ -558,7 +558,7 @@ static void nvmet_p2pmem_ns_add_p2p(struct nvmet_ctrl *ctrl, if (ret < 0) pci_dev_put(p2p_dev); - pr_info("using p2pmem on %s for nsid %d\n", pci_name(p2p_dev), + pr_info("using p2pmem on %s for nsid %u\n", pci_name(p2p_dev), ns->nsid); } diff --git a/drivers/nvme/target/pr.c b/drivers/nvme/target/pr.c index 0948a690a1c0..09d8c63f5680 100644 --- a/drivers/nvme/target/pr.c +++ b/drivers/nvme/target/pr.c @@ -145,7 +145,7 @@ static void nvmet_pr_add_resv_log(struct nvmet_ctrl *ctrl, u8 log_type, log.nsid = cpu_to_le32(nsid); if (!kfifo_put(&log_mgr->log_queue, log)) { - pr_info("a reservation log lost, cntlid:%d, log_type:%d, nsid:%d\n", + pr_info("a reservation log lost, cntlid:%d, log_type:%d, nsid:%u\n", ctrl->cntlid, log_type, nsid); log_mgr->lost_count++; } -- 2.54.0