From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a6-smtp.messagingengine.com (fout-a6-smtp.messagingengine.com [103.168.172.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F30C1E7C18 for ; Fri, 21 Aug 2026 23:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787355095; cv=none; b=f7mlAPjqRDZuU1G/DBZ1m5lU778I8okfn8T1Bk/U5VDSgKhkTvZquzHqJxR/N4oXTgkGnFyWNplKhCVMAnMpauxShD96tjyKftqXzK3BdVbw2bgu5dORm7sUDAwKjx5OAjD3CInfLHppaOsw8Yogkhpt4ms79IPIooIC3q57RHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787355095; c=relaxed/simple; bh=JtDN0Adw7gqjeAmQGJ5oY6ZjlKOeQlVjpIEcMdgBdss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e0k+XdCNkMDdacTQtLV9Taiu+GwyiHHJGtKRcfeolziIQTCDpeWPWzOVQnnK0bKAicaqATy8N+nwkFtPvnka4xGtj6I5Mie3gxcLkEhRisAqjKli4LmOt/cPMRBl84CEuNX+2z8YciecGt8atbBUeYPXJm7PvBAJLGgpcFGvIPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=wgZgfbYx; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=QbOdAI4h; arc=none smtp.client-ip=103.168.172.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="wgZgfbYx"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="QbOdAI4h" Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id EC121EC00C3; Fri, 21 Aug 2026 19:31:30 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Fri, 21 Aug 2026 19:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1787355090; x= 1787441490; bh=5WjBFTV04ZiEdilwG2bvAuP45+lsa77/8QWKN6CIl6M=; b=w gZgfbYxiCuhE1jds1m4pMNKRvl6K4a7mG8554YTjUE6j2ZsWNsPNXkw3HyH09Ykm HRI69Vg8EZDOOStInxqVxHe6dSXow9lo04Q2FLy7JgCz0SX5MC8HlBxfG9f9sVjp hyyxPCbJUYYt9hRa+qV0g20Y1s0L6zsDAfNN5cvZP4PuJUn/U4R/AxQejmzmszEJ P/ItnNdPyfXwVuCUavG/avE1kv+zuxME67ylIKt0eMjhbM1RA8kmcMsa22MG5YRP qSlVwZ9ACQnKh9B1su0/l4pXOwNsW0SXfax9vD8vzg4SGInu5pY8aeY+lA4MbhLh gGKT8ZRaeHmuazCtIXBIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1787355090; x=1787441490; bh=5WjBFTV04ZiEdilwG2bvAuP45+lsa77/8QW KN6CIl6M=; b=QbOdAI4hM6+0jzPxa2HVeOCQTeG8Iqp745sLqvwE9kXpUTDajhy tPnWi9+uVfUY203MEjz+3fWPT5wSVYFoIyqvJig5eWe3g+jqoU2hUs6vE3wyH9Jc Pc+p7xKel7pRZHPH/Wsmxkam4LbG+m0cugPmgVpz09kANSbXjgCazLCt2JvvXyTL p0T0pLJcrRKJsEDMYJQ7sF+c2gSoCoBBffJJga0XwvPiG/CII8MfIeR0ZDoLfR9o +JzO/zblP8to/n2LX5bsaKeKaI/N4lHO9U+2l+ROvb89tJyd2L9d/BcLLVHh6TOf h8Lo4TnXZkAzEXvAyAgEEcMBO9m2D07kTpw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGCH0J8Y6C014DRIVx6XybI2+lDFJLTBQZ8LNcV0DQe87FKkKgj4J0ldBF4BPh8yX o6Osjuoj0iggH6/o4IL094EBX4fq/IJJISfNw2pvxsbwDUPAKHuwYL5GH2mi51r/7ydK8H Vp0ZuBtKI9baWpfC5bFRJAqY/qAD8Au8NC9E8Ld0y7kRJ3UpXnBb/oEUwKwXoq1pLSDnD7 L1kObHYBX7gvVYsSw5xM8dMkRNzc/EmPvzz/a8bQ598Wtsy7mOd9UimpjHAjXBoYTvXceK 35iJD5wRmGeEMsNzu4PbwikfyGftDOnJUdsGNFtWXIeLKdrmH2/KwhLsWDGJoMGOcs3lfr 2v43OHgkds+qVSKtQ56rHg6b2VsY24m4c9H/VRpihQfqqQEHYgefdBDOkDVli0RFVCEgUj v16ZEUlkixUOhJYUln8d878HveDWmkRxREWKrU4dcGOldSs/YBOEeNWiXmVmilfi+d8s3N lGp9QaupRAcPcnPDj2H1UczQOOZPB2UIXJnie5IGlA1T2NwACXZlQianIBE3OKnDdlfUxP nno6ayt+3kWyHlA4GKNfrkpKCljuz1O4DLnyMsqJvDWg9cFAK8nC/0MTDIllbZQJbXQ3w+ 9dJuQ6IY3m3R6nRHHOrkdYbHiPo7L1hH1X8Kg3Jp1JS3mAWXe2ziiaZ9hqaA X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 Aug 2026 19:31:29 -0400 (EDT) Date: Sat, 22 Aug 2026 08:31:27 +0900 From: Takashi Sakamoto To: Triet Hoang Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firewire: ohci: Convert to DEFINE_SIMPLE_DEV_PM_OPS() Message-ID: <20260821233127.GA243355@sakamocchi.jp> Mail-Followup-To: Triet Hoang , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20260820083034.2087217-1-triet.hoang.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260820083034.2087217-1-triet.hoang.dev@gmail.com> Hi, Thanks for the patch, however we are currently in the middle of merge window, while the change is not for the urgent issue. I'll postpone applying it until the merge window closes. This means it will go into the post-v7.3 kernel. On Thu, Aug 20, 2026 at 03:30:34PM +0700, Triet Hoang wrote: > Convert the deprecated SIMPLE_DEV_PM_OPS > to DEFINE_SIMPLE_DEV_PM_OPS and pm_sleep_ptr(). > > This lets us drop the __maybe_unused annotations from the suspend and > resume callbacks, and reduces kernel size in case CONFIG_PM or > CONFIG_PM_SLEEP is disabled. > > Signed-off-by: Triet Hoang > --- > drivers/firewire/ohci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c > index 46dd53ecedc7..b7df280bec51 100644 > --- a/drivers/firewire/ohci.c > +++ b/drivers/firewire/ohci.c > @@ -3761,7 +3761,7 @@ static void pci_remove(struct pci_dev *dev) > dev_notice(&dev->dev, "removing fw-ohci device\n"); > } > > -static int __maybe_unused pci_suspend(struct device *dev) > +static int pci_suspend(struct device *dev) > { > struct pci_dev *pdev = to_pci_dev(dev); > struct fw_ohci *ohci = pci_get_drvdata(pdev); > @@ -3773,7 +3773,7 @@ static int __maybe_unused pci_suspend(struct device *dev) > } > > > -static int __maybe_unused pci_resume(struct device *dev) > +static int pci_resume(struct device *dev) > { > struct pci_dev *pdev = to_pci_dev(dev); > struct fw_ohci *ohci = pci_get_drvdata(pdev); > @@ -3804,14 +3804,14 @@ static const struct pci_device_id pci_table[] = { > > MODULE_DEVICE_TABLE(pci, pci_table); > > -static SIMPLE_DEV_PM_OPS(pci_pm_ops, pci_suspend, pci_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(pci_pm_ops, pci_suspend, pci_resume); > > static struct pci_driver fw_ohci_pci_driver = { > .name = ohci_driver_name, > .id_table = pci_table, > .probe = pci_probe, > .remove = pci_remove, > - .driver.pm = &pci_pm_ops, > + .driver.pm = pm_sleep_ptr(&pci_pm_ops), > }; > > static int __init fw_ohci_init(void) > -- > 2.53.0 Thanks Takashi Sakamoto