From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEEB33D7D8E for ; Sat, 22 Aug 2026 14:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787408725; cv=none; b=eKlcMtHxr4v87DO/NDdzIDH1q7NlzmwlvcJ9NYqIPYl6PcLH0qkSvN9CLn6wwglKjLHJ5W2iPxYmQPyhZ9KS88ZswE5CHkW1btMVErbpeo1XKgLECpmj8oB7dBFT2pu40EXXQ32lJNHyDIdfev+1tM18Lb1HVPvf2K5yPy6r5Hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787408725; c=relaxed/simple; bh=JohAOoCNGkQRZL2E68Xhgl4IRplg1FotNZ60cFKNAGI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bYRYRxeyU4b3HR3frAvfoZ5aM811Kx8kfiGWfLQ9bgsqIBMdPiszB7Gl9QqIancuqyITvOwZd32Gu6MmTaCYg81Nf809JRWtFCMikX76OBgNtp1D9IWem8b2EmZ4vvwKpBK1RodIaUA943EZHsUO1kVYtUfDHW+e73sYH34NlUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=StKDbvt+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Htff296H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="StKDbvt+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Htff296H" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67MEMLi71026541 for ; Sat, 22 Aug 2026 14:25:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=lqTmiWxZbpG p2Ca8WwMlm9SHBAl/t1NnsRYU6QY5Ozw=; b=StKDbvt+5piXpjLAhP9AktDQ8y8 ACGisiKZggddR+xQ1CneH20c6Of6zZzGcwYjnUGg30JEmwLc/d0LNkpXy1s3vOeC 2DhHb7a2tg1epzgl2RBoIzBsg2021XhLbHERwepy2pVGrSem535zOGAj6/o5i0YM uPlljr5gBc8I1cRHpiuR9Uy/LT0uWTtTc5Ld0V7aO1xVfnkW/EDYUMNPoxIseXgD d0FsBAsdiBBTWq5Uwz99Gdy84WuW6/quzo4/Ajg80RdOkI5vCrMb5Wy+5Sqn06vx yNQNuKS03z5bjsB5OVd1TBBGST7lxglbyBTGjdwvtB7UIk722GerhHy2Atg== Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g74hcsasv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 22 Aug 2026 14:25:13 +0000 (GMT) Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-66c70f73f8dso5409111d50.1 for ; Sat, 22 Aug 2026 07:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787408712; x=1788013512; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lqTmiWxZbpGp2Ca8WwMlm9SHBAl/t1NnsRYU6QY5Ozw=; b=Htff296H8ByDtSZ9FGmT+Er3eoXKzRTGtC6MViFlU4LaMk/g2s6LvY+DcZyFNx7u8k hVEKN/uSYmPwPtdejvve2A2TVhzUBcgThrXX4Xn9RWHcdNNiyiJH9aKDEy0mOB2HURiN 2QzOJspsf60GLHFiFnGUkk0HvE7vrN7GW/xTB13yAlf/UEpT/G9LrCoAvYtUDt4nXjtS IuqFlFk/mb6oqKdAvXpHVUjCvteRNgP6ajwMyvVT3/BpG34F9244+yVOsNi9CsRZbVpD Bp1HswhskffVR5WEXk++5F9M78qmEuQrBaQsTUyT5ltLnN2DJk8Hu4nabIC34aELUieP jtRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787408712; x=1788013512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lqTmiWxZbpGp2Ca8WwMlm9SHBAl/t1NnsRYU6QY5Ozw=; b=ncFf3nwjsTTNHrjw/lNG3OXVdAPXhN4vWkjZhOjzUJPBJx0a1O2m6RmOMLws3UpXK9 +1EWrvxSpE3iWcFZetNPxLUmrfiQuOF+ixbsWPJrOEqaMmUpYU2XS5HzfX0v9NDp8VTt jcDPSwTD+UM9nnxIR8oHnYPO0x9IrRFpYyqItmiyTcQlMSxSGHSs4GPwbHXYbeWoIa6g eiGlp7+qpvfQR3G/VfIl4oeug5AWH8s/EHlGeJMp2QvL9ZLdCFQWN0okPXJasF8HlOO4 0cs44apGd/VUMzoKGvWTgriBmPmBQjSh29oHaCZGVgS2ALb87UtDDYi3UsyU5YvsqUdF p2ww== X-Forwarded-Encrypted: i=1; AHgh+Rqi2yR/a1pD6kAFrFrdgoh7sGXuqVr1UpRgoadmMYZAdl0Kj6iIRIJ56frVthN9aUYu88L2IKJDdnu9YXE=@vger.kernel.org X-Gm-Message-State: AFuF++mVaxZVHkMkbc6g0fEM+l8tRLOrzM1I8XM8egF8XmUBAAik7hf+ /j+DbFV0fkZTEhhDEyNELYYEYul3JWo1q1rhthmOTqdkrP4W1rfkoo3VQJAs9GGzrLNJUv6GuR7 a3Edgbqf/ELtaX1G6sKMponY77gQo56nytIyXfAA+TqtFDuwLMdLR/s7AY7I+BuVcDZw= X-Gm-Gg: AR+sD135Dx20ou9ZAwITQpjVM+EDrXG4wIzaTRmN2Y6w4O/MDH346GFCpPTe8a0YN36 +WgRCNKIYR3T4sf+/yfWLDikVUC/i64MeDS7P225zWsrObP8gi7ejtMd6TtLeL2X71ebwSlfudN KplSrzv6YttouvyegX8/JpBMioRa8WCgxBcWAGJUD3CzV+tr1eU0Egyrtt4PkyMTz/l06ezl13D ZLzn7o7gaRCtFxBuP4/x27LF36+T3XZpURbzPNKphmdFQQaTUoxud19UpPn88oPFaL2JrgX25RV DuflhF0M/DobAEbyIxzi3N4zYQtF2Wp9cRRtzbbNDbpQsJzpOIPgmNwKUWM8NtO2LCB4QOjwozo Vkkw13eElZ/Wil987dx3kNruiIaTwXF5eY13aZpY47+rilg5qFA== X-Received: by 2002:a53:cc8d:0:b0:667:a285:7624 with SMTP id 956f58d0204a3-66ce4b02a7cmr3827521d50.35.1787408711891; Sat, 22 Aug 2026 07:25:11 -0700 (PDT) X-Received: by 2002:a53:cc8d:0:b0:667:a285:7624 with SMTP id 956f58d0204a3-66ce4b02a7cmr3827510d50.35.1787408711459; Sat, 22 Aug 2026 07:25:11 -0700 (PDT) Received: from agents-mac-mini.lan ([2600:1700:b450:a0df:b4ea:69ed:306f:23dd]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66cf46460a1sm931442d50.5.2026.08.22.07.25.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 22 Aug 2026 07:25:10 -0700 (PDT) From: Jason Pettit To: Nabige Aala , Vinod Koul , Neil Armstrong , Wesley Cheng , Abel Vesa , Dmitry Baryshkov Cc: Jason Pettit , Ritesh Kumar , Mahadevan P , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: qualcomm: qmp-combo: update DP PHY PLL programming on Glymur Date: Sat, 22 Aug 2026 07:25:08 -0700 Message-ID: <20260822142508.25473-1-jason.pettit@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260721-glymur-phy-conf-v1-1-7c8909552c5e@oss.qualcomm.com> References: <20260721-glymur-phy-conf-v1-1-7c8909552c5e@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: HKxDhFxz_U9V56ITZ4SpRFcVYyyck6v_ X-Authority-Analysis: v=2.4 cv=U7iiy+ru c=1 sm=1 tr=0 ts=6a89b149 cx=c_pps a=ngMg22mHWrP7m7pwYf9JkA==:117 a=xqWC_Br6kY4A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=RQBTEf8xbrG97JagYZgA:9 a=yHXA93iunegOHmWoMUFd:22 X-Proofpoint-GUID: HKxDhFxz_U9V56ITZ4SpRFcVYyyck6v_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIyMDExOSBTYWx0ZWRfX4BxiFDIZbPZh IeqSV1cx/KOmmeZYXDyhoSahfcfCKEnenZOFUQAiYE+vzRIqonBPmT66YwlW2xK6BdIx3ZV5k5o emIiRgqOGgktQlzUdQ+HGoNnBI9L5hre1naiAFsuJnIcwmejxwiqQILFtNneBoR08B38Dvhr7kT MKA+3dcSv02zgEgBfu1HCTB2f0HXVqp1hLaCn0WELwO/A34sErRIjqkmT99oJoXoGXG22hLFx7x DluVA0c5w9oRKFU0VwsHtXR9xOnH66jPRpVUs4bkr2PNyQTlRhvZbtSzYfVTasm33FSe7uqJKHQ ElS7Bs2gHx8Ru/66tf47VB7yxv0h0WyBu3TTUyzzPK/u3Xrw0WBP61XLxbNLwGrZDazvl6qnDMi R7RPrUhWiQH1CPaLvqMuRN9Tx2RtPwEdBRI049FC0+ccNpav/ubdDYjkcf++oY7ufq5yEulAPZs Gk51Z1vEkyWwl4lBxpw== X-Proofpoint-Spam-Info: AW1haW4tMjYwODIyMDExOSBTYWx0ZWRfX1JVXm+dwAtzy Vr6XK9Uo8Zpo2PSftcjIV/QRuMClaP35QqCGR4PIH78tiTKMIge5BovP2ce4nQzezKFtnFyZo/R SbMRCJe7IjY1VXa9RqRRvkDrP9xxkLk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-22_05,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608220119 On Tue, Jul 21, 2026 at 10:48:33AM +0530, Nabige Aala wrote: > +#include "phy-qcom-qmp-dp-qserdes-com-v8.h" That filename does not match the one accepted upstream. In Linus' tree the header is drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8.h The "dp" and "qserdes" components are transposed. As written the build stops at the include. drivers/phy/qualcomm/phy-qcom-qmp-combo.c:56:10: fatal error: phy-qcom-qmp-dp-qserdes-com-v8.h: No such file or directory Dropping the line instead is not a fix, because the patch uses two symbols the header supplies. phy-qcom-qmp-combo.c:321: error: 'DP_QSERDES_V8_COM_C_READY_STATUS' undeclared phy-qcom-qmp-combo.c:322: error: 'DP_QSERDES_V8_COM_CMN_STATUS' undeclared Both are defined in phy-qcom-qmp-qserdes-dp-com-v8.h, which has been present in mainline since v7.0-rc1. Correcting the spelling is the only change needed. With that one edit the patch builds cleanly for me on next-20260821. One other thing for the respin. The patch no longer applies with a plain git am on current linux-next. The include block gained a line in eca0e717aab1 ("phy: qualcomm: qmp-combo: Add support for Hawi SoC") so the context of the first hunk no longer matches. git am -3 applies it. One process note. The subject line reads [PATCH], but the changelog in this message reads "Changes in v2". The revision is therefore invisible to b4, to patchwork, and to anyone following the thread. When you split this into the smaller commits Dmitry asked for, please post the result as [PATCH v3 0/3] rather than starting the numbering again from [PATCH]. That keeps the lineage traceable from v1 through the split series. I am carrying this patch as a prerequisite for HP EliteBook X G2q board support, so I am happy to test a v2 on Glymur hardware. Thanks, Jason