From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6C83911C6 for ; Sat, 22 Aug 2026 21:40:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787434855; cv=none; b=YYFgi4+QGUdj3lRbWE+SmQ8zTugONNT4muxrgHqHoPUlD5L7iKRB5Cmi1iALVydiiL1Yvyk028i7mkes5X6DFzPDDn25yssF3tFKLifkvxfGz3QxniG69c/qyJm67NjadbvNueUnnjL5BS5YHy8xz4hVh33Ky4pSVsjvncdRJhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787434855; c=relaxed/simple; bh=nUNbmShuRQtFklLJUC7OALhPN/3USFry3dwtYtcWKow=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rUtcg1c5fWAlH02G+eKmkRGU1UBz8xd514KlPhVcAPyfDIzJkAMHQbzYihGa+dTDxtJ5uAOD2UOTX9WbX1oUM624jGD7DouAlNFFGQZSWNhu1qygYDFELdxFWQYd6jY+ntjy3Rgh8rj6lwHM0TGblAg/Za3EBHYJFqSEvVqNszk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kBWjGRVQ; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kBWjGRVQ" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-c15d3cd51b2so345047066b.3 for ; Sat, 22 Aug 2026 14:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787434846; x=1788039646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JMqBfKwQvAfQXaOYyEjha8jlIKlrCWyN6q7aDWdtxQg=; b=kBWjGRVQ5Tsqfej/Q/PXV0Qkvw43nVbNz2LERrDYIddPeRUnUwsv04llgVcbZWUqwP pjmMz2vR160XZ+WiWza1RyxZ4znOblNF6KZw0sPU3zoog8Tx3iJkw9x/GAdp0bFDSsKH pSaRx9jjghROZ5YguUPn4hfrj8aymIOYGTqyHz9kYyrVomSrHPJIEmmbN3yYhYCHNIxp IUEnSbQOuJF4+IK6DO+BwFP8MaI8IEYYri+GxJfwMfIDqw7cb1nZmmz9ehXnnIzwLDXn aZ+J1+70mXCfzIG4u9eRfxyY3eXJAr9s/nvgbhcEG/AwHaCXNsf6elrcDhG0RN669zH4 +Byw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787434846; x=1788039646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JMqBfKwQvAfQXaOYyEjha8jlIKlrCWyN6q7aDWdtxQg=; b=cDbJoiCL3NeM7hgdyMShByRIJcS9AsqBviJCmWS20zSAElFilX+rNqHoAzXjwWqWmI DEiCTXEd1GmlxVJ/QhXp2w4l9m0um2q4KoaZyTsfdZduILhdQu57yVSEAHqhb5UQLJpL oYcjMCnzOPhri2U/wsNfuMtSY0gUGKo062AwdXNga8P4rTLKPpynicX6HPBngzqKvixd IVMjc8r1qaoioN+RO1MZ5txrKrt6LfR5QIo+z2GSmXrN6IMgK3WvoHcyznomZ8V9O+rj H2pAFOzG7TbvJKJ3fNx6ZzTVx/I5GLmu7qP10voar45Zz/R0o3Drq2NwYqSfI4hYUFnE 6Lbg== X-Forwarded-Encrypted: i=1; AHgh+RooC5sz5xKyzqyMlJPlPqF+uzy4frFhyhGT72+/Ixwggl7CVhgy+3+LI1+Al3lV+NeCUM45sPxmcwfbPN0=@vger.kernel.org X-Gm-Message-State: AFuF++k8ipeT0AGOwwU1xydwghV0pJ8FIgfv2T3kddATmeQLrRfXepmS N1FHQVkDgh7f2Klpai0Nl6ch2AaQj3svpE4mN33XYz3IHx39w164NFFqGEopId/Y X-Gm-Gg: AR+sD12Kpch9fYuEeo5eXGh8JTBPCHg2+XRcav0KpC0wJ3An7I0NifXOyS/gk/4Ktku ynnfQcZ4KbNeQYIGdCsl0KZZBmC5TrIHZlDg6Oa+KRzj4Ob0wcYxX0ELeocUfvzf1SGIFuyT709 s3IpdHeSHwDcgP7zuU8m0mIS27mutql17a+/NkWk+o38T39od4OxMW6k/Nx45OEOkJdaLBYk+LR pGkaJrZ+8c0ylqFUEkZs6vva+65edIsHt+NpHofeo+CrbMGEta1HVPHEl0lkoOIz5zZa6gH7GmG LROoOYz6ZqT1v9AuM3+zGGGcmo5JmKXBFVOAW7ye26IytbYK2WuR+irZi4NBuVbrTXylbHcdNNi iiG/OOkQR4W14iyvDCJsDZE5Gmfo7kCLTtcXj9ujfeGueMdIle21lvMjLdl2ly/iNZ0LO2bj7YA wMgOQu+ySOaIvSSFrfVNnlbyRHrn8DVje+6kgIpGALBAh1hPU1Cb4Tomh/BbU= X-Received: by 2002:a17:906:9c93:b0:c24:6687:bf6a with SMTP id a640c23a62f3a-c2492663ee3mr836396066b.21.1787434845967; Sat, 22 Aug 2026 14:40:45 -0700 (PDT) Received: from m2.. ([37.142.151.124]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-c24966f99basm466778466b.37.2026.08.22.14.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 14:40:45 -0700 (PDT) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Germain Hebert , Rio Liu , Bruno Giacomazzi , Christina Quast , linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH 10/13] HID: ft260: uart: fix active-low RTS/CTS/DTR/DSR polarity Date: Sun, 23 Aug 2026 00:39:38 +0300 Message-ID: <20260822213941.98882-11-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260822213941.98882-1-michael.zaidman@gmail.com> References: <20260822213941.98882-1-michael.zaidman@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Rio Liu The FT260 modem control GPIOs for RTS, CTS, DTR, and DSR are active-low. Invert the TIOCMGET sense and the TIOCMSET drive levels for those pins so userspace ioctl state matches the electrical lines. Leave DCD and RI unchanged. Signed-off-by: Rio Liu Signed-off-by: Michael Zaidman --- drivers/hid/hid-ft260.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index 0a1875a1a7ec..a2f4b6e5a16b 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -1985,10 +1985,10 @@ static int ft260_uart_tiocmget(struct tty_struct *tty) gpios = ft260_gpio_get_all(port->gc, FT260_GPIO_VALUE); - return (((gpios & FT260_GPIO_B) ? TIOCM_RTS : 0) | - ((gpios & FT260_GPIO_E) ? TIOCM_CTS : 0) | - ((gpios & FT260_GPIO_F) ? TIOCM_DTR : 0) | - ((gpios & FT260_GPIO_H) ? TIOCM_DSR : 0) | + return ((!(gpios & FT260_GPIO_B) ? TIOCM_RTS : 0) | + (!(gpios & FT260_GPIO_E) ? TIOCM_CTS : 0) | + (!(gpios & FT260_GPIO_F) ? TIOCM_DTR : 0) | + (!(gpios & FT260_GPIO_H) ? TIOCM_DSR : 0) | ((gpios & FT260_GPIO_4) ? TIOCM_CAR : 0) | ((gpios & FT260_GPIO_5) ? TIOCM_RNG : 0)); } @@ -2013,13 +2013,13 @@ static int ft260_uart_tiocmset(struct tty_struct *tty, mutex_lock(&port->lock); if (set & TIOCM_RTS) - ft260_gpio_output_cfg(&rep.gpio, FT260_GPIO_UART_RTS, 1); + ft260_gpio_output_cfg(&rep.gpio, FT260_GPIO_UART_RTS, 0); if (set & TIOCM_DTR) - ft260_gpio_output_cfg(&rep.gpio, FT260_GPIO_UART_DTR, 1); + ft260_gpio_output_cfg(&rep.gpio, FT260_GPIO_UART_DTR, 0); if (clear & TIOCM_RTS) - ft260_gpio_output_cfg(&rep.gpio, FT260_GPIO_UART_RTS, 0); + ft260_gpio_output_cfg(&rep.gpio, FT260_GPIO_UART_RTS, 1); if (clear & TIOCM_DTR) - ft260_gpio_output_cfg(&rep.gpio, FT260_GPIO_UART_DTR, 0); + ft260_gpio_output_cfg(&rep.gpio, FT260_GPIO_UART_DTR, 1); ft260_dbg("dirs %#02x vals %#02x ex_dirs %#02x ex_vals %#02x\n", rep.gpio.dirs, rep.gpio.vals, -- 2.43.0