From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E29453911DF for ; Sat, 22 Aug 2026 21:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787434846; cv=none; b=DVV58Dqq5FeObYMjHsBQQVEf+BKlfnGk6/+DWNjaybRZDQHHMi2MtDxwQ15cCqvz+GpJdZCrd0QYrTf3A+FnuNiHWX9foW0eMxkipHPw+m1tKW5E6VNHEzQ+TgbD3dz2lxfTZSbeUx7hrYKE9Cqy9FlIzgOQKK5frbp92MncRCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787434846; c=relaxed/simple; bh=O1b4qJuU5h0jkjtN1tmFHZg98/5Kor0pOfpmFSJmhKo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YfXdSko44AJX+0orZ0772JyndFkuwAwDuGRniwOS2pOW6a3Ux01YSLIlvR5Trwy/GdaUBHeL5LY7TGHG7msGxTwH70En6y2OmvgWmBNIKg2jVZTwG5nHfD6FZttYyVb/ZCXs1DxIoqTPxVkrDy+QQv31apftptuF8oKKb8tPUS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cv/DmAO0; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cv/DmAO0" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-c207cb16cf5so349494866b.1 for ; Sat, 22 Aug 2026 14:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787434839; x=1788039639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7d0fiyXH8Gw0QiNflyUYHvDRi8XIlp2AkUMiyQfpLiI=; b=Cv/DmAO0fbr4HMZI6EQTZ1jjqyYgFpkJODZ7fxs+QkhM/iphqwzhNkTIenH0HihBWb 3AyRVV20O8AYDEsZ+SNdQ7tgUWJV/6g5z+o7+o2SpQdYrLIQMNwAsIns9oFyfMRb+SW/ 9pNZfSFNAPd5waFOWbY4wXqZJ++Cd/C/xMMXCdYOQSCl8U0MzlIzeWQS1M7EiYT1bRJD pGzw3Gc3a7y9qHEtk0/6gGTvY3W9jGTi1XmWX14ZFNHPCOm8ZXtQ+8EgmEHRroDVxPWT W06y0AkTSkxhS5I2dOhT1ypRjBkuPZPttybBv8WMzLBjo1Hk4OVyhOWsZ0QF2iEKidAe osZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787434839; x=1788039639; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7d0fiyXH8Gw0QiNflyUYHvDRi8XIlp2AkUMiyQfpLiI=; b=E/1hpokV8SEbrx2mOSE89dIxAyoXorVJsXcJixRbOuqxcZ4ZQJA9iRlwCCrjB9hsTi TtC7/SKQqgoqBpAv+6ER2rDjMJutO8OhrlCYJBM/CPipEHzxsIsMrrvlhyuwCqk5QgSK 9DOik0oBM4/ipYa0CJ8oLibc5RQZOX8f422E0QS4ClRXoJRYb4Xc0Wlsdi0ojK13ie9m 27bNeIZzv/anEPZDFTkBN+MMAcxficlZojcrdPO19Vnf3pEnIqMpxuwcqQI1F6cJMYnw UH7kDekjsvQpNsxCxcIQ4lYE+cbIkwUSJM7Gq3fwtzbB99AHVBC09lcXgG8XDDEazkAF G5tg== X-Forwarded-Encrypted: i=1; AHgh+RrFLL68NFPK/VzNRugUlIiFq95cMnnQtPz/dLDqc8yQP1tcBuqhnYiyZaDjIpJ1bTjZ7J5mDCi0K1bB46s=@vger.kernel.org X-Gm-Message-State: AFuF++lcZKNxAQYDHJ9eGIXhMswgObNT/GntCFggjNVa3jt4hEweZjFE w18p5y9IFV9BKzgUgeVNiQGBkkGLlYow6b1Wnf+kQefDKb/nm7zt7Xwe X-Gm-Gg: AR+sD12ykE4V5gDs1ZcyEaw/iar6ttj9fz5BSsG8Ou5HQaFHEHaZTFXxZWsbikMoOeL /nJcxYStBXmFVg8URiIrW0iAyjsxORlkQz2fo+1Jn/yLo6Hh/nlcbnI2QgK6ggwwywVFY/eJk+B UaOc2Yvn3FNS2A7Lz2Lf07mJ0DTorP//MSR1tn+Ucz6CjuROf5+qe6z/hC+LFdy21m6ew11Vuyg J26XjWhIrNbKU6PoDGz5frrgA4LRv4c1hfRlczGl1w0TPeTiV6tSgbWlg3PUZP+fYdwCd/Ss+HZ OZrwGiCGRIGiJYGV87h/whtdJ5Olm0vmnAPe1yYnVDD1yMBtBREjdGTgrggPRDy9bBdxsRubfXZ PJsSc2C9bSkOaSWhqioBGg05uYZIVrKTDY3l/Eymqc0f2dDyV8SPb6/eB6VNiX2DII91kmQb3wl q9GYe55W1y25FpcCyCwDIMotVx4am1RQ21LaYQ7KYVHk8248fr7CeAq2Volm9BJsN94OdLdQ== X-Received: by 2002:a17:907:3e2a:b0:c21:7feb:4574 with SMTP id a640c23a62f3a-c246a2cece6mr1544595666b.1.1787434838519; Sat, 22 Aug 2026 14:40:38 -0700 (PDT) Received: from m2.. ([37.142.151.124]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-c24966f99basm466778466b.37.2026.08.22.14.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 14:40:38 -0700 (PDT) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Germain Hebert , Rio Liu , Bruno Giacomazzi , Christina Quast , linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH 06/13] HID: ft260: i2c: reduce bus-error message severity Date: Sun, 23 Aug 2026 00:39:34 +0300 Message-ID: <20260822213941.98882-7-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260822213941.98882-1-michael.zaidman@gmail.com> References: <20260822213941.98882-1-michael.zaidman@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver logged errors when the FT260 reported an I2C bus error or when ft260_i2c_write / ft260_smbus_write failed after such a status. That was meant to flag unexpected failures, but bus scans (i2cdetect, HWMON discovery, transceiver monitoring, and similar) hit missing devices routinely and should not spam dmesg with either: i2c bus error: %#02x ft260_i2c_write: failed with -5 Keep returning -EIO, but print those via ft260_dbg. Still use hid_err in ft260_hid_output_report_check_status for actual HID/USB transport failures, which are genuine errors. Signed-off-by: Michael Zaidman --- drivers/hid/hid-ft260.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index 8db896f164cd..1ed3701eaaf7 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -565,7 +565,7 @@ static int ft260_xfer_status(struct ft260_device *dev, u8 bus_busy) * to 1, bit 1 is also set to 1. */ if (report.bus_status & FT260_I2C_STATUS_ERROR) { - hid_err(hdev, "i2c bus error: %#02x\n", report.bus_status); + ft260_dbg("i2c bus error: %#02x\n", report.bus_status); return -EIO; } @@ -599,6 +599,7 @@ static int ft260_hid_output_report_check_status(struct ft260_device *dev, ret = ft260_hid_output_report(hdev, data, len); if (ret < 0) { + hid_err(hdev, "%s: failed with %d\n", __func__, ret); ft260_i2c_reset(hdev); return ret; } @@ -638,7 +639,6 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, int len, u8 flag) { int ret, wr_len, idx = 0; - struct hid_device *hdev = dev->hdev; struct ft260_i2c_write_request_report *rep = (struct ft260_i2c_write_request_report *)dev->i2c_wr_buf; @@ -669,7 +669,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, wr_len + 4); if (ret < 0) { - hid_err(hdev, "%s: failed with %d\n", __func__, ret); + ft260_dbg("%s: failed with %d\n", __func__, ret); return ret; } @@ -685,7 +685,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, u8 *data, u8 data_len, u8 flag) { - int ret = 0; + int ret; int len = 4; struct ft260_i2c_write_request_report *rep = @@ -710,7 +710,7 @@ static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, len); if (ret < 0) - hid_err(dev->hdev, "%s: failed with %d\n", __func__, ret); + ft260_dbg("%s: failed with %d\n", __func__, ret); return ret; } -- 2.43.0