From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A64BE37E5EF for ; Sun, 23 Aug 2026 17:59:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787507953; cv=none; b=nmZW6xqQHD84F53qPNozWYcT1n2SAsEpRWETpsVWkm/F4/ReweyTe99m1DjBLCTfN6c1cgwV02vGdCrIqXiblFaU1DjEh0z2bJJKL8yXgUph27q37YssEK6r8/4b0JK1bLQsJMhPsX2xtBmTg9DW8RzH3E+JM2bC9Y850TTaEJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787507953; c=relaxed/simple; bh=fLQQ4JIzzuT4Vt7XQPvCoVjlsMWHJ7PoqIP957VnMqs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NmVLLNdNHSMmRbn9mmKtFVHWeI6rtKoTDOwn2iDKIOjvHoANHGsY3rYqrnElGkcFyHZhrJVPTH2WV/+EmHO3VYDr/OMKraujxI6cCCvPxs6dw+FrsKIptvvPr0fhjccSEYFz9t2sqfRVfMEcKJH7H2Tw+uVUHJ3DKNuInIBRJTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=inNZalsl; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="inNZalsl" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6a422090b14so3711108a12.1 for ; Sun, 23 Aug 2026 10:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787507949; x=1788112749; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I19+PjIQNnODooxQ97qMirgzt/rnck5BIrQXPDznt18=; b=inNZalsl0ANHa0i+w0ICoAxv26GI6qIZPMzA6KRbd3R3jgUMQuYdi0CGDsSiJ0SLek nyZOfRfhBNZCFJradEUCw3c+UCBPiqhpy1yJeUSNac6VlwfLEZoRad4aPfOIrMSg84oV 9Si0OT6kIpP2jee34x/Gfj984q6L70wnvKk2O5tuRNz6u2p7ektcOkgMwbszSEg6a8Yq 46IbboLnDni+S3ciQic8n7Tp2alKQpzb8xQGcndO1yiqZlFQbhlDKqFcKfJXebVprt8O Me5evxPyY18InEREs+FrM6Fq7IWYixJTlL4ovBnSYDNJX/0nOqbJ5+MOBq17re0CLfsA azFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787507949; x=1788112749; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=I19+PjIQNnODooxQ97qMirgzt/rnck5BIrQXPDznt18=; b=RrJn6kRweqNB77hA3iL9TRcQQ81cptEmI/veDKz9BO4zLVLC3nwsmlz/+jjzsaSB/u NHnCO+DiJ8PBQFQgQyMHcN0bjpGYCq8B4PzXb2RaItQac6Jf6Vlp6ZJKlbrYdyXQ7z8C IHLsGWhfPcEq7HpF+DJEQeBhBek/XFm4nKL3QoOtPmXCTaSbzIlpueUsA8ecnQHDVwDf iqTR4zLCLchLbjGpzrdqkre9q77ahPdedZ38IOV9iYwf23JRULXl9xSAI1ApIAUmdIWe G8AmaZByq6EDWMM2umLGUfwQtLybST+D+aD3k+iUrTDFwdp+QiievfoNoXuIKJrYnRZI ZIjQ== X-Forwarded-Encrypted: i=1; AHgh+RpkwNFYmdHo6fjWC+J3GYKY0UTCqnQw5LZuKtoP+hpSjyNQyieOpVLq8WC9RfT6Rra3oLgbs32hjS2Y8YA=@vger.kernel.org X-Gm-Message-State: AFuF++k9qdW9ZN224NXAEf0YtUer1tIJHny4cXZmJRKvsSlqcUUymEww 2hV0dYQSvPT48HLeUxFbXK5QRXcpM0pS4lrBuZMMYUTBPeYe+eaaWnAW X-Gm-Gg: AR+sD11zDcv9tkKZ3LjOEpN5IbZ6ptHwh/jkUOplxJLkbBK8C8DoyYhiK44IUx0s+1U BKpaeukxBNg7jO1jf1rcJHUcLCjogiGNWGtoFTN/VuyxfMLFKMqFnHVodViUhviw5CmV8ur37qR 8MP4fV01RiVsBRs8yHFCgj4jlJVEURBfVF38bjHFnvx/Yb3cb0nRuVkIfFBLEFW5g1w403xpuJb Eo2lyEMNgaNsQWY+gxvr+cCm7ske9yR/GLibKmQjsIq0SuSYt3Rz+J8Jwsj2UKYSREDVyP9lUnn i2VU9RCXHnHXYT6RGYYNTyJKs3ZktemYIUWcGOgB+XuFWTmw7TH1E0oJCNKbv40LlQ/94mzaUUB Oo90f8jg4DaJvPu0mATiPbbPbaox2X/0akw8axM8P8JU0rmzxwu20l4515RGeNcUPFKvlM3p41R zVs4nltKQXL+dBLHLBOBu/6Tkn1dd+YELoi7E3HsJcminffuNkXo6Na7PT2HhvdZTo3XdZY89It tT4Og== X-Received: by 2002:a05:6402:50c8:b0:6a3:87b7:b516 with SMTP id 4fb4d7f45d1cf-6a582b25777mr12416486a12.6.1787507948478; Sun, 23 Aug 2026 10:59:08 -0700 (PDT) Received: from [127.0.1.1] ([2001:4bb8:148:9afb:38d7:b606:f380:289e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e199cb8sm4153933a12.16.2026.08.23.10.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 10:59:07 -0700 (PDT) From: Javier Carrasco Date: Sun, 23 Aug 2026 19:59:01 +0200 Subject: [PATCH v2 1/4] hwmon: chipcap2: fix channels in humidity alarm notifications Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260823-chipcap2_locks-v2-1-6a26c8e9e2fc@gmail.com> References: <20260823-chipcap2_locks-v2-0-6a26c8e9e2fc@gmail.com> In-Reply-To: <20260823-chipcap2_locks-v2-0-6a26c8e9e2fc@gmail.com> To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco , stable@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1787507945; l=1798; i=javier.carrasco.cruz@gmail.com; s=20260111; h=from:subject:message-id; bh=fLQQ4JIzzuT4Vt7XQPvCoVjlsMWHJ7PoqIP957VnMqs=; b=9DUBcEZ9MfS/ltCluXensv7cQ6cP7LfZorGh88txRsFUX+EwvMAMqF2RGAFz/vH3vAEqb42Zd RGRLru7TivxAIWPl1JUrYOhqOOpzQoBtyAkat3Mxk0WO0XMFGsXdH3/ X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=Lge8w8xidNSf/INy7JAIbAW+Hezkp3nsBh2OjKL7lLU= hwmon_notify_event() expects the channel number as its last argument, taken into account with the type parameter that it is a humidity sensor type. Given that this device only provides one humidity channel, 0 must be passed. The custom construct to enumerate the channels makes wrong assumptions by listing all types together (temperature and humidity). Remove the custom channel enumeration and pass the right channel to hwmon_notify_event() for hwmon_humidity_min_alarm and hwmon_humidity_max_alarm. Fixes: 3af350929e75 ("hwmon: Add support for Amphenol ChipCap 2") Cc: stable@vger.kernel.org Signed-off-by: Javier Carrasco --- drivers/hwmon/chipcap2.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/hwmon/chipcap2.c b/drivers/hwmon/chipcap2.c index 086571d556b7..9bef767b589e 100644 --- a/drivers/hwmon/chipcap2.c +++ b/drivers/hwmon/chipcap2.c @@ -92,11 +92,6 @@ struct cc2_data { bool process_irqs; }; -enum cc2_chan_addr { - CC2_CHAN_TEMP = 0, - CC2_CHAN_HUMIDITY, -}; - /* %RH as a per cent mille from a register value */ static long cc2_rh_convert(u16 data) { @@ -499,7 +494,7 @@ static irqreturn_t cc2_low_interrupt(int irq, void *data) if (cc2->process_irqs) { hwmon_notify_event(cc2->hwmon, hwmon_humidity, - hwmon_humidity_min_alarm, CC2_CHAN_HUMIDITY); + hwmon_humidity_min_alarm, 0); cc2->rh_alarm.low_alarm = true; } @@ -512,7 +507,7 @@ static irqreturn_t cc2_high_interrupt(int irq, void *data) if (cc2->process_irqs) { hwmon_notify_event(cc2->hwmon, hwmon_humidity, - hwmon_humidity_max_alarm, CC2_CHAN_HUMIDITY); + hwmon_humidity_max_alarm, 0); cc2->rh_alarm.high_alarm = true; } -- 2.43.0