From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa2-f11.google.com (mail-oa2-f11.google.com [74.125.231.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90E26331EA4 for ; Sun, 23 Aug 2026 05:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.75 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787464443; cv=none; b=OUD/pYpj5q8r1bnbfB289BS5FspyRG5pLo8C66MmQag68uT7o4dYSdFevdM27OpHX8kOPuZW0WxHYBPw0DQ4f2ZcZ7LWuhk3t7/qKhbND5+J2U9ZRNHyW5+RF9bIatfhGczej8qm/+wk7kyoxE1oQT9x+ksUyGKavT5Gk/Vf+iA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787464443; c=relaxed/simple; bh=tpjh1uatBlhYLlD5vAk+xB/DquSmvzWDtmA63zML9yw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c1+K6NGqrrpPhf2D16ONrsA2Dxu4IYUz/mI0MOVvD5g9KAs7+Jc6BoS748TUG1CwE/gRMHfP76wMAwCWzD+4gVbQkHYMd0pzgqcqt3kVdEXYDmMyaZJ2n8zfoITlGthbY/lydTjMyYMMrNI410o7qxaQQnBZ5U6Sf79z0SYuFNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FGHx/5EM; arc=none smtp.client-ip=74.125.231.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FGHx/5EM" Received: by mail-oa2-f11.google.com with SMTP id 586e51a60fabf-462dec1c4c5so1083274fac.0 for ; Sat, 22 Aug 2026 22:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787464440; x=1788069240; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rsONA6Rm8WFDnPmCZS0NGqffUBQ3s2z+UFLSP3FHVZc=; b=FGHx/5EMVRqr4KbrmtOJn9a3Tax/TJWfkhT9KSdpP59KuAmZ1rcloM6h5q1PU/cdam hfX2MBNPyKwRN0DRIfaL0RA5QhQk3twceha+bZgYrFWE+a+FqMMQpVfokmjmRPhAbUf8 Bxh8YsRC5MWPbLDHbpFAxB+1sKbVy9v0cYOs5D7VZn03/TPQ6l27lc7Nn/8qUkVHxTR0 ClQ869WwWzTfo6Cs4mEjsb4XDxg56CwHgfRP/5Wy8gPC+adOaaYWqpLuC+hIq22ZB7Jf bM+EOM2LUgkscKTl/QwGqh3dy//+O2oEL8h4WoD2ShPbEGI9WXxJdW3q3WNtjrBihorj +Srg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787464440; x=1788069240; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rsONA6Rm8WFDnPmCZS0NGqffUBQ3s2z+UFLSP3FHVZc=; b=NP/YaItUM58hvNjAFtRsl/bSWdLbpO3MrEgbA+MGfb3sklYx6SEg0I8AS7uY7CBBuF cYUhb9GTxcNiAD5Gpklc7m/PyZ3IneYPy59G1RZ/80yHImmBKYqXRX8IXiRgYLYKqGbc HnN8LXt6CN2oPb3BcXK+8HA0XDoQaROQXg7XlLlKNjwy12ELR3mmLBdPc/IkPwlpufAp oaXEOxvWfmw5pyTNh4aHwYmpg5OrS8d43V9gQZO3QvYX37L7Je2biSSzwdfVDf4/dYOY 9pR3phbu1pymH+kSNuAKWf3tGHmPN5N0daf5wcKGliv8hda3ZMHsKkHDU9G4QF8oX32i vnGA== X-Forwarded-Encrypted: i=1; AHgh+Rpe7u1Hf68HwDchcVIn4mQRokenQhxNTTQNzngegoBZEJ7cagX3Ss06dS/QwOPe34iEIIMCVaijnY4osFo=@vger.kernel.org X-Gm-Message-State: AFuF++kv5lzlF0F5zJxokbtAhFxYmo0/HpKDNlueBVcpGDLd/T8AON3b AtK3T/S7eoGlfbTm/jyfFaZmIyg9CgUpcqmS74KeEb0Fzbn4Xpl/jd31 X-Gm-Gg: AR+sD11+9l96w+jw3nMzOkplKntvNQKFsFdqRXB69VSqSESdMCm+khZOrWbeU43ps4a NE7oEWZYnTRvVe+6ZMUUPkuFZgQaw08VahR8IZzebjNb8Prj2o0YfpZL1gMJ4mvwrHx9axjG0hM grmxoyS7o5ZAw/Mk1a30NhLCczZc1EHmBjcdW+HcJv0583gDyw1ux/EFgobkhkyBk0NTQMCiNuY flJenTYqlpnwApgroWP8JVdKw7ozBMqeb5nEjC0CNCxUpnnD2JUceb8WjVY6HjAWhJgs4j7Mx+y P8FKw/LPCrcUhC7PVOvHy/9LdNg1jef9BmqDVizjPDzBFifQylvg3k0X/gm83nENZreHZEHXIMd WV6YbcR5SfFlO+SzTv7pdHL27ffAxGuYNtSTSM0TEtapvyKQHHso7QOevTGjEoK2hnNLFcK7B4Y G3nELNEjLc3gT415lCFRfwd8x4aiZhnxfYFI0ijbQrLxn7TPyYJJluZMAxOB5WyELEGEn0UnP38 EqWaeg9WqcewWv8NbPGJQbD3cADmfYM19tz X-Received: by 2002:a05:6870:80d3:b0:44c:5514:4e7b with SMTP id 586e51a60fabf-46350f9e304mr18570451fac.2.1787464440308; Sat, 22 Aug 2026 22:54:00 -0700 (PDT) Received: from localhost.localdomain ([14.22.11.161]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4638313340dsm2791832fac.2.2026.08.22.22.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2026 22:53:58 -0700 (PDT) From: Henry Martin To: netdev@vger.kernel.org Cc: David Howells , Marc Dionne , linux-afs@lists.infradead.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org, Henry Martin Subject: [PATCH 3/3] rxrpc: recheck RXRPC_CALL_TX_NO_MORE after sleeping in rxrpc_send_data() Date: Sun, 23 Aug 2026 13:53:18 +0800 Message-ID: <20260823055318.371374-4-bsdhenrymartin@gmail.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260823055318.371374-1-bsdhenrymartin@gmail.com> References: <20260823055318.371374-1-bsdhenrymartin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit ae4f89989479 ("rxrpc: Fix ability to add more data to a call once MSG_MORE deasserted") added the RXRPC_CALL_TX_NO_MORE flag and an entry check in rxrpc_send_data() to stop late sends on a finalized call. However, the check runs only once at function entry: when the transmit window is full, wait_for_space drops call->user_mutex and sleeps, during which another thread sharing the same user_call_ID can finalize the call (queue the LAST packet, setting TX_NO_MORE and clearing send_queue). Upon waking, the reload path only re-verifies the shutdown flag and call state - and a just-finalized call is still in RXRPC_CALL_CLIENT_SEND_REQUEST until its data is hard-acked - so the thread proceeds to rxrpc_alloc_txqueue() with send_queue == NULL but tx_queue != NULL, triggering: WARNING: net/rxrpc/sendmsg.c:297 at rxrpc_alloc_txqueue and returning a spurious -ENOMEM. The call state itself is entirely legal at that point; the WARN_ON's implied assumption that send_queue == NULL implies tx_queue == NULL simply does not hold after finalization. Re-check RXRPC_CALL_TX_NO_MORE in the reload path after reacquiring user_mutex, mirroring the entry check, and bail out with -EPROTO. Found by the autokbug dynamic kernel fuzzer at Tencent Yunding Lab. Fixes: ae4f89989479 ("rxrpc: Fix ability to add more data to a call once MSG_MORE deasserted") Signed-off-by: Henry Martin --- net/rxrpc/sendmsg.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index ed2c9a51005ad..b39af552c6b46 100644 --- a/net/rxrpc/sendmsg.c +++ b/net/rxrpc/sendmsg.c @@ -358,6 +358,14 @@ static int rxrpc_send_data(struct rxrpc_sock *rx, if (txb) rxrpc_see_txbuf(txb, rxrpc_txbuf_see_send_more); + ret = -EPROTO; + if (test_bit(RXRPC_CALL_TX_NO_MORE, &call->flags)) { + trace_rxrpc_abort(call->debug_id, rxrpc_sendmsg_late_send, + call->cid, call->call_id, call->rx_consumed, + 0, -EPROTO); + goto maybe_error; + } + ret = -EPIPE; if (sk->sk_shutdown & SEND_SHUTDOWN) goto maybe_error; -- 2.43.0