From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37A79386453 for ; Sun, 23 Aug 2026 11:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787483599; cv=none; b=WCOPoQ02sJroB4AKw3jjY8cLh7xZceTyFdBQpO9bZkae6Dktzzwb3YKcCQyljlma//FWkV+S+qvpjySBPnGqsyBKPhrXm44wWw3AO/hrpJGc7AaZKY3tZP6Nnsmh6S8R9XeM5fUlhwCkJcTeH8xt9JY0Oe6cRDbpyh3GmzWsywU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787483599; c=relaxed/simple; bh=xth3PpsD/R1SVqMthiDfUSRUm2rpROL5WGR6XXSAez0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XbRT/yHHqESPyGCiH0XeCZA+ksXTe188ELN3qC3cqq5IX5i7+WVcf3UEq8cCbnGfGdJAxOjCUyqpaKqXGqXalL022gtvI+ITZJM7YXfq9b62VMKGVLnNWZSw1jcExRC1OX4ln++fFKZTVg2+n9mJKs036a2g4WtXNyRoAZ/C0s4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHY/goys; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHY/goys" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38759bcd877so2920979a91.2 for ; Sun, 23 Aug 2026 04:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787483597; x=1788088397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=wgY94qKXlhDHQf9KtRFDRAjAJxPnUtzsYlEQ2yUbOwg=; b=dHY/goysq/ShGMNjAhd+gY/xqqM6PEYSGWdSp1d4MnCnQt3cO6fm/jr/dO/ArSThO7 97QJcIoUzBePnkhWCi+nAQClJsmIvGUV8BeenGvqv9jDz4u+B5Y9E/kgEZznecVeo7Q0 Y7xB8nL2BELNLKyIG7mLDIxCl/xwpEY/KA3b+5xGHDB9+V/HiR0+KbwnkqnmMG3NuQ9V sunlhYfscG6obExLuJiV8DyFW56rB1VDD7eo2JcQCrcIjPPNrIAP0pbIoEHB1kGQXlng CZOno3oykXAI+egAIt2a1ZOfTnTv8bDUwOG59ldZHrzdDYpa8BxNgSzBUWEsL7lmgKvH EjXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787483597; x=1788088397; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wgY94qKXlhDHQf9KtRFDRAjAJxPnUtzsYlEQ2yUbOwg=; b=eoTnNUhFnXp2nPaW/MFkRk/OiA3N6+QT4scMip6nxVT9LEoYurYL5N4gT0iMOXQjm5 RdtlLQ34Y7Wp4cC592tBYX2oScUvsqZwajf9uLxeTzjHiWLbuJFttVCAHLGjzc1L/UvC /UkamREMm5hBW38TeCJOu0ekHrCPjXDViuwcwFokIhX0Yg0Fe0HGmicbYnS4BZBBW9RR zCLQ/u49qt28S/km/WHEcJvbStb6fAHTBP/NwhxnmWzOBdVPxez2NftAlssYou2XZ3t2 B7pfA2IFRB9NeyZnaOhhLAtLmPbavTx85aUCryEc9/R80Zc55W0WtdaeuSIcJ24JnD2U 7lAw== X-Forwarded-Encrypted: i=1; AHgh+RrPyVxBrQoxXLxYWZJRSRM5Zplj3O4kERf846Xi8jxDShiexNBLiOJInhRa6uLj4cpaJda4538WA/3fewk=@vger.kernel.org X-Gm-Message-State: AFuF++kvz8iQBmnnp5MZ23S38XoosCIAhcsE63DKC0VzpUKhb1qTu894 7AXUhUSAbrJw6tHZq0C0u37wQcuLgnYjoubrzv9UxEy6nKF/0N/OzDoL X-Gm-Gg: AR+sD12Vrf9YxBnGFZFiJ+AOaF+XrG6K5t7AjGs/mL5nGcLw5ZEQreHFXrQl3WnjYX1 8MVONlL/UTG1sFCwLcClKQBkkuO/SuMg82oK43hNdHKEnZ3tQZ2ewFT7wyjK2aDgWlrfG0+jIU9 /hTDKuTrMllZjXv/UTh340sbqPHoB2moj82HQF9JBhoiyAG2M4WhQeKxde64LeoPFQGmyCYFE1q 0zg0OJXgyTQZjnK/O4zBaWE6JuAy6vHXqTKPzi0iiIZbJpMbIQCTC0wXgm842SKgy/xSNjli/Tl 0WAylnFJN18g+0s23qyMHhNLvaCCe4eoBkSldUHfLsGNkMbvt6JlYUqet5UEXnMkCEmTF9LtNyN a9jseQEaHDoYQa19Soy1DzjTWizLfN+fNvI/EVN/MfYOpTeW4uzQv2w6usVgqd3Cldy5uu4uy6L 3jCtoNL9rQzF9P/1yevuAf6x3fQOjRptGjAHZmlRyw06Mpd1RZLZ+LWiCVDvzw1GuStZX1Ga8MK I4s35PkTfDg2f+bz8K7dt4/RNMw3YclBhi/z2ebWXO0b4N7r0HGI2Q17s1g/+/kYdl1LQuNq4kq X-Received: by 2002:a17:90b:1f8d:b0:38c:a59b:5189 with SMTP id 98e67ed59e1d1-395df67778fmr19661597a91.15.1787483597366; Sun, 23 Aug 2026 04:13:17 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:94:a5e3:6c88:cdf4:5469:310]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1418619d6e1sm17486222c88.15.2026.08.23.04.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:13:17 -0700 (PDT) From: manushprajwal To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: fancer.lancer@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] misc: eeprom: idt_89hpesx: fix fwnode leak in idt_get_fw_data() Date: Sun, 23 Aug 2026 16:42:59 +0530 Message-ID: <20260823111259.1937-1-manushprajwal555@gmail.com> X-Mailer: git-send-email 2.46.2.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit device_for_each_child_node() takes a reference on each fwnode it returns, which the loop body must release before it stops iterating. When idt_ee_match_id() finds a matching EEPROM child, the loop breaks out immediately without calling fwnode_handle_put() on that fwnode, leaking the reference. Add the missing fwnode_handle_put() call before the break. Signed-off-by: manushprajwal --- drivers/misc/eeprom/idt_89hpesx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c index e056d2dea..f32c27855 100644 --- a/drivers/misc/eeprom/idt_89hpesx.c +++ b/drivers/misc/eeprom/idt_89hpesx.c @@ -1082,8 +1082,10 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev) device_for_each_child_node(dev, fwnode) { ee_id = idt_ee_match_id(fwnode); - if (ee_id) + if (ee_id) { + fwnode_handle_put(fwnode); break; + } dev_warn(dev, "Skip unsupported EEPROM device %pfw\n", fwnode); } -- 2.46.2.windows.1