From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89F18339372 for ; Sun, 23 Aug 2026 11:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484043; cv=none; b=XkGkk2cYUQ0Oq+PxLBIvZrGjcG7vz9q64Yf6xv6ik/aMrTTpxfn0viFF9qQ6t+c2keb6r5pgupk50jM0qQ45b/nsfcesnB7J3rKA0xXNxcu3MQYJ1GGqxPCUo9m2Gv+xHJgkVOjUkNHmsKqtaOi4ldy7i4K8ZfZ+W86F5N/Sh5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787484043; c=relaxed/simple; bh=lOHqOlIvPJWO2MOvJv0kGLGvV1DZo4M8ElXRI6PgaVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tQ601k+DbVEk9EXdwf5EcAlzPy47ARc2jKCmEGQwkaeJssaeTi7VTwvmdp9v+CHcgXostcDGQsFLT0zgsEexnqrkkUi11tt8++efPlCqNY9cPZdm6LC6gC+9c3ZjvpGOIhKL5NFVX0DYInIGIC2RdpCermOY5PpoyBwbkK+DIGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VRJBnE/9; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VRJBnE/9" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c15cf78d1a2so282242366b.1 for ; Sun, 23 Aug 2026 04:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787484040; x=1788088840; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hXbW16L5wvPepfurbHdIAab5lg7qHN9GJKcsA1M84NI=; b=VRJBnE/9klHRKPMsWMz0i/UfnR2hN3k5oCq2HAomABU5oAAlYQOkd02sx+LmmgN/wX M+0k06PMDNapxwrnRYwRBMU8KGVoFuqkE3ev6kaSFBNeu5YKno+bDPH0Lwyp/kfMOUhF zXxnXsNOHfVxfw5X0h4Fu4e4CkGhEq6Wik/VaSxVNotdSP7qgReGS5Okh5bCNlsFK7ku k6fcdLGbGuAp8A347JEul3hBptUyiAwStlP+4nX6t0HBeqKXFos0h0+frxmTnBXssJBi P0PkW3fs16uxvckeOzFMkq3vZpoHUxQmQoZdydreAyutUgkysQfqAWs1TidU0IXT0psI QPew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787484040; x=1788088840; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hXbW16L5wvPepfurbHdIAab5lg7qHN9GJKcsA1M84NI=; b=dhcVb1GP05dYH+Cwl8DOrxYoCo+LFIMC+e40WBAQSnEt/M0VYcU4mbTprpiQbCtXN/ O3UyKPpdhlmefYRCkIa04iJyC+VV1QjrvIpwLHNB6Tj6ywcvBauut+HJhBZayLcKD3yX 9cRTATJz6A+ewsds1HnZWH4xm9X6MBUX/Z6lVkNt2JRO5eOxzt8sKRvqfAHZyy8AOOw1 Sf+ZWGGKNmNMzJFJ8Fq4x6o/6Qn5sme1ockz7vhV32i1F50Yjyw5mE1KICrJUb3DucBP F8WLbYb11xcXT3h1Nvz+LyiU2ThI4RmFHDKgRFUjytopBRHd9qBzS8+1RQZuALNNPukL 3DXQ== X-Forwarded-Encrypted: i=1; AHgh+RqsGX02JKI71eChZGuOVEGJTwiiJGAUZf71BCQ1rNRv3w5ATvpFph+7XuCFTuSr8Yszpkjh37U6grKFC20=@vger.kernel.org X-Gm-Message-State: AFuF++kJfyT/2qp9YOP4oIj15FZ/4ukjtsoIfPsvkOtB6xnWGH+qdHji aKxbApFpuPpGJ7m2pBFyRtRhngTAnLxseeuY9BvhVj6m6+DQhYSZAWv4oYQdBw== X-Gm-Gg: AR+sD13kzQFLSPHNKsSYhMItWJ/2MDmLIrYtO8FxfwajyQGo/B4IyBET68sCsyFXQvU pO9XhjFPoeYmboyi15EkxtKWu1zDhFe+l/cMn6YRnRgzExuqGOgBnvRUDodLYy/8LyCB5kItuOy 5ysKyiwpEFIhjF9R+Ks5juQIryUYsQL72pxr5dmI+Ae9CrIoznJB/g4v8iLk26x4Tk1Flq/ReKw /0n2+6rHbkCouD/1sKXjnVbkq7O1jkjTf6z3zfJY4d5atwZX/nJPm7f0tXdN2hjNJEZm2cL49IL aeGUjCqpj6wBX/OHFCGFOLLFmrQCOD/SY1nI3DAWmC5eXmsJgE1vxtPt9v82aTXE3dX8sw4hYls 84UDGoMDgfuZhy0gu8KCVNQ9zTLVN7zWadjPrOorA2fSHZqDxkX9lMhevkg3/RVtRmG/x68+qjG zHZaSkqwsmWQufKwU/FQ+GxDdPT63SyI6lg/7wahn8DKwCdQK0Hi6ie7YaQDQhhmfKBg== X-Received: by 2002:a17:907:1b0b:b0:c12:e178:9e68 with SMTP id a640c23a62f3a-c246a63071emr1921055866b.19.1787484039486; Sun, 23 Aug 2026 04:20:39 -0700 (PDT) Received: from thinker ([2a13:54c2:f000:e268:6d0c:d746:2b12:231f]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f58dfsm707233866b.38.2026.08.23.04.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 04:20:39 -0700 (PDT) From: Amit Barzilai To: javierm@redhat.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: andriy.shevchenko@intel.com, holofermes@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Amit Barzilai Subject: [PATCH v5 4/6] drm/ssd130x: Replace positional ssd130x_spi_id[] initialization with C99 Date: Sun, 23 Aug 2026 14:19:57 +0300 Message-ID: <20260823111959.17029-5-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260823111959.17029-1-amit.barzilai22@gmail.com> References: <20260823111959.17029-1-amit.barzilai22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ssd130x_spi_id[] is initialized with positional initializers, which easily create easy-to-miss bugs when changing the members of the target struct (struct spi_device_id in this example). Change this to C99 initializers to guarantee each member is initialized with the correct value. Signed-off-by: Amit Barzilai Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/solomon/ssd130x-spi.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x-spi.c b/drivers/gpu/drm/solomon/ssd130x-spi.c index b52f5fd592a1..be50e5aa2c87 100644 --- a/drivers/gpu/drm/solomon/ssd130x-spi.c +++ b/drivers/gpu/drm/solomon/ssd130x-spi.c @@ -160,17 +160,17 @@ MODULE_DEVICE_TABLE(of, ssd130x_of_match); */ static const struct spi_device_id ssd130x_spi_id[] = { /* ssd130x family */ - { "sh1106", SH1106_ID }, - { "ssd1305", SSD1305_ID }, - { "ssd1306", SSD1306_ID }, - { "ssd1307", SSD1307_ID }, - { "ssd1309", SSD1309_ID }, + { .name = "sh1106", .driver_data = SH1106_ID }, + { .name = "ssd1305", .driver_data = SSD1305_ID }, + { .name = "ssd1306", .driver_data = SSD1306_ID }, + { .name = "ssd1307", .driver_data = SSD1307_ID }, + { .name = "ssd1309", .driver_data = SSD1309_ID }, /* ssd132x family */ - { "ssd1322", SSD1322_ID }, - { "ssd1325", SSD1325_ID }, - { "ssd1327", SSD1327_ID }, + { .name = "ssd1322", .driver_data = SSD1322_ID }, + { .name = "ssd1325", .driver_data = SSD1325_ID }, + { .name = "ssd1327", .driver_data = SSD1327_ID }, /* ssd133x family */ - { "ssd1331", SSD1331_ID }, + { .name = "ssd1331", .driver_data = SSD1331_ID }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(spi, ssd130x_spi_id); -- 2.55.0