From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-112.mta1.migadu.com [95.215.58.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7544D3A1A26 for ; Sun, 23 Aug 2026 18:59:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.112 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787511568; cv=none; b=ejsU0vXFHrfNoFOoer5I+ztEqgwpBgyxo1JTCinIVlvr16wyIlg8E98AWFYaKs+3SaWytwb5+YVditz5MYrzH6/P1W0BacT2Yxx9W1W9Ff/LJ/7HRYfQLksFOWuwHcwjWVK60C45hTYpDmmL2XrCWkXw9hXYhl3TMNh/nRjYZWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787511568; c=relaxed/simple; bh=lbUBXbNlSnzsLpmbzl6FRaFyC1WdyRAjKDj0YiBe2IA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a0XwKcq92uwj/NdL6hl+ze1qF4OpaPSYmcgKszz12PEiYaqlIDF2uQ5XWMMDwVuFX3PY87nUqjanSkSu0poVGedpDf2wNKyW9Y1S+L9zlL3yqhsfJh+esDpC0hyQXE24xXVk0NEhtb7T6oqpXYSr/bYTuTGsgpF4E/8pSVrw4xI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fkdgEkFd; arc=none smtp.client-ip=95.215.58.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fkdgEkFd" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=lbUBXbNlSnzsLpmbzl6FRaFyC1WdyRAjKDj0YiBe2IA=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787511563; v=1; x=1788116363; b=fkdgEkFdCC6JM89/AnTjNLZmA4A6m0H9el/u34ZxGD4CHBZoEmZnt9iy4hvLvEmYHGRcIqfJ jnDcJRmYdidT/LI6QTTNcxtRh3nupZgq4/5ONTg1vUFEQBpZOTIV+//7bvNul0LzRSL09IuH7e2 gY76kW7ojyKiK2aKUVr+QXmA= X-Envelope-To: linux-kernel@vger.kernel.org Received: from kernel.denis-pc.lan (151.61.14.130) by smtp.migadu.com with ESMTPS id 7008871eadd1596b; Sun, 23 Aug 2026 18:59:23 +0000 X-Mizu-Trace-ID: 7008871eadd1596b X-Migadu-Flow: FLOW_OUT From: Denis Benato To: linux-kernel@vger.kernel.org Cc: linux-input@vger.kernel.org, "Benjamin Tissoires" , "Jiri Kosina" , "Luke D . Jones" , "Mateusz Schwartz" , "Denis Benato" , "Jonathan LoBue" , "Khamunetri Clark" , "Derek J. Clark" , Denis Benato Subject: [PATCH v3 10/12] HID: asus: add support for gamepad mode Date: Sun, 23 Aug 2026 18:58:47 +0000 Message-ID: <20260823185849.2478673-11-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260823185849.2478673-1-denis.benato@linux.dev> References: <20260823185849.2478673-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ROG Ally devices can emulate either a mouse+keyboard (desktop mode) or an gamepad device (xbox360 controller in ROG ally and a custom DInput device on newer models): add support for switching the current controller mode. Assisted-by: opencode:glm-5.2 Signed-off-by: Luke Jones Signed-off-by: Denis Benato # Conflicts: # drivers/hid/hid-asus.c # Conflicts: # drivers/hid/hid-asus.c --- drivers/hid/hid-asus.c | 185 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 183 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 04bf2c6ca449..258d63f4233e 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -390,6 +390,20 @@ enum ally_command_codes { /* XInput rumble magnitudes use the hardware's 0..100 intensity range. */ #define ALLY_FF_MAX_INTENSITY 100 +enum ally_gamepad_mode_index { + ALLY_GAMEPAD_MODE_GAMEPAD = 0x01, + ALLY_GAMEPAD_MODE_KEYBOARD = 0x02, +}; + +static const char *const ally_gamepad_mode_text[] = { + "gamepad", "desktop" +}; + +static const u8 ally_gamepad_mode[] = { + ALLY_GAMEPAD_MODE_GAMEPAD, + ALLY_GAMEPAD_MODE_KEYBOARD +}; + static const u8 ALLY_FORCE_FEEDBACK_OFF[] = { 0x0D, 0x0F, 0x00, 0x00, 0x00, 0x00, 0xFF, 0x00, 0xEB }; @@ -874,6 +888,152 @@ static ssize_t xbox_controller_store(struct device *dev, static DEVICE_ATTR_RW(xbox_controller); +/** + * ally_set_gamepad_mode() - Set the gamepad operating mode + * @ally: ally handheld structure + * @hdev: HID device + * @mode: gamepad mode to set + * + * Return: 0 on success, negative errno on failure + */ +static int ally_set_gamepad_mode(struct ally_handheld *ally, struct hid_device *hdev, u8 mode) +{ + u8 payload[] = { mode }; + int ret; + + if (mode < ALLY_GAMEPAD_MODE_GAMEPAD || + mode > ALLY_GAMEPAD_MODE_KEYBOARD) { + hid_err(hdev, "Invalid gamepad mode: %u\n", mode); + return -EINVAL; + } + + u8 *buf __free(kfree) = ally_alloc_cmd(CMD_SET_GAMEPAD_MODE, payload, sizeof(payload)); + if (!buf) + return -ENOMEM; + + ret = ally_gamepad_send_packet(ally, hdev, buf, ROG_ALLY_REPORT_SIZE); + if (ret < 0) { + hid_err(hdev, "Failed to set gamepad mode: %d\n", ret); + return ret; + } + + return 0; +} + +static ssize_t gamepad_mode_show(struct device *dev, struct device_attribute *attr, char *buf) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 mode_byte; + int i; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + guard(mutex)(&cfg->config_mutex); + + mode_byte = cfg->gamepad_mode; + + for (i = 0; i < ARRAY_SIZE(ally_gamepad_mode); i++) { + if (ally_gamepad_mode[i] == mode_byte) + return sysfs_emit(buf, "%s\n", ally_gamepad_mode_text[i]); + } + + return sysfs_emit(buf, "unsupported\n"); +} + +static ssize_t gamepad_mode_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct hid_device *hdev = to_hid_device(dev); + struct asus_drvdata *drvdata = hid_get_drvdata(hdev); + struct ally_handheld *ally = drvdata->rog_ally; + struct ally_config *cfg; + u8 mode_byte; + int mode; + int ret; + + if (!ally) + return -ENODEV; + + cfg = ally_get_config(ally); + if (!cfg) + return -ENODEV; + + mode = sysfs_match_string(ally_gamepad_mode_text, buf); + if (mode < 0) { + hid_err(hdev, "Unknown gamepad mode\n"); + return mode; + } + + /* Convert the index of the text mode array to the byte + * that will be accepted by the ally MCU. + */ + mode_byte = ally_gamepad_mode[mode]; + + guard(mutex)(&cfg->config_mutex); + + ret = ally_set_gamepad_mode(ally, hdev, mode_byte); + if (ret < 0) + return ret; + + cfg->gamepad_mode = mode_byte; + + hid_dbg(hdev, "Set gamepad mode to %s\n", ally_gamepad_mode_text[mode]); + + return count; +} + +static ssize_t gamepad_mode_index_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + int i; + ssize_t len = 0; + + for (i = 0; i < ARRAY_SIZE(ally_gamepad_mode_text); i++) { + if (!ally_gamepad_mode_text[i] || ally_gamepad_mode_text[i][0] == '\0') + continue; + len += sysfs_emit_at(buf, len, "%s ", ally_gamepad_mode_text[i]); + } + + /* Replace the last space with a newline */ + if (len > 0) + buf[len - 1] = '\n'; + + return len; +} + +static DEVICE_ATTR_RW(gamepad_mode); +static DEVICE_ATTR_RO(gamepad_mode_index); + +/** + * ally_apply_gamepad_mode() - Re-send the recorded gamepad mode to the hardware + * @hdev: HID device + * @ally: ally handheld structure + * @cfg: ally config + * + * Re-send the gamepad mode currently recorded in the configuration to the + * hardware: during probe that is the default mode, while a reset resume + * restores whatever the user last wrote instead of overwriting it. The + * shared state is accessed under the lock, as sysfs is already live. + * + * Return: 0 on success, negative errno on failure + */ +static int ally_apply_gamepad_mode(struct hid_device *hdev, + struct ally_handheld *ally, + struct ally_config *cfg) +{ + scoped_guard(mutex, &cfg->config_mutex) + return ally_set_gamepad_mode(ally, hdev, cfg->gamepad_mode); +} + /** * ally_set_vibration_intensity() - Set vibration intensity values * @ally: ally handheld structure @@ -2304,6 +2464,8 @@ DEFINE_JS_CURVE_ATTRS(4, right); static struct attribute *ally_config_attrs[] = { &dev_attr_xbox_controller.attr, + &dev_attr_gamepad_mode.attr, + &dev_attr_gamepad_mode_index.attr, NULL }; @@ -2471,7 +2633,7 @@ static struct ally_config *ally_config_create(struct hid_device *hdev, struct al } } - cfg->gamepad_mode = 0x01; + cfg->gamepad_mode = ALLY_GAMEPAD_MODE_GAMEPAD; cfg->left_deadzone = 10; cfg->left_outer_threshold = 90; cfg->right_deadzone = 10; @@ -2510,6 +2672,14 @@ static struct ally_config *ally_config_create(struct hid_device *hdev, struct al ret); } + /* + * Set the default gamepad mode now that the MCU is confirmed ready: + * failure is non-critical, the mode can still be changed from sysfs. + */ + ret = ally_apply_gamepad_mode(hdev, ally, cfg); + if (ret < 0) + hid_warn(hdev, "Failed to set default gamepad mode: %d\n", ret); + cfg->initialized = true; return cfg; @@ -2915,10 +3085,10 @@ static int ally_x_setup_input(struct hid_device *hdev, struct ally_handheld *all static int hid_asus_ally_init(struct hid_device *hdev, struct ally_handheld *ally) { - int ret; struct ally_config *cfg; struct hid_device *x_hdev; unsigned long flags; + int ret; /* * The force-feedback "off" packet belongs to the gamepad interface, @@ -2948,6 +3118,17 @@ static int hid_asus_ally_init(struct hid_device *hdev, struct ally_handheld *all if (!cfg) return 0; + /* + * The MCU was just reset: restore the mode the configuration + * records instead of forcing a default, so a user-configured + * mode survives suspend/resume cycles. During probe this runs + * before the config is published, and ally_config_create() + * applies the default itself. + */ + ret = ally_apply_gamepad_mode(hdev, ally, cfg); + if (ret < 0) + hid_warn(hdev, "Failed to restore gamepad mode: %d\n", ret); + /* * The MCU may have just been reset: restore the cached Xbox * controller mode, or the hardware would silently revert to its -- 2.47.3