From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54AFC3B05AF for ; Sun, 23 Aug 2026 19:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787514491; cv=none; b=XpgAA4YgV2mP3FOjprSl+iart6+DKpnFjIUHFJViJgkwhtfGKfXwna+5XPFLxSXUi/gXPXtfiELshyY+jWSzGkg/kcLoC8ZqSg5AeKTZwCuGVMCO8TeDUsmYHjpX7zYJhOJsKYG6deN8T2HV1J49X4w37TG767mVS5usnRjfItI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787514491; c=relaxed/simple; bh=yZHf4T0CLB4PjBjPpZVhgQRal0eKbfLeRuyb8wFOOlU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Kn3gqAgpjJpEGZz9RX2+U/+CTQP5pwYcXSOELpyKQDSYDbJlD3QWYlMTou6d68pJNoLh+8NO5ART5JCQKuNnYRhWkxZrpdsod8CDwgkx2vWbQd8SviGoixb4oMAFa6NbQBjDSQYhGUGbAeL7Jq3bc6ErxalulfKNS93sPw76QrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=etVR+Tye; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JpCbO9Pf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="etVR+Tye"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JpCbO9Pf" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67NG7iHO4134105 for ; Sun, 23 Aug 2026 19:48:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ssoNulhqcE9INTHbsFIQlnvQlFudra1iNtux3vGPSYU=; b=etVR+TyefsxuvRFI ZehRM2fVLcmOQefu6Rm3PEXXeTYZARj/sKeFoyKb7NWg3gv82rvNT6Nv1aaUC8pq JgyIQH2Yl/WwxyTeXPNpNaV79CWN6f3z+az/qdg6q6ELYLxqZbhv3afvLPxtQJ9E 9e0XRhn/lLi4AKzSUw/v0A512h5513seakzSzPY2Mz8ZphCWxXDjrBZOFsBvW5GX tXp9rN9N2u1J3DQ7hfUjjqvPtzoPfs3zVrH5VDntVoN4nQhZbHsfKvh6sxAhMYj2 6+i8kAAhCk0IXC32aa2RWw7cDdvjXDaHDqxVLheccwukbao3F8Rk84KQH5Fe2qMb UQ33tA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g7456vfq8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 23 Aug 2026 19:48:05 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-848860def2cso2783972b3a.2 for ; Sun, 23 Aug 2026 12:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787514484; x=1788119284; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ssoNulhqcE9INTHbsFIQlnvQlFudra1iNtux3vGPSYU=; b=JpCbO9PfQKUWdq38+vDr/2aCXoBUvSnpHEUa8jNwBX8ETrS8hO+VhCGUBr86kZYl7U MoGRZimo/eAYOw1R33QrLgepfQVgJ1toIxLnP1pffgc3POuzgMErncgmYeuDz+sZOs1J IWcNWGDqm2ZiA4saaopkcPjkM0IMSMxyTuINHb2vqAEfJxn4DSMeE01qcIbcYfQNlk9i hZfnTt8S4xgYYoOP9O4RLC3fDBuHhOkKebIen7vhUswL65IRKjn6+wssrhHUUIzcjL2T iImfX1mpZcUnugn76XpjTQ7g7j6WlmyPOfrDfPSgP2wnqA0zSLcdKz/mq1LCVFk4fhrx rQ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787514484; x=1788119284; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ssoNulhqcE9INTHbsFIQlnvQlFudra1iNtux3vGPSYU=; b=N6ayxxFv+AlirfisNjoD0wfqGDiCD3ysxdBCg2pOrRAijs9XIquuX7WGPZSvIotHKo yRjXoPaIuNVUrtGFcWQS1R+Dnt5rY4xdPg55fSdXX+wAbMc7viuPhcecJWOtJC8HiA3V dEl6I/BWVALZlsBZgYvX9LJEEJHHzwKNyeaA+NUjOuamFEIdINOjDqKZoadrrOJ3T3t2 aizdaJ6xOKOd9wS2TiDK7dNJ7Qh8BIRBn+kbQLNMdOqsxfJqPevKsIrxfD7Q5iPZDrjz X9Fo7TFShl+lQVu/W7K+AI2pF08HTRhL3b+Jru5uRoArqwh+v6aMWiybOa1F51YVzCxB QBcA== X-Forwarded-Encrypted: i=1; AHgh+Rr9lhFBDBj1KiaHpuRBDz6MYhNoDUOAPLy1ieH8E9AOvIvNgxfQRQlV7p1QoZqFAXFIzklQ8Gv2AnMwKo8=@vger.kernel.org X-Gm-Message-State: AFuF++nPvmfnk/xH6ilfW+l84qwH+tU41ZJChURoLKlyW/m/+yEjyUts vATJHeanjJfjsiyh9pi/F2N4pJav0TbaPCLOzChf3oh0gkn3GpiTfpmQ+fBWDDexRHaOo2VxCCD Zv5FW+ZlmiBWMZBdl/IHiZnwcNdxK5pDLrLB0jciX0os0OwD1ET/+joqS8CFSAXG9Irk= X-Gm-Gg: AR+sD12K8c2pXzfbXAeJdPoTPdmo2oEaDO5wB7eWs9+C+wb4m5jxg/JXfmvVfIUxFNn VHN17pDZUnB4E25zezRFGjw7N7G+tlyi8wsKb2OIBPmxb1nANgHgl6liFDUtDFx1Ode7HR8/mFr UoHpKd3TjYulgys6I3aeAWL1U8xVY8/LuCgwKL39IfW+WRpraiI8QBqlpZhqGHC45cabpoRcJ07 wVx7yOVgSJre7Z+uJXIsKqegMhuObgvvl01Sn1++HL6pU3CaHYfly+DM3E1mdDpIcDpyeSXIBmP +jQJDRWPCzmVe5/AlzLv8y+m+jQy8Hu6fYc3Xbvh2XLb3PzOPO8k9c/h8OnKX4f1mSRMFZ1x/Di qFm/k3HKkAtIsRVwlBE2emyo0LHSk1hZvLRRcPA== X-Received: by 2002:a05:6a20:ce4c:b0:3c4:42d9:58e3 with SMTP id adf61e73a8af0-3cd4bc358a4mr25216854637.13.1787514484480; Sun, 23 Aug 2026 12:48:04 -0700 (PDT) X-Received: by 2002:a05:6a20:ce4c:b0:3c4:42d9:58e3 with SMTP id adf61e73a8af0-3cd4bc358a4mr25216799637.13.1787514484043; Sun, 23 Aug 2026 12:48:04 -0700 (PDT) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f925190fsm32321623eec.31.2026.08.23.12.47.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 12:48:03 -0700 (PDT) From: Abhinaba Rakshit Date: Mon, 24 Aug 2026 01:17:40 +0530 Subject: [PATCH v12 3/6] mmc: sdhci-msm: Set ICE clk to TURBO at sdhci ICE init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260824-enable-ice-clock-scaling-v12-3-09271f583dc6@oss.qualcomm.com> References: <20260824-enable-ice-clock-scaling-v12-0-09271f583dc6@oss.qualcomm.com> In-Reply-To: <20260824-enable-ice-clock-scaling-v12-0-09271f583dc6@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Adrian Hunter , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neeraj Soni , Harshal Dev , Kuldeep Singh Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Abhinaba Rakshit , Konrad Dybcio X-Mailer: b4 0.14.2 X-Proofpoint-Spam-Info: AW1haW4tMjYwODIzMDE4MSBTYWx0ZWRfXynwFyWNeYiQW OPm+lLF0IZ6lBU5gFzRqIGbuSD5+CqxKDPBXdx5YA12c9cyBGc7O5albb02WKw+jlzt0nHL2vKB jUHCLY1sESaRmjxgPYoYCx+XNyIbuNU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIzMDE4MSBTYWx0ZWRfXysMBJJvKD9ir Pf5yB2C1lM2LeiESy9M2IRECYI1y5jgadjhFPt/E82yr6TqxQJv5f4bR+QBwUDe23cknmeFMv7w 3YO+L+Ev+Tz85K+FzGiDI+oQvhttBw5r4B6ZXxwWKF7jO/p8qSsrKaEn+jJiODlLFbl3e+Evxly YZEtIjFU9O2jsfNlmDlAaUc1GO3+jQFYHVcGzWzRqXbgvsoVUk06a+MBc7KoFpXih87B7Xvaopl 9lhoELI0sIHK9c0f3YhvsanbEcaNKSq2i6wWmbDSr8KSyayXcj77mVr+DeSyzrnJ1bpVuLVkUH2 4DIbE1ZOZyMDG2yCpzEEPdUORpBjHh48sCLQUyfbVjuJSaXsZo2Hw/cXxPDdauQYx2P7JOlLl63 +z4tAkEytrY3cWKYv4E2MlIBtIvHD+C6H5VwNhBcINlTVTuFQd3HWPxfK1nv4ZFxb1ae5/Ft6MJ 7Zg8PLszMy8q0iAX6qg== X-Authority-Analysis: v=2.4 cv=RtL16imK c=1 sm=1 tr=0 ts=6a8b4e75 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=QyXUC8HyAAAA:8 a=PzEurhthzZq-M9kHIYIA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: b3hFwaWhc7ID5yjiI47fVkM5Moj80gkg X-Proofpoint-GUID: b3hFwaWhc7ID5yjiI47fVkM5Moj80gkg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-23_06,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608230181 MMC controller lacks a clock scaling mechanism, unlike the UFS controller. By default, the MMC controller is set to TURBO mode during probe, but the ICE clock remains at XO frequency, leading to read/write performance degradation on eMMC. To address this, set the ICE clock to TURBO during sdhci_msm_ice_init to align it with the controller clock. This ensures consistent performance and avoids mismatches between the controller and ICE clock frequencies. For platforms where ICE is represented as a separate device, use the OPP framework to vote for TURBO mode, maintaining proper voltage and power domain constraints. Reviewed-by: Konrad Dybcio Acked-by: Adrian Hunter Reviewed-by: Adrian Hunter Signed-off-by: Abhinaba Rakshit --- drivers/mmc/host/sdhci-msm.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 0882ce74e0c9bdddd98341a67b97bcef74078e0c..1b4c276dce34d76dcbe75117de37e09ea2002633 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1902,6 +1902,16 @@ static void sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock) static const struct blk_crypto_ll_ops sdhci_msm_crypto_ops; /* forward decl */ +static int sdhci_msm_ice_scale_clk(struct sdhci_msm_host *msm_host, + unsigned long target_freq, + bool round_ceil) +{ + if (msm_host->mmc->caps2 & MMC_CAP2_CRYPTO) + return qcom_ice_scale_clk(msm_host->ice, target_freq, round_ceil); + + return 0; +} + static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, struct cqhci_host *cq_host) { @@ -1959,6 +1969,11 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, } mmc->caps2 |= MMC_CAP2_CRYPTO; + + err = sdhci_msm_ice_scale_clk(msm_host, ULONG_MAX, false); + if (err && err != -EOPNOTSUPP) + dev_warn(dev, "Unable to boost ICE clock to TURBO\n"); + return 0; } @@ -2149,6 +2164,13 @@ sdhci_msm_ice_suspend(struct sdhci_msm_host *msm_host) { return 0; } + +static inline int +sdhci_msm_ice_scale_clk(struct sdhci_msm_host *msm_host, unsigned long target_freq, + bool round_ceil) +{ + return 0; +} #endif /* !CONFIG_MMC_CRYPTO */ /*****************************************************************************\ -- 2.34.1